Commit 6ae52c3f authored by Øyvind "pippin" Kolås's avatar Øyvind "pippin" Kolås

move gif-load from workshop to external

parent 55999d4a
......@@ -11,6 +11,8 @@ text_la_LIBADD = $(op_libs) $(PANGOCAIRO_LIBS)
text_la_CFLAGS = $(AM_CFLAGS) $(PANGOCAIRO_CFLAGS)
endif
ops += gif-load.la
  • Cross compiling gegl for windows on Linux (mingw64, fedora 28) fails with:

      CCLD     gif-load.la
    .libs/gif-load.o: In function `gegl_op_init_properties':
    /home/massimo/wingimp/build/gegl/operations/external/../../gegl/gegl-op.h:1001: undefined reference to `g_slice_alloc0'
    .libs/gif-load.o: In function `gegl_op_constructor':
    /home/massimo/wingimp/build/gegl/operations/external/../../gegl/gegl-op.h:657: undefined reference to `g_type_check_class_cast'
    /home/massimo/wingimp/build/gegl/operations/external/../../gegl/gegl-op.h:703: undefined reference to `g_object_set_data_full'
    .libs/gif-load.o: In function `gegl_op_destroy_notify':
    /home/massimo/wingimp/build/gegl/operations/external/./gif-load.c:34: undefined reference to `g_free'
    .libs/gif-load.o: In function `get_property':
    /home/massimo/wingimp/build/gegl/operations/external/../../gegl/gegl-op.h:470: undefined reference to `g_type_name'
    /home/massimo/wingimp/build/gegl/operations/external/../../gegl/gegl-op.h:470: undefined reference to `g_type_name'
    /home/massimo/wingimp/build/gegl/operations/external/../../gegl/gegl-op.h:470: undefined reference to `g_log'
    .libs/gif-load.o: In function `set_property':
    /home/massimo/wingimp/build/gegl/operations/external/./gif-load.c:40: undefined reference to `g_value_get_int'
    /home/massimo/wingimp/build/gegl/operations/external/./gif-load.c:38: undefined reference to `g_value_get_int'
    /home/massimo/wingimp/build/gegl/operations/external/./gif-load.c:34: undefined reference to `g_free'
    /home/massimo/wingimp/build/gegl/operations/external/./gif-load.c:34: undefined reference to `g_value_dup_string'
    .libs/gif-load.o: In function `set_property':
    /home/massimo/wingimp/build/gegl/operations/external/../../gegl/gegl-op.h:593: undefined reference to `g_type_name'
    /home/massimo/wingimp/build/gegl/operations/external/../../gegl/gegl-op.h:593: undefined reference to `g_type_name'
    /home/massimo/wingimp/build/gegl/operations/external/../../gegl/gegl-op.h:593: undefined reference to `g_log'
    .libs/gif-load.o: In function `set_property':
    /home/massimo/wingimp/build/gegl/operations/external/./gif-load.c:36: undefined reference to `g_value_get_int'
    ...

    I think this commit did not add in operations/external/Makefile.am a gif_load_la_LIBADD declaration like the one for all other operations in this directory.

Please register or sign in to reply
if HAVE_CAIRO
ops += path.la vector-fill.la vector-stroke.la
path_la_SOURCES = path.c
......
......@@ -14,7 +14,6 @@ op_LTLIBRARIES = \
bilateral-filter-fast.la \
demosaic-bimedian.la \
demosaic-simple.la \
gif-load.la \
ditto.la \
domain-transform.la \
gradient-map.la \
......
......@@ -177,6 +177,7 @@ operations/core/nop.c
operations/external/exr-save.cc
operations/external/ff-load.c
operations/external/ff-save.c
operations/external/gif-load.c
operations/external/jp2-load.c
operations/external/jpg-load.c
operations/external/jpg-save.c
......@@ -244,7 +245,6 @@ operations/transform/shear.c
operations/transform/transform.c
operations/transform/transform-core.c
operations/transform/translate.c
operations/workshop/gif-load.c
operations/workshop/bayer-matrix.c
operations/workshop/bilateral-filter-fast.c
operations/workshop/demosaic-bimedian.c
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment