Menu questions
(My apologies in advance: this won't be a great bug report as there isn't a single clear-cut "issue".)
I've been looking at the menu changes from #76 (closed) / 3ec741df and I feel there are a few issues / questions to be addressed:
-
With
app-menu
items migrated into the primary / hamburger menu, menus.ui and menus-traditional.ui looks very similar. Would it make sense to merge the two? -
Before 3ec741df,Fixed now.app-menu
items (and sections) had corresponding counterparts inmenubar
(in menus-common.ui); now there are differences. (For instance, I opened !22 (merged) to address the "New Window" section, but I also see the hamburger menu doesn't have apreferences-section
for plugins to add preference items.) Shouldhamburger-menu
and/ormenubar
be updated to fix these inconsistencies? -
When the menu bar is visible (on macOS, not sure if there are other cases), app-level menu items (e.g. New Window, Help) will be visible in both the menu bar and the primary menu. Is this intentional, or should app-level items be hidden in the primary menu? (If the latter, would it make sense to keep two copies of
hamburger-menu
, like in menus.ui and menus-traditional.ui?)
I'm not familiar enough with all the use cases / menu permutations to make decisions and continue submitting merge requests; I thought it would be better for me to ask first.