GitLab

(cherry picked from commit fb3fa337)

(cherry picked from commit 62b03090)

(cherry picked from commit 0c2609b1)

I prefer to have simple, dumb code, which is a little less performant.
Instead of needing, in the future, to deal with more tricky code (to
port to new APIs, to debug the code, etc).

Although the code is portable, it's only used on macOS, and the code
would definitely benefit from a haircut (like many people in the world
right now).

Currently, gedit_recent_add_document() and
gedit_recent_remove_if_local() are used only in gedit-tab.c.

The rest is used only in gedit-app-osx.m.

The metadata implementation has been moved to Tepl.

In the docs the signal names have dashes.

The comment said "carriage return", but the default implementation from
GtkTextView doesn't remove the newline either. I thought "carriage
return" meant that the \n was correctly removed by GtkTextView but not
\r. With the "newline" term it's hopefully less confusing.

That small feature was added in 2009:
commit fb4ced95

When doing a right click in the left margin/gutter, a context menu
appeared with only one item: to toggle the line numbers visibility.

I don't think it is great to add such options a bit everywhere in the
GUI. The gedit statusbar already contains, nowadays, buttons to toggle
certain settings, including the line numbers visibility. The option is
also of course available in the preferences dialog, where it is the
natural place to change such settings.

Also, when the left gutter contained *only* the line numbers, then doing
a right click to hide the line numbers, the user might not know directly
where to revert the change and display the line numbers again, since the
left gutter is gone.

So, I prefer to remove that small feature. I don't think it was a
well-known feature in any case, since it's a bit hidden behind a right
click at a specific place.

Just move code around.

More logical function order.

There is a g_settings_bind() for the "tab-width" in GeditView.

It's not necessary to store the PangoFontDescription in an instance
variable.

It's not used by any plugin part of gedit or gedit-plugins.

Group related things together.