1. 18 May, 2019 1 commit
  2. 15 May, 2019 1 commit
  3. 12 May, 2019 1 commit
  4. 11 May, 2019 1 commit
  5. 08 May, 2019 1 commit
  6. 07 May, 2019 2 commits
  7. 03 May, 2019 3 commits
  8. 02 May, 2019 1 commit
    • Felipe Borges's avatar
      Include "gedit" in .desktop keywords · c8efb68c
      Felipe Borges authored
      The GNOME Shell search results are forwarded from the results of
      GLib's g_desktop_app_info_search() function, which matches the
      Name, Exec, Keywords, GenericName, X_GNOME_FullName, and Comment
      keys from desktop files[0].
      
      Since gedit is now named "Text Editor", a query for "gedit" would
      match the "Exec" key and present the application in the search
      results as expected. Unfortunately that doesn't happen for Flaptaked
      gedit, which would get its desktop file "Exec" key overwritten to
      something such as Exec=/usr/bin/flatpak run --branch=stable
      --arch=x86_64 --command=gedit org.gnome.gedit --new-document
      
      This way, searching for "gedit" when only the Flatpaked version
      of it is installed returns no results. Searching for "Text Editor"
      presents the application as expected.
      
      Its been proposed in GLib to parse the "Exec" key for searches
      but that was rejected[1] because it would imply establishing an
      API which assumes that the command line behavior of Flatpak would
      be stable/never-change.
      
      A fix was proposed in Flatpak directly[2] but it was rejected,
      leaving us with the only option of adding the historical/legacy
      application names to the "Keywords" key in their desktop files.
      
      Many users, such as myself, have the "muscle memory" of search
      for the old application's name, such as "gedit", "totem", "evince".
      Although I agree that the new names should be presented to new
      users and that the old ones shouldn't be visible in UI, it makes
      sense and little effort to support the search for the old names IMO.
      
      [0] https://gitlab.gnome.org/GNOME/glib/blob/master/gio/gdesktopappinfo.c#L378
      [1] glib#1706
      [2] https://github.com/flatpak/flatpak/issues/2749
      c8efb68c
  9. 01 May, 2019 2 commits
  10. 30 Apr, 2019 1 commit
  11. 29 Apr, 2019 2 commits
    • Will Thompson's avatar
      filebrowser: fix build order for enum-types.h · 79ff20c4
      Will Thompson authored
      On Endless's package build server, building gedit on x86_64 failed as
      follows:
      
          [  194s] [97/147] /usr/bin/meson --internal exe /usr/src/packages/BUILD/obj-x86_64-linux-gnu/meson-private/meson_exe_gedit-tool-merge.pl_cd41154a78cf16ac2c5a9a58261cb6418b36427a.dat
          [  195s] [98/147] /usr/bin/msgfmt --desktop --keyword=Name --keyword=Description --template=../plugins/externaltools/externaltools.plugin.desktop.in -d /usr/src/packages/BUILD/po --output=plugins/externaltools/externaltools.plugin
          [  195s] [99/147] /usr/bin/meson --internal exe /usr/src/packages/BUILD/obj-x86_64-linux-gnu/meson-private/meson_exe_glib-mkenums_ea0cb1ece8d7fa2e9a3e7c5a57f45df212823d0f.dat
          [  195s] [100/147] cc -Iplugins/filebrowser/5f8d977@@filebrowser@sha -Iplugins/filebrowser -I../plugins/filebrowser -I. -I../ -Isubprojects/libgd -I../subprojects/libgd -Iplugins/filebrowser/resources -Igedit -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0 -I/usr/include/libdrm -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gtksourceview-4 -I/usr/include/libxml2 -I/usr/include/libpeas-1.0 -I/usr/include/gobject-introspection-1.0 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DLIBGD_TAGGED_ENTRY=1 -DHAVE_CONFIG_H  -MD -MQ 'plugins/filebrowser/5f8d977@@filebrowser@sha/gedit-file-browser-plugin.c.o' -MF 'plugins/filebrowser/5f8d977@@filebrowser@sha/gedit-file-browser-plugin.c.o.d' -o 'plugins/filebrowser/5f8d977@@filebrowser@sha/gedit-file-browser-plugin.c.o' -c ../plugins/filebrowser/gedit-file-browser-plugin.c
          [  195s] FAILED: plugins/filebrowser/5f8d977@@filebrowser@sha/gedit-file-browser-plugin.c.o
          [  195s] cc -Iplugins/filebrowser/5f8d977@@filebrowser@sha -Iplugins/filebrowser -I../plugins/filebrowser -I. -I../ -Isubprojects/libgd -I../subprojects/libgd -Iplugins/filebrowser/resources -Igedit -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0 -I/usr/include/libdrm -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gtksourceview-4 -I/usr/include/libxml2 -I/usr/include/libpeas-1.0 -I/usr/include/gobject-introspection-1.0 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DLIBGD_TAGGED_ENTRY=1 -DHAVE_CONFIG_H  -MD -MQ 'plugins/filebrowser/5f8d977@@filebrowser@sha/gedit-file-browser-plugin.c.o' -MF 'plugins/filebrowser/5f8d977@@filebrowser@sha/gedit-file-browser-plugin.c.o.d' -o 'plugins/filebrowser/5f8d977@@filebrowser@sha/gedit-file-browser-plugin.c.o' -c ../plugins/filebrowser/gedit-file-browser-plugin.c
          [  195s] ../plugins/filebrowser/gedit-file-browser-plugin.c:35:10: fatal error: gedit-file-browser-enum-types.h: No such file or directory
          [  195s]  #include "gedit-file-browser-enum-types.h"
          [  195s]           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          [  195s] compilation terminated.
      
      I couldn't reproduce this locally, perhaps because I have the wrong number
      of cores. However, exploring the build graph with:
      
          ninja -t browse plugins/filebrowser/5f8d977@@filebrowser@sha/libfilebrowser.so.symbols
      
      showed that there was no dependency between
      gedit-file-browser-plugin.c.o and gedit-file-browser-enum-types.h.
      Adding the generated gedit-file-browser-enum-types.h to the sources for
      this shared_library() causes an (order-only) dependency to be added,
      ensuring that gedit-file-browser-enum-types.h is generated before
      gedit-file-browser-plugin.c is compiled.
      79ff20c4
    • Jordi Mas's avatar
      71820be1
  12. 26 Apr, 2019 1 commit
  13. 25 Apr, 2019 2 commits
  14. 24 Apr, 2019 2 commits
  15. 23 Apr, 2019 1 commit
  16. 22 Apr, 2019 1 commit
  17. 17 Apr, 2019 3 commits
    • Jordi Mas's avatar
    • Andrea Azzarone's avatar
      metadata-manager: Remove singleton · 541966f3
      Andrea Azzarone authored
      GeditDocument may attempt to use GeditMetadataManager after GeditApplication has
      already called gedit_data_manager_shutdown. This happens because right now
      _gedit_tab_load is not cancelled when the tab is closed, but it's only cancelled
      if the user dismisses the loading operation from the infobar.
      
      Also cancelling _gedit_tab_load is not enough because GtkSourceFileLoader
      increases the reference count of the source buffer (in the case the
      GeditDocument) until the async operation is completed or cancelled, hence
      GeditDocument will attempt to use GeditMetadataManager in gedit_document_dispose
      after GeditApplication has already called gedit_data_manager_shutdown.
      
      To properly solve this - and avoid similar issues - make GeditMetadataManager
      reference countable and keep an hard reference in each GeditDocument and in the
      GeditApp.
      
      Closes: #145
      541966f3
    • etaoin's avatar
      Add some missing shortcuts to the shortcuts dialog · ba2da3e2
      etaoin authored
      - Unselect all text
      - Move viewport up within the file
      - Move viewport down within the file
      - Move viewport to end of file
      - Move viewport to beginning of file
      - Move to matching bracket
      ba2da3e2
  18. 16 Apr, 2019 1 commit
    • Andrea Azzarone's avatar
      tab: Remove tab before unreffing the loading_task data · c089321c
      Andrea Azzarone authored
      When there is a problem opening a file, if the user decides to dismiss the tab
      clicking the 'x' button in the info bar, remove the tab before unreffing the
      loading_task data. Failing to do so will likely result in an access to invalid
      memory.
      c089321c
  19. 15 Apr, 2019 1 commit
    • Andrea Azzarone's avatar
      open-document-selector: Properly remove idle · e88b8456
      Andrea Azzarone authored
      It's not possible to use g_idle_remove_by_data when the idle was added with
      gdk_threads_add_idle_full. gdk_threads_add_idle_full uses g_idle_add_full
      internally but it creates a temporary data strucuture. The address of this
      temporary data structure should be passed to g_idle_remove_by_data. For obvious
      reasons we cannot do that, so let's use g_source_remove.
      
      Failing to remove the idle when the open document selector is disposed could
      result in a crash because the idle function (real_populate_liststore) would
      access invalid memory.
      
      Also remove populate_scheduled because it's not needed for two reasons:
      1. populate_liststore and real_populate_liststore always run in the same thread
      2. if populate_liststore is called before real_populate_liststore is run, there
         is no need to schedule two calls two real_populate_liststore.
      
      Close: https://bugs.launchpad.net/bugs/1646762
      e88b8456
  20. 14 Apr, 2019 3 commits
  21. 13 Apr, 2019 3 commits
  22. 12 Apr, 2019 2 commits
  23. 11 Apr, 2019 1 commit
  24. 09 Apr, 2019 1 commit
  25. 08 Apr, 2019 2 commits