1. 01 Nov, 2018 1 commit
  2. 13 Jan, 2016 1 commit
    • Sébastien Wilmet's avatar
      notebook: prevent a crash when detaching a tab · cce8be14
      Sébastien Wilmet authored
      To reproduce the crash:
      1. Have at least two tab groups, with only one tab in a tab group.
      2. Right click on the tab label (for the single tab) -> move to new
         window.
      -> the multi-notebook destroys the notebook, with a crash in
         gtk_notebook_detach_tab() on the line after the call to
         gtk_container_remove(), since it tries to access
         notebook->priv->remove_in_detach on the destroyed notebook.
      cce8be14
  3. 17 Aug, 2015 1 commit
  4. 26 Jun, 2015 1 commit
  5. 25 Jun, 2015 2 commits
    • Sébastien Wilmet's avatar
      Move tab DND support to GeditNotebook · 7aee29ec
      Sébastien Wilmet authored
      To remove the dependency on GeditNotebook in GeditView. A class should
      not be aware of who contains it. The purpose is to make GeditView more
      self-contained, so it can be reused more easily in other text editors.
      
      Instead of handling the DND in the object method handler of GeditView,
      we connect to the signal externally, which works fine too. And since the
      code is related to notebooks, it's more logical to have that code in
      GeditNotebook.
      7aee29ec
    • Sébastien Wilmet's avatar
      notebook: improve comments about DND · 66bfd41c
      Sébastien Wilmet authored
      66bfd41c
  6. 10 Jun, 2015 4 commits
    • Sébastien Wilmet's avatar
      notebook: use gtk_notebook_get_tab_label() · 570cee7e
      Sébastien Wilmet authored
      It is not needed to set the tab-label GObject data, because we can use
      gtk_notebook_get_tab_label().
      
      But we need to disconnect the signal in gedit_notebook_remove(), before
      the page removal (that is, before the chain-up), so we can still
      retrieve the tab_label. In gedit_notebook_page_removed(), the page is
      already removed, so it's not possible to retrieve the tab_label there.
      570cee7e
    • Sébastien Wilmet's avatar
      notebook: fix page switching bug when closing an unfocused tab · 334acf29
      Sébastien Wilmet authored
      In gedit_notebook_page_removed(), the page was already removed, so
      calling gtk_notebook_get_current_page() there was wrong. It was maybe
      due to a GTK+ change.
      
      The list of focused pages contained only the previously focused pages,
      not the current one. This commit changes that to also include the
      currently focused page in the list, so in gedit_notebook_page_removed()
      we know if the page removed was the current page or not.
      
      Change also the order of the history, with the most recent focused page
      at the first element of the list instead of at the end, so we don't need
      to traverse the whole list each time.
      
      Make also the code more robust.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=731784
      334acf29
    • Sébastien Wilmet's avatar
      notebook: cosmetic changes · 8fe0690f
      Sébastien Wilmet authored
      - "notebook" is clearer than "nb".
      - various other minor improvements
      8fe0690f
    • Sébastien Wilmet's avatar
      notebook: remove dead code · fa76866b
      Sébastien Wilmet authored
      fa76866b
  7. 15 Feb, 2015 1 commit
  8. 15 Oct, 2014 1 commit
  9. 08 Feb, 2014 1 commit
  10. 03 Feb, 2014 1 commit
  11. 23 Jan, 2014 1 commit
  12. 11 Jan, 2014 1 commit
  13. 06 Jan, 2014 1 commit
  14. 17 Oct, 2013 1 commit
  15. 28 Jul, 2013 1 commit
  16. 26 Jun, 2013 1 commit
  17. 24 Jun, 2013 1 commit
  18. 11 Mar, 2013 1 commit
  19. 05 Mar, 2012 1 commit
  20. 22 Jan, 2012 1 commit
  21. 23 Dec, 2011 3 commits
  22. 17 Dec, 2011 1 commit
  23. 14 Dec, 2011 1 commit
  24. 08 Dec, 2011 4 commits
  25. 24 Oct, 2011 2 commits
  26. 15 Aug, 2011 1 commit
  27. 26 Jun, 2011 1 commit
    • Paolo Borelli's avatar
      Fix slowdown when closing all tabs · de24b2c5
      Paolo Borelli authored
      We were O^2 stupid: for each tab we were getting its position, which in
      turns requires walking the list of children and then we were removing
      the tab, which in turns requires gtk to re-walk the list of tabs to find
      the one we want to remove. Besides removing tabs starting from the first
      is bad for gtknotebook since even/odd css of each tab is recalculated
      over and over: we can remove tabs in reverse order.
      de24b2c5
  28. 21 Apr, 2011 1 commit
  29. 12 Apr, 2011 1 commit
  30. 24 Mar, 2011 1 commit