Notes/questions, copied from the issue:
- I've changed the
Memory.Bufferinstances but have left
Filetypes for now. This was to get your feedback as also changing
attached_fileswould mean changes through into
Geary.Attachment(as a result of
ComposerWidget's use through
pending_attachments), which I presume will impact a bunch of other things. One of the downsides to not making this change are not being able to handle non-image dropped files as normal attachments.
- The way I've used
get_uint8_arrayto build the GMime part (in
RFC822.Message) feels like there should be a better way..?
- I'm using a hash of current time to build a filename for pasted images. Happy to hear other ideas.
- Currently I'm attempting to accept any dropped image with an image mime type (
image/*). Are you happy to go with that for now or should we attempt to restrict to a few standard types?
blob://URL scheme is required for dropping files into WebKit
- I've made some changes to
ComposedEmail.replace_inline_img_srcas the replaced term and search term can have the same length (which would have resulted in the previous test assuming and the replacement not succeeding). I do realise the updated approach is less performant (when the replacement succeeds).
- One minor usability issue I noticed is that when initially composing a new email the drop area for an inline image is pretty small as the WebKit view is only one line high
Also, I've just attempted to update from master but have some type of build environment issue (from Debian, GNOME, something changes?) that I don't have the time to resolve this second. Will need to get onto that.