1. 28 Feb, 2019 1 commit
    • Kristian Klausen's avatar
      Remove trailing whitespace · 48c93655
      Kristian Klausen authored
      find . -name '*.vala' -type f -exec sed -i 's/ *$//g' {} +
      The following files was ignored:
      test/client/composer/composer-web-view-test.vala
      test/engine/util-html-test.vala
      
      Fix #271
      48c93655
  2. 10 May, 2018 2 commits
    • Michael Gratton's avatar
      Revert "Remove a number of redundant fns in Engine.Util.Ascii." · 40d9b779
      Michael Gratton authored
      This reverts commit 1d8c4aea.
      
      Fixes Bug 795906.
      40d9b779
    • Michael Gratton's avatar
      Support default content types for both displayed and attached entities. · a2a95686
      Michael Gratton authored
      This replaces the const ContentType.DEFAULT_CONTENT_TYPE string and
      related code with static defaults for both displayed and attached MIME
      entities.
      
      * src/engine/mime/mime-content-type.vala (ContentType): Replace
        DEFAULT_CONTENT_TYPE const with static DISPLAY_DEFAULT and
        ATTACHMENT_DEFAULT static instances. Remove is_default() since that no
        longer makes sense. Update call sites and unit tests.
      
      * src/engine/mime/mime-content-parameters.vala (ContentParameters): Make
        the class immutable so it is safe to be used as a component of the
        static ContentType DISPLAY_DEFAULT and ATTACHMENT_DEFAULT members.
      a2a95686
  3. 03 May, 2018 1 commit
  4. 15 Feb, 2017 2 commits
  5. 19 Jun, 2016 1 commit
  6. 06 May, 2016 1 commit
  7. 12 Mar, 2015 1 commit
  8. 13 Feb, 2015 2 commits
    • Jim Nelson's avatar
      Fix displaying images referenced by Content-ID: Bug #743676 · 89ca0167
      Jim Nelson authored
      The logic in our image replacement code needed to take account if the
      MIME part was inside a multipart/mixed container or otherwise.  This
      patch does that as well as clean up the code path and better document
      the API as well as what's going on inside ConversationViewer when the
      message is assembled.
      89ca0167
    • Jim Nelson's avatar
      Don't include internal/private symbols in Engine VAPI · 13665f77
      Jim Nelson authored
      Removing internal and private symbols from geary-static.vapi results
      in removing 1,000 lines from the file.  Although testing doesn't show
      an appreciable increase in compile time (w/ make -j8 on my 8-core
      machine), by reducing symbol leakage partial builds should improve.
      
      This patch also fixes a couple of symbols marked internal but being
      used publicly (and necessarily so) and a couple of errordomains in
      the Engine not placed in the Geary namespace.
      13665f77
  9. 06 Feb, 2015 1 commit
  10. 31 Oct, 2014 1 commit
    • Jim Nelson's avatar
      Correct problems with IMAP parsing when using Turkish: Bug #714892 · bc0a892a
      Jim Nelson authored
      When connecting to any IMAP server while the local user's locale is
      configured to be Turkish, Geary will mis-parse many of the IMAP
      server's responses, leading to essentially a failed connection due to
      state issues and more.
      
      The problem is that some of the parsing code was using g_utf8_strdown
      to convert received text to lowercase to perform case-insensitive
      string comparisons.  Turkish has multiple letter I's (dotted and
      dotless), and when the UTF-8 code transformed it to lowercase, a
      different UTF-8 code point was selected than the English/ASCII 'i'.
      
      The solution is to explicitly use ASCII variants of string
      transformation, comparison, and hashing to ensure 7-bit operations are
      used throughout the IMAP and RFC822 stack.  Further commits will
      follow that enforce this a bit more, but this commit is sufficient to
      correct the problem for our Turkish users.
      bc0a892a
  11. 12 Aug, 2014 1 commit
    • Jim Nelson's avatar
      Show attachments lacking a Content-Disposition: Bug #713830 · a9db6e8c
      Jim Nelson authored
      Attachments without Content-Disposition are now generated and shown
      in the client.  This requires a database upgrade as well as rescanning
      all messages to generate the previously missing attachments.
      
      In addition, this upgrade now stores the attachments' Content-ID in
      the database.  This makes it much easier for the client to associate
      a particular MIME section in the RFC822 message with an attachment in
      the database and on disk.
      a9db6e8c
  12. 05 Feb, 2014 1 commit
  13. 16 Nov, 2013 1 commit
    • Jim Nelson's avatar
      Convert all MIME handling to Engine classes: Closes #6530 · e29a9c80
      Jim Nelson authored
      We've had numerous bugs due to improper MIME comparisons and dealing
      with Content-Type and Content-Disposition (or their lack of presence
      in a message).  Now the Engine offers MIME classes that better deal
      with these issues without exporting the GMime structures, which
      are not as easy to manage and don't offer some of the things that
      have bitten us in the past (such as case-insensitive comparisons).
      e29a9c80