Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Geary Geary
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 463
    • Issues 463
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GearyGeary
  • Merge requests
  • !110

Prevent circular refs using idle and timeout manager when running

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michael Gratton requested to merge wip/weak-refs-for-callback-managers into master Feb 18, 2019
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 4

If an IdleManager or TimeoutManager had been scheduled, it would not get destroyed until it was executed by the main loop, causing criticals if the objects enclosed by its callback had been destroyed.

This adds a weak reference to the manager object itself when scheduling on the main loop, so it can get safely dropped.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/weak-refs-for-callback-managers