GitLab

This introduces a background account synchronizer into Geary that
prefetches email folder-by-folder to a user-configurable epoch.  The
current default is 15 days.

Additional work to make this user-visible is coming, in particular with

The primary purpose for this feature is to allow "full" conversations
(#4293), which needs more of the mailbox stored locally to do searching.

This just makes the new API and adds the string change.  We're waiting
to hook it up until #6365 lands.

Previously, we were taking folder names as they came off the wire.
Turns out IMAP specifies that folder names with 8 bit code points are
encoded in a crazy scheme unique to IMAP.  Now, we properly decode that
scheme to the correct UTF-8 folder names to be displayed to the user.

There's also now a database upgrade path that converts all existing
mailboxes to the decoded version, so your existing database should just
keep working.

This doesn't solve #6205, as other unknown responses can cause this
problem as well, but it does fix this for the most-commonly reported
cause of this issue, MYRIGHTS.

We were presenting the main window with an erroneous timestamp, which
was causing composer windows to be created with an incorrect z order.
This presents the window without a timestamp, so there's no room for
error.

In some window managers, windows that display dialogs aren't
automatically presented.  This manually presents the window before it
pops up the dialog, to keep behavior consistent.

* "Reply To" now labelled "Reply"
* Toolbar overflow menu labels no longer say "translated"
* .desktop file contains keywords
* For generic servers, "Remember password" now says "Remember passwords"

An earlier commit fixed half of this ticket (the more pressing of
the two issues).  This takes care of mailto: links with embedded
CR, LF, and CRLF.

Compress conversation code tried to reference first item of an empty
SortedSet.

Ticket #6227 looks like a single problem, but in fact Tiago identified
it as two.  Before this patch, the ComposerWindow assumed all prefilled
messages were either replies or forwards and prepended whitespace to
separate the user's message from the replied-to/forwarded one.  This
is not the case with mailto: body's, which should be entered as-is to
a newly composed message.

There still exists #6227's issue with newlines not being inserted from
a mailto: link.  That's enough of a side case we're committing this
now, as it's more common.

There's now a list of inboxes at the top of the sidebar if you have more
than one account.  It gets the default selection if possible, so you
never have to see all the folders of your accounts if you work entirely
out of your inbox.

SMTP authentication is now entirely optional, distinct from not
requiring a password (#5668).

This slight optimization also makes the code cleaner to read.

Some of the less-frequently used special folders have moved into a new
"More" grouping above "Labels".  This keeps down the clutter for people
with lots of accounts.

Squashed commit of the following:

commit 647795e03e8b4d88df0f629b15416ff574fcda4a
Merge: 72515c2 4d2d3049
Author: Charles Lindsay <chaz@yorba.org>
Date:   Tue Feb 12 18:13:10 2013 -0800

    Merge branch 'master' into special-subfolders

commit 72515c29ad8e1b1cc0bd653292fc9cf7a8665b27
Author: Charles Lindsay <chaz@yorba.org>
Date:   Tue Feb 12 18:11:17 2013 -0800

    Clean up

commit 8549a5d69b65969fc5d4d515f55f44cb98597b71
Author: Charles Lindsay <chaz@yorba.org>
Date:   Tue Feb 12 12:02:49 2013 -0800

    Add "More" grouping to sidebar

Now when a monitored folder (i.e. inbox) gets new messages, we also make
that folder bold in the folder list so you know there are new messages
there.

More great work from Robert Schroll.

With the latest multiple account changes, notifications weren't working
quite right.  Now they are.

Squashed commit of the following:

commit d1f485ef349128ac33915e12622efb3d9d849659
Author: Eric Gregory <eric@yorba.org>
Date:   Fri Feb 8 14:54:03 2013 -0800

    Replaced AccountInformation.pretty_print() with AccountInformation.get_mailbox_address()

Activated by --inspector, this pop ups a WebKit HTML/CSS inspector
that's quite useful for development and debugging.

We now use a small timer when you click a folder before we actually kick
off a network connection.  This effectively rate-limits how many
connections we make without significantly degrading the user experience.

Also we know that the folder selection function is not safely reentrant,
so that logic happens inside a mutex lock now.

The rate-limiting folder selection part is not an ideal solution, but
it's close to what we want (ideally, local results would be shown
immediately).  However, the mutex lock is just a bandaid over the larger
problem of how much global state we juggle in the controller.

Squashed commit of the following:

commit 44e46663bb9b513970e11a62428834668987bf33
Author: Charles Lindsay <chaz@yorba.org>
Date:   Wed Feb 6 17:29:22 2013 -0800

    Comment our mutex lock

commit d951204aa163c73ed60b51368fa900ad6414046c
Author: Charles Lindsay <chaz@yorba.org>
Date:   Wed Feb 6 16:59:32 2013 -0800

    Select folders only after a small timeout

commit 012097139bfbaa76967667b8fcdd324634cc2506
Author: Charles Lindsay <chaz@yorba.org>
Date:   Wed Feb 6 11:11:30 2013 -0800

    Fix reentrancy issues using mutex

This code had previously existed to mark messages as read, but that
functionality has been moved into ConversationViewer.

Support for Precise bit us again.  When we drop support for Precise,
we can close #6323.

Squashed commit of the following:

commit 0a5a17bc40a4f8eeda7fc5915931024ec10291cd
Merge: 7f1591c 0350a8fe
Author: Charles Lindsay <chaz@yorba.org>
Date:   Tue Feb 5 10:28:12 2013 -0800

    Merge branch 'master' into fix-empty-window

commit 7f1591cc2c007adeb65e9d92966b71ef4815ada2
Author: Charles Lindsay <chaz@yorba.org>
Date:   Mon Feb 4 18:48:08 2013 -0800

    Add account string to folder string

commit 495238d07556755683d77337e11440731503506a
Author: Charles Lindsay <chaz@yorba.org>
Date:   Mon Feb 4 18:47:50 2013 -0800

    Quit when last account closed; ref #6296

commit c13ba1e560648ac5fc8892213e7c96601541e05d
Author: Charles Lindsay <chaz@yorba.org>
Date:   Mon Feb 4 18:47:19 2013 -0800

    Add per-inbox cancellables

commit 7dd0b4274593584e55063ae55b8f60c286daf7f1
Author: Charles Lindsay <chaz@yorba.org>
Date:   Mon Feb 4 18:45:59 2013 -0800

    Get rid of persistent inbox conversation monitors

Squashed commit of the following:

commit 1b045edd6c28e3f837107577726b61c839816bc2
Author: Eric Gregory <eric@yorba.org>
Date:   Mon Feb 4 19:25:36 2013 -0800

    Changes from code review

commit bcd52b9f571de316eda39bd181df121bc4753c40
Author: Eric Gregory <eric@yorba.org>
Date:   Mon Feb 4 18:21:53 2013 -0800

    Removed cancellable check

commit 1cc528ca39555233cd5e851229a242fc118c11ae
Author: Eric Gregory <eric@yorba.org>
Date:   Mon Feb 4 18:17:42 2013 -0800

    Delete account (2nd branch)

This adds an account property to the composer window.  We had been using
the current account, which was problematic if you opened the window,
switched to a folder on a different account, then hit send.