GitLab

Squashed commit of the following:

commit 2e7b026f5865d84f369288a70d86c44e07e8c3b1
Merge: 08c6691 c476669f
Author: Jim Nelson <jim@yorba.org>
Date:   Wed Jan 16 15:24:35 2013 -0800

    Merge branch 'master' into bug/6099-view-images

commit 08c6691c5c466448710a5b055676778348650b86
Author: Jim Nelson <jim@yorba.org>
Date:   Wed Jan 16 15:06:00 2013 -0800

    Updates in response to Eric's code review

commit 9694e0a4d678b3b0674e9970b8f3b840937955f3
Author: Jim Nelson <jim@yorba.org>
Date:   Wed Jan 16 14:17:12 2013 -0800

    Merge of Andrea Corbellini's patch for #6099

    The merge had to be done by hand because of a recent refactoring of
    the ConversationViewer and ConversationWebView.

Squashed commit of the following:

commit eea88280df6df7c2dbe8683e2593d283eaa04fa9
Author: Eric Gregory <eric@yorba.org>
Date:   Tue Jan 15 17:05:52 2013 -0800

    Ref #6226 Fixes left-clicks in composer window

Squashed commit of the following:

commit e4247cc1f1d6737c9a22a2e7a79de46b5da46970
Merge: a3ae5f0 3467c720
Author: Charles Lindsay <chaz@yorba.org>
Date:   Tue Jan 15 13:26:20 2013 -0800

    Merge branch 'master' into fix-startup

commit a3ae5f01c32f53983235f881fedb99154f5fa0b5
Author: Charles Lindsay <chaz@yorba.org>
Date:   Tue Jan 15 13:25:51 2013 -0800

    Mark vars as nullable for semantics

commit ad06fc6ba24d07abb4b2d8728f4a1d34ba0efbd8
Author: Charles Lindsay <chaz@yorba.org>
Date:   Mon Jan 14 18:01:29 2013 -0800

    Fix errors when cancelling acct. dialog; ref #6220

commit 0df1f33ea013ca370c4aa0416563700b92100f55
Author: Charles Lindsay <chaz@yorba.org>
Date:   Mon Jan 14 17:28:06 2013 -0800

    Create geary user directory on startup; ref #6220

Closes #6209 Precise support for GIR WebKitGTK binding. Rolls back to deprecated context menu in composer for compatibility with WebKitGTK 1.8
Squashed commit of the following:

commit 6e066374da45dd602ee1ca3c9bc5f77b9411b6f4
Author: Eric Gregory <eric@yorba.org>
Date:   Tue Jan 15 11:36:32 2013 -0800

    Closes #6209 Precise support for GIR WebKitGTK binding. Rolls back to deprecated context menu in composer for compatibility with WebKitGTK 1.8

Squashed commit of the following:

commit 7e1f96baf981d15a5fe5bae0571a1c57f26f4bba
Author: Charles Lindsay <chaz@yorba.org>
Date:   Fri Jan 11 14:25:25 2013 -0800

    Unset before remove account; ref #6197

    This is the last code change requested.

commit 6e70c64e1b8ee51da5ab34ae7f17e77fc5fa929b
Author: Charles Lindsay <chaz@yorba.org>
Date:   Fri Jan 11 11:22:37 2013 -0800

    Clean up engine refactoring; ref #6197

commit ac76bb86cfbc54c1f21bb48de6cabd1f53171320
Author: Charles Lindsay <chaz@yorba.org>
Date:   Thu Jan 10 16:16:54 2013 -0800

    Clean up Engine refactoring work; ref #6197

commit 3bc3587d4343e0fe456528275a2504fd1fb22ad6
Author: Charles Lindsay <chaz@yorba.org>
Date:   Thu Jan 10 12:46:33 2013 -0800

    Refactor Geary.Engine; ref #6197

    This is workable, but probably needs some cleanup.

This handles the case where autocomplete provides an address but the
Send button doesn't go active.  Still keeping the ticket open to handle
the case where the user manually enters such a string (or, more likely,
pastes it in from an external source).

Also checks for attachments, a nice bonus.

This catches reversed names when generating short participant names
(where Geary generally only shows the first name).

Previously, when having some trouble with synchronization and unsolicited
notifications of appended messages, ImapEngine.GenericFolder would use
a broad FETCH range to ensure it received all messages.  The problem
with this is that if several unsolicited appends come in back-to-back,
the same message(s) may be fetched before the dust settles.

This patch uses a more precise request for messages by a specific range.

This sets up more sophisticated TLS certificate error handling but
doesn't introduce the key component, allowing the user to accept
or deny a certificate (see #5209).  Geary used to fail on UNKNOWN_CA
certificate errors, causing a lot of grief for a lot of people.
Now *all* TLS certificate errors are logged as messages, but none
cause an error.

This is not an ideal situation, but better than simply denying the
use of the app for self-signed servers.

A signal was being fired inside an FSM transition handler, a no-no.

Uses GSettings bindings rather than getters/setters to save
window and pane sizes as they are updated.

A problem reported in #5998 appears to be that GSettings isn't
setting configuration values at exit, although it's doing it
here for us.  This adds some debug for the user to test out.

The SMTP authentication method was being selected after initial
establishment of the session.  For the user's server, it was
reporting no AUTH methods available, and so PLAIN was selected.
However, after STARTTLS, the user's server reported only LOGIN,
causing the problem.

Smtp.ClientConnection now offers an establish_connection_async()
method which goes through all the steps to ensure quality-of-service
and security is set up.

The ticket lists two problems, crashing and an inability to open
messages (due to Geary continuously reconnecting to the server,
which is due to a FETCH command timing out).  IDLE cannot be used
with Dovecot servers as it creates the same situation ticket #5224
seeks to avoid.  Essentially, if pipelining is turned off, so should
IDLE, as ClientConnection pipelines the IDLE command.

Lion returns an authentication proceed line with no explanation,
which the SMTP deserializer to treated as a bad response.

Conflicts:

	CMakeLists.txt

Since intltool is a collection of programs and not a library, can't
use FindPackage to verify.  Instead, if not found, the .desktop file
CMakeLists will spit out an error and exit.

One NUL can ruin your whole day.