1. 15 Feb, 2006 1 commit
  2. 07 Feb, 2006 1 commit
    • Brian Cameron's avatar
      This patch resolves some performance issues that I noticed when testing · 55230e85
      Brian Cameron authored
      2006-02-07  Brian Cameron  <brian.cameron@sun.com>
      
              This patch resolves some performance issues that I noticed when
              testing GDM with the gdmdynamic command.  I notice that waiting for
              the sockets to timeout made gdmdynamic slower so now all the clients
              load all the configuration data in one quick pass and close the
              socket.  Since the gdm_config_get functions cache the data, the slaves
              will not go over the socket to get the data again unless asked to
              reread.  Bump the maximum messages over the socket from 20 to 80
              because gdmlogin pulls about 65 configuration parms over and this
              allows all data to be accessed in one connection (and gives a little
              room for growth).  Improved the way GDM slaves deal with syslog so all
              slaves use the same interfaces.  Added three missing keys to the daemon
              configuration handling code.
      
              * daemon/gdmconfig.c: Add three keys that were missing for background
                program support.
              * gui/gdmcomm.[ch]: Now if there is a failure connecting to the daemon,
                the slave will sleep 1 second before retry (normally retries 5
                times).  If all retries fail, it will not try sleeping on subsequent
                calls to the daemon.  This greatly improves performance when the
                daemon is flooded with slave requests.  In normal usage, this will
                likely not happen, but it is good for GDM to not fail so easily.
                Added better debug.  Added gdm_comm_close function so that slaves
                can ask to close the socket when done reading config.  Now uses
                common syslog functions.
              * daemon/gdm.h: Add better comments, rename GDM_SUP_MAX_CONNECTIONS
                to GDM_SUP_MAX_MESSAGES which is more accurate, and bump the max
                number to 80.
              * gui/gdmcommon.h, gui/gdmwm.h, gui/gdmsession.h: Added common syslog
                functions to gdmcommon.h and moved some functions that were in
                gdmcommon.h to gdmwm.h and gdmsession.h since the implementations
                were in those c-files.  Renamed functions to make naming consistant.
              * gui/gdmXnestchooser, gui/gdmchooser.c, gui/gdmcommon.c,
                gui/gdmconfig.c, gui/gdmdynamic.c, gui/gdmflexiserver.c,
                gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsession.c, gui/gdmwm.c,
                gui/greeter/greeter.c, gui/greeter/greeter_item_ulist.c,
                gui/greeter/greeter_session.c, gui/greeter/greeter_system.c:  Slaves
                close sockets connection when done reading config.  Now slaves use
                common syslog functions.  Naming changes to reflect renaming of
                functions in gdmcommon.h/gdmwm.h/gdmsession.h.  Better debug.
              * daemon/auth.c, daemon/cookie.c, daemon/display.c, daemon/gdm.c,
                daemon/gdm-net.c, daemon/misc.c, daemon/slave.c, daemon/xdmcp.c,
                gui/gdmlanguages.c, gui/greeter/greeter_canvas_item.c,
                gui/gdmsetup.c, vicious-extensions/ve-config.c: Make spacing around
                "++" more consistant.  Add better debug in some functions
      55230e85
  3. 18 Jan, 2006 2 commits
    • Brian Cameron's avatar
      Add needed glib/gstdio.h include to daemon/fstype.c which fixes a wierd · c462444b
      Brian Cameron authored
      2006-01-18  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/auth.c, daemon/choose.c, daemon/cookie.c, daemon/display.c,
                daemon/errorgui.c, daemon/filecheck.c, daemon/fstype.c, daemon/gdm.c,
                daemon/gdmconfig.c, daemon/server.c, daemon/slave.c,
                daemon/verify-crypt.c, daemon/verify-pam.c, daemon/verify-shadow.c,
                daemon/xdmcp.c, gui/gdmchooser.c, gui/gdmlogin.c, gui/gdmsession.c,
                gui/gdmsetup.c, gui/misc.c, gui/modules/dwellmouselistener.c,
                gui/modules/keymouselistener.c, utils/gdm-dmx-reconnect-proxy.c,
                vicious-extensions/glade-helper.c,
                vicious-extensions/test-ve-config.c, vicious-extensions/ve-config.c,
                vicious-extensions/ve-gnome.c, vicious-extensions/ve-misc.c,
                vicious-extensions/ve-miscui.c, vicious-extensions/ve-nongnome.c,
                vicious-extensions/ve-signal.c:  Add needed glib/gstdio.h include
                to daemon/fstype.c which fixes a wierd core dumping problem on
                Ubuntu.  Fixes bug #326819.  Patch provided by Sebastien Bacher
                <seb128@debian.org>.  Also fixed all the source so that the includes
                are more consistant with config.h in quotes instead of in "<>" and
                glib/gtk includes are always listed after system includes.
      c462444b
    • Brian Cameron's avatar
      Use "reboot" instead of "restart". Fixes bug #327583. · 792a9fc5
      Brian Cameron authored
      2006-01-18  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/gdm.c, daemon/slave.c, gui/greeter/greeter.c, gui/greeter/greeter_system.c:
                Use "reboot" instead of "restart".  Fixes bug #327583.
      792a9fc5
  4. 13 Jan, 2006 1 commit
  5. 12 Jan, 2006 1 commit
    • Brian Cameron's avatar
      : Rename "shutdown" to "shut down" or "halt" and rename "capslock" to · 9d1a8584
      Brian Cameron authored
      2006-01-11  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/slave.c, docs/C/gdm.xml, gui/greeter/greeter_parser.c:: Rename
                "shutdown" to "shut down" or "halt" and rename "capslock" to
                "Caps Lock" since these are the recommended wordings suggested by
                Calum Benson.  Also corrected a few errors in the stock labels.
      9d1a8584
  6. 07 Jan, 2006 1 commit
    • Brian Cameron's avatar
      Make error message more clear when session file is invalid. Now it says · 17c96310
      Brian Cameron authored
      2006-01-04  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/slave.c: Make error message more clear when session file
                is invalid.  Now it says what session file had the problem.
                This fixes bug #322699.
              * gui/gdmconfig.c: Now the gdm_config_get_xserver_details
                function is more robust, and handles NULL return values
                better and supports PRIORITY.
              * gui/gdmsetup.c: Now that gdmconfig reads in the priority value,
                gdmsetup will write it back out if that server is modified.
                However, gdmsetup still doesn't allow you to modify the
                priority value.  Probably should add a spinbutton to the
                dialog.
      17c96310
  7. 25 Dec, 2005 2 commits
    • Brian Cameron's avatar
      Now set greeter_probably_login_prompt to FALSE if we get a Password · 3254ff45
      Brian Cameron authored
      2005-12-24  Brian Cameron  <brian.cameron@sun.com>
      
              * gui/greeter/greeter.c: Now set greeter_probably_login_prompt to
                FALSE if we get a Password request as a GDM_NOECHO message.  This
                makes GDM smarter about when it is at the Username prompt and
                fixes bug #320738, which was causing GDM to just login as the
                timed user when the password was requested - which it should not
                do.  It should only log in immediately as the timed user if ENTER
                is hit from the login screen without actually typing in a username.
              * gui/gdmlogin.c: Removed some syslog debug messages I accidently
                left there.
              * docs/C/gdm.xml: Now mention that if the user hits just ENTER
                when TimedLoginEnable is on, that GDM will just login immediately
                as the timed user.  This is how GDM has always behaved, just was
                not documented.
              * gui/greeter/greeter_session.c, gui/greeter/greeter_system.c:
                Removed syslog.h include since it isn't used in these files.
              * daemon/server.c: Fixed comments.
              * daemon/slave.c: Fixed comments.
      3254ff45
    • Brian Cameron's avatar
      Happy holidays. Some bug fixes. · 5e57744d
      Brian Cameron authored
      2005-12-24  Brian Cameron  <brian.cameron@sun.com>
      
              Happy holidays.  Some bug fixes.
      
              * daemon/gdm.h, daemon/gdmconfig.c, daemon/slave.c,
                gui/gdmlogin.c, gui/greeter/greeter_item_timed.c:
                Fix so that timed/automatic enable is checked and
                automatic/timed login is only turned on if they are
                enabled.  Fix so greeters restart if timed login is
                changed in gdmsetup.  Fixes bug #324337.
              * gui/gdmcommon.c, gui/gdmlogin.c, gui/greeter/greeter.c,
                gui/greeter/greeter_item.c, gui/greeter/greeter_parser.c:
                Now gdmlogin and gdmcommon use the same character sequences
                with Welcome/RemoteWelcome messages.  Fixes bug #322711.
              * docs/C/gdm.xml: Document how character sequences work with text
                labels and Welcome/RemoteWelcome messages.
              * gui/gdmcommon.[ch], gui/gdmchooser.c,
                gui/greeter/greeter_canvas_item.c, gui/greeter/greeter_geometry.c:
                Rename functions so all common functions have prefix gdm_common.
      5e57744d
  8. 22 Dec, 2005 1 commit
    • Brian Cameron's avatar
      Now use g_ stdio function like g_chmod instead of chmod. Fixes bug · 2be57792
      Brian Cameron authored
      2005-12-22  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/auth.c, daemon/display.c, daemon/errorgui.c,
                daemon/filecheck.c, daemon/fstype.c, daemon/gdm-net.c,
                daemon/gdm.[ch], daemon/gdmconfig.c, daemon/misc.c,
                daemon/server.c, daemon/slave.c, daemon/verify-pam.c,
                daemon/xdmcp.c, gui/gdmXnestchooser.c, gui/gdmchooser.c,
                gui/gdmcommon.c, gui/gdmlogin.c, gui/gdmphotosetup.c,
                gui/gdmsetup.c, gui/gdmuser.c, utils/gdmprefetch.c,
                vicious-extensions/ve-config.c, vicious-extensions/ve-gnome.c,
                vicious-extensions/ve-misc.[ch], vicious-extensions/ve-nongnome.c:
                Now use g_ stdio function like g_chmod instead of chmod.
                Fixes bug #310229.
      2be57792
  9. 14 Dec, 2005 1 commit
    • Brian Cameron's avatar
      Now consistantly use "GDM" in strings instead of "gdm". Fixes bug #323221. · c0796968
      Brian Cameron authored
      2005-12-13  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/gdm.c, daemon/slave.c, daemon/verify-pam.c,
                gui/gdmXnestchooser.c, gui/gdmchooser.c,
                gui/gdmcomm.c, gui/gdmflexiserver.c,
                gui/gdmlogin.c, gui/gdmsetup.glade,
                gui/greeter/greeter.c:  Now consistantly use
                "GDM" in strings instead of "gdm".  Fixes bug
                #323221.  Thanks to Adam Weinberger
                <adamw@gnome.org> for pointing this out.
      c0796968
  10. 23 Nov, 2005 1 commit
    • Brian Cameron's avatar
      daemon/verify-crypt.c, daemon/verify-pam.c, Convert to using new gdmconfig · 56b19e99
      Brian Cameron authored
      2005-11-23  Brian Cameron <Brian.Cameron@sun.com>
      
              * daemon/verify-crypt.c, daemon/verify-pam.c,
                Convert to using new gdmconfig interfaces.
              * daemon/choose.c, daemon/errorgui.c,
                daemon/gdm.c, daemon/gdmconfig.c,
                daemon/misc.c, daemon/slave.c,
                daemon/xdmcp.c, gui/gdmXnestchooser.c,
                gui/gdmconfig.c, gui/gdmlogin.c,
                gui/greeter/greeter_canvas_textm.c:  Fix
                compiler warnings.  Patch provided by
                Frederic Crozat on gdm-list@gnome.org.
                Also make sure that all functions have
                a space before the "(" to better follow
                coding style guide.
      
              * daemon/cookie.c, daemon/display.c,
                daemon/gdm-net.c, daemon/getvt.c,
                daemon/md5.c, daemon/server.c,
                daemon/verify-pam.c, gui/gdmchooser.c,
                gui/gdmcommon.c, gui/gdmdynamic.c,
                gui/gdmlanguages.c, gui/gdmuser.c,
                gui/greeter/greeter.c,
                gui/greeter/greeter_action_language.c,
                gui/greeter/greeter_action_canvas_item.c,
                gui/greeter/greeter_session.c,
                gui/greeter/greeter_system.c:  Make
                sure that all functions have a space
                before the "(" to better follow coding
                style guide.
      56b19e99
  11. 22 Nov, 2005 1 commit
    • Brian Cameron's avatar
      This further improves GDM configuration so that now only the GDM daemon · b68ffea6
      Brian Cameron authored
      2005-11-21  Brian Cameron <Brian.Cameron@sun.com>
      
              This further improves GDM configuration so that
              now only the GDM daemon parses and manages the
              configuration file.  Most client programs use
              the GET_CONFIG command to access needed data.
              This simplifies the configuration logic and
              puts all configuration parsing in one place
              and gets rid of a lot of global variables that
              were making the code look messy.  This also
              gets rid of several places where gnome_config
              deprecated functions were being used.  I have
              cleaned up the code so that the vicious-extensions
              code is more localized in gui/gdmconfig.[ch].
              Some work is left to do:  gdmflexiserver still
              uses gnome_config functions and gdmconfig should
              use the new functions for reading from the
              configuration file.  Some compile issues fixed
              as highlghted by dmacks@netspace.org to fix
              bug #322083.
      
              * NEWS: Fixed comment.
              * daemon/gdm.h: Further cleanup of #define's so
                that they better match the names of the config
                keys.
              * daemon/gdm.c: Now GET_CONFIG returns "OK" if
                the key is valid but has no value when it
                is a string.  Now free return value from
                gdm_config_to_string.
              * daemon/Makefile.am, gui/greeter/Makefile.am:
                Now the daemon validates the greeter's theme
                directory, so pass the default value into the
                daemon and not the greeter.
              * daemon/gdmconfig.h: Added gdm_is_valid_key
                and corrected prototype for
                gdm_set_user_session_lang.
              * daemon/slave.c: Fix warning and compile errors.
              * daemon/gdmconfig.c: Further fleshed out.
                Now it supports a few additional keys I
                overlooked.  It now validates all keys used
                by the slaves.  Now handles translated string.
                Further refactored the code.
              * gui/Makefile.am: Added gdmconfig.[ch] to
                common library.
              * gui/gdmconfig.[ch]: New functions for
                accessing configuration data for slaves.
              * gui/gdmXnestchooser.c, gui/gdmlanguages.c,
                gui/gdmsession.h, gui/gdmuser.h, gui/gdmwm.c,
                gui/misc.c, gui/greeter/greeter_item_capslock.c:
                gui/greeter/greeter_item_pam.c: No longer include
                vicious.h/viciousui.h, instead gdmconfig.h.
              * gui/gdmcomm.c: Fix gdm_check_comm to no
                longer require passing in the config file
                name.
              * gui/gdmcommon.[ch]: Get rid of old
                gdm_common_*_same functions that are
                replaced with new gui/gdmconfig logic.
                Now functions that access config data
                use the new functions.
              * gui/gdmflexiserver.c: Now displays the
                localized string when you use GET_CONFIG
                to access a translatable string.
              * gui/gdmconfig.c: Now calls update_key in
                addition to update_greeters when updating
                greeter config data, since the daemon needs
                to update the values now when they change.
              * gui/gdmchooser.c, gui/gdmdynamic.c,
                gui/gdmlogin.c, gui/gdmphotosetup.c,
                gui/gdmsession.c, gui/gdmuser.c,
                gui/gdm/gdmXnestchooser.c,
                gui/greeter/greeter.c,
                gui/greeter/greeter_action_language.c,
                gui/greeter/greeter_canvas_item.c,
                gui/greeter/greeter_item.c,
                gui/greeter/greeter_item_customlist.c,
                gui/greeter/greeter_item_timed.c,
                gui/greeter/greeter_item_list.c,
                gui/greeter/greeter_parser.c,
                gui/greeter/greeter_session.c,
                gui/greeter/greeter_system.c:  Updated to
                use new configuration functions.
              * vicious-extensions/glade-helper.c: Now
                include stdlib.h to avoid compiler warnings.
              * gui/greeter/greeter.c: Remove unused
                gdm_kill_thingies function.
      b68ffea6
  12. 08 Nov, 2005 1 commit
  13. 04 Nov, 2005 1 commit
    • Brian Cameron's avatar
      Redesign of daemon configuraton. Now all vicious-extensions logic is in · 4d29395d
      Brian Cameron authored
      2005-11-03  Brian Cameron  <brian.cameron@sun.com>
      
              Redesign of daemon configuraton.  Now all vicious-extensions
              logic is in gdmconfig.[ch].  This greatly simplifies how the
              UPDATE_CONFIG, and GET_CONFIG commands work and makes it
              easier to update the way GDM handles configuration.  Changed
              ve_setenv/ve_unsetenv to g_setenv/g_unsetenv since GDM requires
              a newer version of GLIB than could possibly cause the old
              ve versions to get used.
      
              * daemon/gdmconfig.[ch]: New logic for interacting with
                vicious-extensions.
              * daemon/gdm.h: Updated comments and changed the #define
                for many configuration options so the naming is more
                consistant.  Now the #defines more closely match the
                keys in gdm.conf and more consistantly use the underscore.
              * daemon/auth.c, daemon/choose.c, daemon/cookie.c,
                daemon/display.c, daemon/errorgui.c, daemon/gdm-net.c,
                daemon/gdm.c, daemon/getvt.c, daemon/misc.c,
                daemon/server.c, daemon/slave.c, daemon/verify-crypt.c,
                daemon/verify-pam.c, daemon/verify-shadow.c,
                daemon/xdmcp.c: Reorganized configuration.
              * daemon/auth.h, daemon/cookie.h, daemon/display.h,
                daemon/errorgui.h, daemon/filecheck.h, daemon/gdm-net.h,
                daemon/getvt.h, daemon/misc.h, daemon/server.h,
                daemon/slave.h, daemon/verify.h, daemon/xdmcp.h:
                Now include gdmconfig.h instead of vicious.h and changed
                "Gnome" to "GNOME" in comment.
              * daemon/Makefile.am: Added new gdmconfig.[ch]
              * gui/gdmXnestChooser.c, gui/gdmchooser.c, gui/gdmcomm.c,
                gui/gdmdynamic.c, gui/gdmflexiserver.c, gui/gdmlogin.c,
                gui/gdmphotosetup.c, gui/gdmsetup.c, gui/greeter/greeter.c,
                gui/greeter/greeter_item_capslock.c,
                utils/gdm-dmx-reconnect-proxy.c: Updated to reflect the
                new configuration #defines.
      4d29395d
  14. 28 Oct, 2005 3 commits
    • Dennis Cranston's avatar
      Fix bug #314685, "Gdmsetup UI fixes". Based on redesign mockups by Calum · 4d3aad4f
      Dennis Cranston authored
      2005-10-27  Dennis Cranston  <dennis_cranston@yahoo.com>
      
              Fix bug #314685, "Gdmsetup UI fixes".  Based on redesign mockups
              by Calum Benson from http://www.gnome.org/~calum/usability/specs/gdm/.
      
              * gui/gdmsetup.c: (logo_toggle_timeout), (logo_toggle_toggled),
                (xserver_update_delete_sensitivity), (init_servers_combobox),
                (update_remote_sensitivity), (refresh_remote_tab),
                (combobox_timeout), (list_selection_toggled), (combobox_changed),
                (toggle_toggled_sensitivity_positive),
                (timedlogin_allow_remote_toggled), (setup_notify_toggle),
                (setup_xdmcp_notify_toggle), (users_string_compare_func),
                (setup_user_combobox_list), (setup_xdmcp_intspin), (face_add),
                (face_del), (browser_move), (browser_apply),
                (users_add_button_clicked), (setup_face), (greeter_toggle_timeout),
                (sensitive_entry_toggled), (local_background_type_toggle_timeout),
                (local_background_type_toggled), (setup_greeter_toggle),
                (greeter_color_timeout), (setup_greeter_color),
                (xdmcp_button_clicked), (vt_spinbutton_activate),
                (setup_greeter_combobox), (setup_xdmcp_support),
                (acc_modules_toggled), (test_sound), (sound_response),
                (setup_users_tab), (setup_accessibility_tab),
                (gg_selection_changed), (read_themes), (selected_toggled),
                (theme_install_response), (install_new_theme), (delete_theme),
                (xserver_entry_timeout), (xserver_toggle_timeout),
                (xserver_init_server_list), (xserver_init_servers),
                (xserver_row_selected), (xserver_remove), (xserver_add),
                (xserver_add_button_clicked), (xserver_init_definitions),
                (xserver_delete), (setup_xserver_support),
                (xserver_button_clicked), (setup_security_tab),
                (setup_local_themed_settings), (image_filechooser_response),
                (logo_filechooser_response), (create_preview_pixbuf),
                (update_image_preview), (hookup_plain_background),
                (hookup_plain_logo), (setup_plain_menubar),
                (setup_local_welcome_message), (setup_remote_welcome_message),
                (setup_local_plain_settings), (setup_local_tab),
                (hookup_remote_plain_background), (hookup_remote_plain_logo),
                (setup_remote_plain_settings), (setup_remote_themed_settings),
                (setup_remote_tab), (setup_gui), (apply_user_changes), (main):
                Implement the new UI. Fix various compiler warnings.
              * gui/gdmsetup.glade:  Implement the new UI.
              * gui/greeter/greeter.c: (main):  Get the background color from
                GDM_KEY_GRAPHICAL_THEME_COLOR, but fallback to GDM_KEY_BACKGROUNDCOLOR
                if its does not exist.
              * gui/gdmlogin.c: (gdm_login_parse_config), (setup_background),
                (gdm_reread_config): Fix bugs found in the parsing of the welcome
                messages.  Add support for a GDM_BACKGROUND_IMAGE background type.
                Fix the setup of the welcome message string in the greeter.  Fix
                various compiler warnings.
              * vicious-extensions/glade-helper.c: (glade_helper_tagify_label):
                Add support for more than one markup tag.
              * daemon/gdm.h:  Define GDM_KEY_GRAPHICAL_THEME_COLOR and
                GDM_KEY_CHOOSER_BUTTON_LOGO keys.
              * daemon/gdm.c: (gdm_handle_user_message): Add newly defined keys.
              * daemon/slave.c: (session_child_run):  Pass a GDM_GREETER_TYPE
                environmental variable to presession script.
              * config/PreSession.in:  Add support for plain and background color.
      4d3aad4f
    • Brian Cameron's avatar
      Fixed broken patch I just committed. · 428a2f61
      Brian Cameron authored
      428a2f61
    • Erdal Ronahi's avatar
      Fix race condition where the d variable wasn't being set until after the · a4063b36
      Erdal Ronahi authored
      2005-10-27  Erdal Ronahi  <erdal.ronahi@gmail.com>
      
              * daemon/slave.c: Fix race condition where the d
                variable wasn't being set until after the signal
                handlers, and the signal handlers make use of
                this variable.  Now set it before to ensure it
                is set whenever a signal might be received.
                Issue pointed out by Simon Bowden on
                gdm-list@gnome.org
      a4063b36
  15. 06 Oct, 2005 1 commit
    • Brian Cameron's avatar
      Fix problem with PostSession script not always getting executed when user · cb4974a4
      Brian Cameron authored
      2005-10-06  Brian Cameron <Brian.Cameron@sun.com>
      
              * daemon/slave.c: Fix problem with PostSession
                script not always getting executed when user
                kills the Xserver with ctl-alt-backspace.
                This is caused because an xioerror is generated
                by whack clients and this xioerror needs to be
                ignored for PostSession to be processed.  This
                problem tended not to manifest in GDM 2.6
                because the introduction of the whack clients
                call made the xioerror get generated earlier.
                However, it was still a race condition and
                this fix ensures that the xioerror will not
                cause the slave to ever exit too early.
                Fixes bug #152906.  Patch provided by Jerry
                G. DeLapp <jgd@lanl.gov>
      cb4974a4
  16. 04 Oct, 2005 1 commit
  17. 15 Sep, 2005 3 commits
  18. 14 Sep, 2005 1 commit
    • Brian Cameron's avatar
      Now turn on gesture debug when GDM debug is on. Fix bug in · c75a300b
      Brian Cameron authored
      2005-09-13  Brian Cameron <Brian.Cameron@sun.com>
      
              * daemon/slave.c, gui/modules/dwellmouselistener.c,
                gui/modules/keymouselistener.c:  Now turn on gesture
                debug when GDM debug is on.  Fix bug in
                dwellmouselistener that was causing gestures to
                not be recognized.
      c75a300b
  19. 07 Sep, 2005 1 commit
    • Brian Cameron's avatar
      Correct memory leaks. Fixes bug #315388, patch by Ray Strode with minor · 9819635a
      Brian Cameron authored
      2005-09-06  Brian Cameron <Brian.Cameron@sun.com>
      
              * daemon/auth.c, daemon/gdm.c, daemon/slave.c,
                daemon/verify-pam.c, gui/gdmchooser.c, gui/gdmcomm.c,
                gui/gdmdynamic.c, gui/gdmlogin.c, gui/gdmphotosetup.c,
                gui/gdmsetup.c, gui/greeter/greeter.c,
                gui/greeter/greeter_canvas_item.c,
                gui/greeter/greeter_session.c,
                gui/modules/keymouselistener.c,
                utils/gdm-dmx-reconnect-proxy.c,
                vicious-extensions/vc-misc.c:  Correct memory leaks.
                Fixes bug #315388, patch by Ray Strode with minor
                tweaks by myself.
      9819635a
  20. 20 Aug, 2005 1 commit
  21. 26 Jul, 2005 1 commit
    • William Jon McCann's avatar
      Added depcomp and stamp-h1 · 83a9f977
      William Jon McCann authored
      2005-07-25  William Jon McCann  <mccann@jhu.edu>
      
      	* .cvsignore: Added depcomp and stamp-h1
      
      	* daemon/slave.c (ask_migrate)
      	(gdm_slave_check_user_wants_to_log_in):
      	* daemon/gdm.[ch] (gdm_config_parse):
      	* config/gdm.conf.in:
      	Add a configuration option AlwaysLoginCurrentSession
      	that will automatically switch the user back to their
      	previous session without asking.  This is off by
      	default for now.  Fixes bug #311415.
      83a9f977
  22. 19 Jul, 2005 2 commits
    • William Jon McCann's avatar
      Use common function for loading face images. · f3806b9d
      William Jon McCann authored
      2005-07-19  William Jon McCann  <mccann@jhu.edu>
      
      	* gui/greeter/greeter_item_ulist.c (gdm_greeter_users_init):
      	Use common function for loading face images.
      
      	* gui/greeter/greeter.c (greeter_ctrl_handler):
      	Update for new common code.
      
      	* gui/gdmuser.c (gdm_user_alloc): Use common function for
      	loading face images.
      	(setup_user): Define as static.
      
      	* gui/gdmlogin.c (gdm_kill_thingies): Make static.
      	(gdm_login_ctrl_handler): Update for new gdm_common_login_sound.
      	Add gdm_kill_thingies before all abort calls since they are
      	not in gdm_common_abort anymore.
      	(main): Use new common get face function.
      
      	* gui/Makefile.am:
      	* gui/gdmcommon.c (gdm_common_show_info_msg, gdm_common_login_sound):
      	Make more common by not depending on external variables.
      	(gdm_common_abort): Make more common by not depending on
      	external functions.
      	(gdm_common_get_face): Add a common function for loading
      	face images.
      
      	* daemon/slave.c (path_is_local, check_user_file)
      	(check_global_file, get_facefile_from_gnome2_dir_config)
      	(get_facefile_from_home, get_facefile_from_global, run_pictures):
      	Don't stat or read from remote home directories.  Fixes #310545.
      
      	* configure.in:
      	* daemon/Makefile.am:
      	* daemon/fstype.c: Add ability to detect filesystem types.
      
      	* gui/greeter/greeter_item_ulist.c (gdm_greeter_users_init):
      	* gui/gdmlogin.c (main):
      	Try GTK+ themed icon stock_person before falling back to
      	nobody.png.  Fixes #310906.
      f3806b9d
    • Tommi Vainikainen's avatar
      Cleanup terminology, and fix many strings. See bug #310453. Also fixes bug · 4bd89e59
      Tommi Vainikainen authored
      2005-07-19  Tommi Vainikainen  <thv@iki.fi>
      
      	* config/XKeepsCrashing, config/Xsession.in, daemon/display.c,
      	daemon/gdm.c, daemon/slave.c, docs/C/gdm.xml,
      	gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcomm.c,
      	gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsetup.c,
      	gui/gdmsetup.glade, gui/greeter/greeter.c,
      	gui/greeter/greeter_session.c, gui/greeter/greeter_system.c:
      	Cleanup terminology, and fix many strings. See bug #310453.
      	Also fixes bug #308287. List of the most important string changes:
      	machine -> computer
      	program -> application or command
      	superuser -> root
      	gdm, Gdm -> GDM
      	See the Language chapter in GNOME HIG for more information.
      4bd89e59
  23. 20 Jun, 2005 2 commits
  24. 06 May, 2005 1 commit
    • Brian Cameron's avatar
      Rename console and TYPE_LOCAL in preparation for adding the dynamic · 4c8b5cb8
      Brian Cameron authored
      2005-05-06  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/auth.c, daemon/display.c, daemon/gdm.[ch],
                daemon/server.c, daemon/slave.c, daemon/verify-pam.c,
                daemon/xdmcp.c, AUTHORS:  Rename console and
                TYPE_LOCAL in preparation for adding the dynamic
                Xserver patch.  This is part of the fix for bug
                #168219.  Patch provided by Bob Terek.
      4c8b5cb8
  25. 25 Apr, 2005 2 commits
    • Brian Cameron's avatar
      To support when one username can be mapped to another canonical username, · 6d866f58
      Brian Cameron authored
      2005-04-25  Brian Cameron  <brian.cameron@sun.com>
              * daemon/slave.c: To support when one username can be
                mapped to another canonical username, we use the
                loginname that pwent returns instead of the one
                that was typed. in.  Fixes bug #301820.  Now use
                seteuid before checking existance of user's home
                directory since root doesn't always have access
                and fails otherwise.  Fixes bug #301821.
      6d866f58
    • Brian Cameron's avatar
      Fix typos in strings. Fixes bug 301694. Patch provided by Kjartan Maraas. · b72546f6
      Brian Cameron authored
      2005-04-25  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/gdm.c, daemon/slave.c, daemon-verify-pam.c,
                gui/gdmcomm.c, gui/gdmlogin.c, gui/gdmsetup.c,
                vicious-extensions/glade-helper.c:  Fix typos
                in strings.  Fixes bug 301694.  Patch provided
                by Kjartan Maraas.
      b72546f6
  26. 22 Apr, 2005 1 commit
    • Mark McLoughlin's avatar
      Add the ability to make GDM spawn XDMCP sessions on a local X proxy · cbacaed0
      Mark McLoughlin authored
      2005-04-22  Mark McLoughlin  <mark@skynet.ie>
      
      	Add the ability to make GDM spawn XDMCP sessions on a local
      	X proxy server. Experimental support for disconnect/reconnect
      	or "session migration" is also implemented using DMX.
      	More details in bug #301602.
      
      	* configure.in: require glib 2.6.0 and check for DMX.
      
      	* config/gdm.conf.in: add xdmpc/EnableProxy, xdmcp/ProxyXServer
      	and xdmcp/ProxyReconnect config keys.
      
      	* docs/C/gdm.xml: document new config keys.
      
      	* daemon/gdm.h: add TYPE_XDMCP_PROXY server type, add #defines
      	for the new config keys, re-name various xnest related GdmDisplay
      	members to be applicable for all proxy servers, add xdmcp_dispnum
      	GdmDisplay member, modify the format of GDM_SOP_QUERYLOGIN and
      	add GDM_SOP_AUTHFILE and GDM_SOP_MIGRATE.
      
      	* daemon/gdm.c: read the new config keys, change format of what
      	GDM_SOP_QUERYLOGIN returns, implement GDM_SOP_AUTHFILE and
      	GDM_SOP_MIGRATE.
      
      	* daemon/xdmcp.h: add gdm_xdmcp_migrate.
      
      	* daemon/xdmcp.c: when xdmpc/EnableProxy and xdmcp/ProxyXServer,
      	set things up such that a proxy sever (which displays on the
      	requesting X server) is run locally by the slave.
      	Also implement migrating the proxy server from one parent display
      	to another using the xdmcp/ProxyReconnect command.
      
      	* daemon/server.c: if we're running a proxy server (e.g. Xnest
      	or Xdmx), hold a connection open to the parent display so that
      	it doesn't reset.
      	Run proxy servers with -display rather than setting $DISPLAY.
      
      	* daemon/slave.c:
      	Once we've successfully logged the user in, send SOP_QUERYLOGIN
      	to the slave - if the result from that indicates that the user
      	is already logged in and that session is migratable (e.g. by
      	reconnecting a proxy server or changing the VT), then migrate
      	to the existing session using SOP_MIGRATE.
      	In the case of an Xdmcp proxy, hold open the connection to the
      	parent display so that it doesn't reset. Exit the slave as
      	soon as that connection closes.
      
      	* utils/Makefile.am, utils/gdm-dmx-reconnect-proxy.c: implementation
      	of xdmcp/ProxyReconnect for use with Xdmx.
      cbacaed0
  27. 21 Apr, 2005 1 commit
    • Mark McLoughlin's avatar
      Don't use gdm_debug() from signal handlers - the message formatting and · edfe5f29
      Mark McLoughlin authored
      2005-04-21  Mark McLoughlin  <mark@skynet.ie>
      
              Don't use gdm_debug() from signal handlers - the message
              formatting and the syslog() both involve malloc() which
              isn't safe in signal handlers. Fixes random lockups with
              debugging enabled.
      
              * daemon/server.c:
              (gdm_server_usr1_handler),
              (gdm_server_child_handler): don't use gdm_debug() here.
      
              * daemon/slave.c:
              (gdm_slave_usr2_handler),
              (gdm_slave_child_handler): or here.
      edfe5f29
  28. 20 Apr, 2005 1 commit
    • Brian Cameron's avatar
      Cleanup for login success/failure sounds. Patch provided by Mark · 5ca67028
      Brian Cameron authored
      2005-04-19  Brian Cameron  <brian.cameron@sun.com>
      
              * config/gdm.conf.in, daemon/gdm.[ch], daemon/slave.c,
                gui/gdmchooser.c, giu/gdmlogin.c:  Cleanup for
                login success/failure sounds.  Patch provided by
                Mark McLoughlin.  Refer to bug #300136.
              * daemon/gdm.c: Fix FlexiServer commands so that all
                output for a single command is sent as a single call
                to gdm_connection_write or gdm_connection_printf
                rather than building commands and sending them out
                in pieces.  Also use gdm_connection_printf rather
                than building so many temporary strings.  Patch
                provided by for GDM_SUP_QUERY_LOGOUT_ACTION, but
                I reworked the patch so the same technique is used
                for all gdmflexiserver commands.  Fixes bug
                #158799.  Patch based on one provided by Raffaele
                Sandrini <rasa@gmx.ch>
              * gui/greeter/greeter_geometry.c,
                gui/greeter/greeter_item.h,
                gui/greeter/greeter_parser.c, docs/C/gdm.xml:  Now
                support ratio scaling of SVG images.  Docs weren't
                provided with the patch so I added some.  Patch
                provided by.  Fixes bug 159524.  Patch provided by
                Vincent Untz <vincent@vuntz.net>.
              * gui/gdmlogin.c: Rearrange how the widgets are
                organized to make it look a bit better now that
                the message fields have sizes defined to avoid gdm2
                resizing.  Bit more of a fix for bug #117779.
              * README.install: Spell corrections and minor updates,
                now mention that running configure with the option
                --with-post-path=/usr/openwin/bin is recommended
                on Solaris.
              * MAINTAINERS, AUTHORS, NEWS, docs/C/gdm.xml,
                daemon/gdm.h: Fixed spelling, added contributors
                to AUTHORS file for patches made in the past
                few months.
              * docs/C/gdm.xml: Fixed bug 300138 by providing
                better sound docs in the a11y section.  Fixes
                bug #300138.  Patch provided by Andrew Case.
              * gui/gdmsetup.glade, gui/gdmsetup-strings.c: Removed
                strings "sdfg" and "asdf" since they can't be
                translated.  Fixes bug #301211.
              * gui/gdmchooser.c: Removed needless comment.
      5ca67028
  29. 19 Apr, 2005 1 commit
    • Brian Cameron's avatar
      Add login success/failure sounds. Patch provided by Andrew Case. Refer to · 57a1cef3
      Brian Cameron authored
      2005-04-18  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/gdm.[ch], daemon/slave.c, docs/C/gdm.xml,
                gui/gdmchooser.c, gui/gdmcommon.c, gui/gdmlogin.c,
                gui/gdmsetup-strings.c, gui/gdmsetup.c,
                gui/gdmsetup.glade, gui/greeter/greeter.c,
                gui/greeter/greeter_configuration.h:  Add login
                success/failure sounds.  Patch provided by Andrew
                Case.  Refer to bug #300136.
      57a1cef3
  30. 13 Apr, 2005 1 commit
    • Brian Cameron's avatar
      Display an error dialog if the user's $HOME/.dmrc can't be accessed for · 06627b0e
      Brian Cameron authored
      2005-04-12  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/slave.c: Display an error dialog
                if the user's $HOME/.dmrc can't be accessed
                for permissions reasons.  Fixes bug 141126.
              * gui/gdmlogin.c, gui/greeter/greeter_item_pam.c:
                Now tab acts like enter.  Fixes bug #127339.
              * gui/gdmsetup.c: Fixed theme installer so it
                remembers where the last theme was installed
                from and opens the file browser in that
                location.  Fixes bug #164785.  Also fixed a
                bug which was causing only *tar.gz files to
                be installable.  Now it works for *.tar files
                on my system.
      06627b0e
  31. 06 Apr, 2005 1 commit
    • Brian Cameron's avatar
      Changed messages so that I-form isn't used. Fixes bug #118193. Noticed · 599fb64e
      Brian Cameron authored
      2005-04-06  Brian Cameron  <brian.cameron@sun.com>
      
              * daemon/auth.c, daemon/choose.c, daemon/cookie.c,
                daemon/display.c, daemon/errorgui.c, daemon/filecheck.c,
                daemon/gdm-net.c, daemon/gdm.c, daemon/md5.h,
                daemon/misc.c, daemon/server.c, daemon/slave.c,
                daemon/verify-crypt.c, daemon/verify-pam.c,
                daemon/verify-shadow.c, daemon/xdmcp.c,
                gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcomm.h,
                gui/gdmcommon.c, gui/gdmlanguages.c, gui/gdmuser.[ch],
                gui/gdmwm.c, gui/misc.c, gui/greeter/*.[ch],
                vicious-extensions/test-ve-config.c,
                vicious-extensions/ve-i18n.h, vicious-extensions/vicious.h,
                vicious-extensions/viciousui.h:  Changed messages so that
                I-form isn't used.  Fixes bug #118193.  Noticed many
                files didn't have a GPL license as a comment at the top
                of the file, so added those.  Changed "Gnome" to "GNOME"
                in comments.
              * gui/gdmlogin.c: Now display timed login message in a
                separate label, which avoids problems caused because different
                things (PAM, timed login, etc.) are trying to use the same
                label for status messages.  This fixes bug #67647.
      599fb64e