Commit fc6ee4aa authored by Ray Strode's avatar Ray Strode

common: don't tank on criticals

Tiny (or not so tiny) bugs in components below GDM in the stack
can lead to critical warnings.

In development releases, GDM by default will crash when encountering
a critical warning.

Losing the login screen is a big deal.  We shouldn't automatically subject
our users to "can't log in" in order to highlight bugs in development
releases.

This commit removes fatal criticals by default.
parent 8c5f0a79
......@@ -65,15 +65,6 @@ gdm_is_version_unstable (void)
return unstable;
}
void
gdm_set_fatal_warnings_if_unstable (void)
{
if (gdm_is_version_unstable ()) {
g_setenv ("G_DEBUG", "fatal_criticals", FALSE);
g_log_set_always_fatal (G_LOG_LEVEL_CRITICAL);
}
}
gboolean
gdm_get_pwent_for_name (const char *name,
struct passwd **pwentp)
......
......@@ -31,7 +31,6 @@
G_BEGIN_DECLS
gboolean gdm_is_version_unstable (void);
void gdm_set_fatal_warnings_if_unstable (void);
int gdm_wait_on_pid (int pid);
int gdm_wait_on_and_kill_pid (int pid,
......
......@@ -183,8 +183,6 @@ main (int argc,
textdomain (GETTEXT_PACKAGE);
setlocale (LC_ALL, "");
gdm_set_fatal_warnings_if_unstable ();
g_type_init ();
context = g_option_context_new (_("GNOME Display Manager Slave"));
......
......@@ -543,8 +543,6 @@ main (int argc,
ret = 1;
gdm_set_fatal_warnings_if_unstable ();
g_type_init ();
context = g_option_context_new (_("GNOME Display Manager"));
......
......@@ -187,8 +187,6 @@ main (int argc,
textdomain (GETTEXT_PACKAGE);
setlocale (LC_ALL, "");
gdm_set_fatal_warnings_if_unstable ();
g_type_init ();
context = g_option_context_new (_("GNOME Display Manager Slave"));
......
......@@ -151,8 +151,6 @@ main (int argc,
g_type_init ();
gdm_set_fatal_warnings_if_unstable ();
/* Translators: worker is a helper process that does the work
of starting up a session */
context = g_option_context_new (_("GNOME Display Manager Session Worker"));
......
......@@ -187,8 +187,6 @@ main (int argc,
textdomain (GETTEXT_PACKAGE);
setlocale (LC_ALL, "");
gdm_set_fatal_warnings_if_unstable ();
g_type_init ();
context = g_option_context_new (_("GNOME Display Manager Slave"));
......
......@@ -189,8 +189,6 @@ main (int argc,
textdomain (GETTEXT_PACKAGE);
setlocale (LC_ALL, "");
gdm_set_fatal_warnings_if_unstable ();
g_type_init ();
context = g_option_context_new (_("GNOME Display Manager Slave"));
......
......@@ -233,8 +233,6 @@ main (int argc, char *argv[])
setlocale (LC_ALL, "");
gdm_set_fatal_warnings_if_unstable ();
g_type_init ();
gdm_log_init ();
......
......@@ -232,8 +232,6 @@ main (int argc, char *argv[])
setlocale (LC_ALL, "");
gdm_set_fatal_warnings_if_unstable ();
g_type_init ();
gdm_log_init ();
......
......@@ -252,8 +252,6 @@ main (int argc, char *argv[])
setlocale (LC_ALL, "");
gdm_set_fatal_warnings_if_unstable ();
g_type_init ();
gdm_profile_start ("Initializing settings client");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment