- 22 Aug, 2018 1 commit
-
-
Emmanuele Bassi authored
The read_pixels() method is missing a `Returns` stanza. The read_pixels_bytes() method is missing a description. Both functions do the same thing, so they should be documented similarly.
-
- 02 Jul, 2018 1 commit
-
-
Federico Mena Quintero authored
-
- 01 Jun, 2018 1 commit
-
-
Federico Mena Quintero authored
Instead of checking the bytes vs. pixels fields all over the place, we introduce an enum that says which mode the pixbuf is in. We have a central downgrade_to_pixels() function to turn the pixbuf from immutable to mutable. This commit only does the gdk-pixbuf core; we'll deal with pixdata and the loaders separately.
-
- 25 Apr, 2018 2 commits
-
-
Calling g_bytes_unref_to_data() will copy the contents of the bytes buffer, so we need to free the data. https://bugzilla.gnome.org/show_bug.cgi?id=787626
- 04 Dec, 2017 1 commit
-
-
Bastien Nocera authored
Reference links use "[title][id]" not "[title](id)", that's for URLs. https://bugzilla.gnome.org/show_bug.cgi?id=765282
-
- 01 Aug, 2017 1 commit
-
-
Emmanuele Bassi authored
Do not include the source, otherwise we're going to compile symbols twice.
-
- 28 Jul, 2017 1 commit
-
-
Bastien Nocera authored
To calculate the rowstride without allocating memory! https://bugzilla.gnome.org/show_bug.cgi?id=765094
-
- 27 Jul, 2017 1 commit
-
-
Bastien Nocera authored
The rowstride is stored as an int, and is an int in the public API. Making it an unsigned int for those calculations would increase the limit, which would obviously cause problems when the calculated value ends up between G_MAXUINT and G_MAXINT in the positives. https://bugzilla.gnome.org/show_bug.cgi?id=765094
-
- 15 Mar, 2017 1 commit
- 07 Feb, 2017 1 commit
-
-
Philip Withnall authored
The recommended way to do an overflow check is to check against the limit you have in mind, rather than doing the calculation and seeing if it failed. Fix this by rearranging the check: move the variables we control (or have previously checked) over to one side, leaving the unknown variable on its own on the left-hand side. This ensures the overflow check doesn’t overflow itself. Coverity ID: 1388538 https://bugzilla.gnome.org/show_bug.cgi?id=777315
-
- 13 Sep, 2016 1 commit
-
-
Doing overflow checks with signed integers invokes undefined behavior and induces modern compilers to omit the checks altogether. Avoid this by doing the overflow check with unsigned integers. https://bugzilla.gnome.org/show_bug.cgi?id=770986
-
- 02 Aug, 2016 3 commits
- 05 May, 2016 1 commit
-
-
Matthias Clasen authored
We were emitting ::notify even for properties which have only one possible value.
-
- 24 Oct, 2014 4 commits
-
-
Bastien Nocera authored
This fixes a crash when using Python's "new" keyword instead of the constructors exported by GdkPixbuf. See https://bugzilla.gnome.org/show_bug.cgi?id=658702
-
Bastien Nocera authored
abicheck.sh threw an error because of the wrongly prefixed was used in commit: f37f850a
-
Bastien Nocera authored
Use glib's i18n support rather than copy pasting it. Note that gdk_pixbuf_gettext() is kept as it's an exported symbol.
-
Bastien Nocera authored
As they're defined to the same thing anyway.
-
- 22 Oct, 2014 3 commits
-
-
- 21 Oct, 2014 3 commits
-
-
Bastien Nocera authored
gdk-pixbuf.c:663: Warning: GdkPixbuf: GObject-Introspection specific GTK-Doc tag "Rename to" has been deprecated, please use annotations on the identifier instead.
-
Bastien Nocera authored
So people don't have to guess the possible values of "key" in gdk_pixbuf_get_option() calls https://bugzilla.gnome.org/show_bug.cgi?id=674858
-
Bastien Nocera authored
Document the "multipage" option added in commit 09b3fc03
-
- 18 Jul, 2014 2 commits
-
-
This can be convenient for language bindings to access the readonly data in a form that includes length, and also avoids a copy (for readonly pixbufs). https://bugzilla.gnome.org/show_bug.cgi?id=732297
-
GdkPixbuf is an old API that predates introspection and GBytes. It has some confusion around whether or not pixbuf data is mutable or not. The _new_from_data() API takes a *const* pointer, but it's not copied, and _get_pixels() returns a non-const copy of the same pointer. There are several cases where we get read-only data, such as a GResource. For language bindings, _new_from_data() doesn't work because the array may be a temporary copy only allocated for the call. In order to support a clean _new_from_bytes() API, we need to add the concept of a read-only pixbuf into the core. The fundamental hack here is that _get_pixels() now causes an implicit copy. For the cases where we don't want to copy, add a new gdk_pixbuf_read_pixels() that returns a proper const pointer. https://bugzilla.gnome.org/show_bug.cgi?id=732297
-
- 15 Feb, 2014 1 commit
-
-
Matthias Clasen authored
Switch to markdown for our inline markup needs, and turn off sgml mode for the docs.
-
- 31 Jan, 2014 1 commit
-
-
Daniel Mustieles García authored
-
- 19 Dec, 2013 1 commit
-
-
Matthias Clasen authored
This lets us avoid some manual overflow checks.
-
- 21 Apr, 2013 1 commit
-
-
The "new rules" for GIcon say that we must support serialisation via g_icon_serialize() and loadability via GLoadableIcon, so implement both of those. Serialise GdkPixbuf by emitting a GVariant that will result in a png-encoded GBytesIcon when deserialized. The GLoadableIcon interface is similar: we return a stream that will read out as a png. Test the serialisation by round-tripping an image through this process and ensuring that it is pixel-perfect. https://bugzilla.gnome.org/show_bug.cgi?id=688820
-
- 03 Sep, 2012 1 commit
-
-
Matthias Clasen authored
Patch by Rafał Mużyło, https://bugzilla.gnome.org/show_bug.cgi?id=676430
-
- 16 Dec, 2011 4 commits
-
-
Matthias Clasen authored
Reported by Evan Nemerson in bug 659888.
-
Matthias Clasen authored
-
Matthias Clasen authored
-
Binary data needs an explicit length to be useful. Add a new API for getting length of binary data, and allow gi users to use "get_pixels" in a useful manner instead of just grabbing the first pixel. https://bugzilla.gnome.org/show_bug.cgi?id=662009
-
- 09 Jun, 2011 1 commit
-
-
Javier Jardón authored
-
- 06 Mar, 2011 1 commit
-
-
Jon Nordby authored
This puts all the docs that existed in tmpl files when gdk-pixbuf was moved out of gtk into inline comments. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=635643
-
- 11 Feb, 2011 1 commit
-
-
Benjamin Otte authored
-