Skip to content

Initial support for being kicked.

Isaac Curtis requested to merge icurtis/fractal:kicked into master

Fractal currently does not have support for being kicked: see #433 (closed) . This adds a dialog box to notify the user that they have been kicked as suggested.

TODO:

  • Dialog box for being kicked
  • Show user that kicked
  • Support for banning (will track in a separate ticket)

kicked

Causes for concern:

  • It should be possible for the kicked_room fn to just take the roomid instead of all three params. However, it was not working to get the room membership inside of the function.
  • Use of unwrap() in fractal-gtk/src/appop/room.rs
  • Redundant? use of if room.membership.is_kicked() in fractal-gtk/src/appop/room.rs
  • RoomMembership::Kicked takes two Strings. Not very descriptive.
Edited by Isaac Curtis

Merge request reports