Visual jumps due to typing notifcation
If you are in a very busy room the history jumps often due to the notification that is shown if people are typing.
Steps to reproduce:
- Open Fractal
- Enter a busy room
- Wait for people typing and see the history jumping.
-
This bug is reproducible from the latest nightly build
Fractal Version: 4.2.2
OS Version:
- Operating System: Arch Linux
- Kernel: Linux 5.5.13-arch2-1
Installation Source: arch community
Solution Proposal:
I would propose to just keep a blank space where the typing messages would be shown if people were typing. Thus, if the message appears the layout won't change.
I'm new to rust and the project but I guess scroll_widgets.rs#L291 would be the right place.
pub fn typing_notification(&self, typing_str: &str) {
--- if typing_str.len() == 0 {
--- self.widgets.typing_label.set_visible(false);
--- } else {
--- self.widgets.typing_label.set_visible(true);
--- self.widgets.typing_label.set_markup(typing_str);
--- }
+++ self.widgets.typing_label.set_visible(true);
+++ self.widgets.typing_label.set_markup(typing_str);
}