Crashes when no secret service available
Steps to reproduce:
- Open Fractal 4.2.0 for the first time on a system that does not have any secret service available
- Enter your login details and press enter
This either gives an error dialog saying "Can't log in, try again" while giving this output:
fractal_gtk::appop::login: Can't store the password using libsecret
fractal_gtk::app::backend_loop: Query error: LogoutError(ReqwestError(Error(Json(Error("expected value", line: 1, column: 1)))))
Or it crashes with the following output:
fractal_gtk::appop::login: Can't store the password using libsecret
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:999:5
stack backtrace:
0: 0x564255fdc60f - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::h7da32f153d30035b
1: 0x564255fec457 - std::sys_common::backtrace::print::h0a5ee5c85c95c4bf
2: 0x564255fe0f73 - std::panicking::default_hook::{{closure}}::haebce72f1bccb8e1
3: 0x564255fe0d00 - std::panicking::default_hook::h70ef9a11c85e490f
4: 0x564255fe166f - std::panicking::rust_panic_with_hook::h835f1f511b60066f
5: 0x564255fe1201 - std::panicking::continue_panic_fmt::hbb10507e54854435
6: 0x564255fe10e5 - rust_begin_unwind
7: 0x56425600f35c - core::panicking::panic_fmt::h95972081a9687957
8: 0x564255cbf45d - core::result::unwrap_failed::ha4f2c75023e5c7ce
9: 0x564255cfdd39 - std::sys_common::backtrace::__rust_begin_short_backtrace::h819b86f79c11bf64
10: 0x564255d67fd6 - std::panicking::try::do_call::h66a359d212c25c0c
11: 0x564255ff6c19 - __rust_maybe_catch_panic
12: 0x564255c80162 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h3cb62f246f8451fe
13: 0x564255fd95ae - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h0b2a0328ad02bb86
14: 0x564255fe083f - std::sys_common::thread::start_thread::h869c6ac888fae25c
15: 0x564255fdd1e5 - std::sys::unix::thread::Thread::new::thread_start::hf6aa6b468a284b27
16: 0x7f32292f5ef6 - start_thread
17: 0x7f322901522e - __GI___clone
18: 0x0 - <unknown>
This makes me unable to log in unless I have a secret service running to store my password. I reported this a couple days ago in the Matrix channel. I'm noticing this because I tried to update Fractal on NixOS, for which @worldofpeace meanwhile opened a PR (https://github.com/NixOS/nixpkgs/pull/65610).
I'm able to log in just fine with version 4.0.0, so this is a regression.