Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • F folks
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 87
    • Issues 87
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • folks
  • Merge requests
  • !25

Linking: use key-file store instead of primary store

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julian Sparber requested to merge Community/Purism/folks:linking into master Oct 18, 2019
  • Overview 3
  • Commits 2
  • Pipelines 4
  • Changes 3

Folks currently adds a persona to the primary store when it links together personas via Folks.IndividualAggregator.link_personas. There are a couple of problems with it:

  • The PersonaStore may not allow adding a new persona (especially without certain properties) e.g using Nextcloud via eds
  • We show a "ghost" contact to the user, he could modify/delete from other clients e.g Evolution
  • We can't safely remove the created persona because we can't be sure that the it wasn't modified outside our control. (currently it's not removed)
  • The new created persona can be stored in a completely different location then all other personas of the individual.

This tries to fix the issue by using the key-file store which is a location controlled by us and not exposed to the user and therefore he can't modify the persona (except obviously changing the file where we store the personas). This way we want ever create personas which are messing up the user's contact list.

Related to: gnome-contacts#145

Edited Oct 18, 2019 by Julian Sparber
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: linking