Skip to content

Fix use-after-free in error message reporting

Badel2 requested to merge Badel2/file-roller:Badel2-master-patch-58488 into master

archive_error_string (a) must be called before archive_read_free (a) so that _g_error_new_from_archive_error can copy the error string. Otherwise load_data->error is set to "Fatal error" or gibberish instead of the proper error message

Steps to reproduce: try to open an encrypted 7z file.

Before:

Captura_de_pantalla_de_2021-02-22_22-47-55

After:

Captura_de_pantalla_de_2021-02-22_23-51-07

Merge request reports