ChangeLog 422 KB
Newer Older
Chris Toshok's avatar
Chris Toshok committed
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37
2002-04-18  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-ldap.c (get_ldap_library_info): fix
	memory leaks.

	* gui/component/GNOME_Evolution_Addressbook.oaf.in: remove the
	Addressbook_ConfigControl stuff to LDAP_ConfigControl.

	* gui/component/Makefile.am (evolution_addressbook_SOURCES):
	remove addressbook-config.* and add ldap-config.*
	(glade_DATA): same.
	(evolution_addressbook_LDADD): add LDAP_LIBS.

	* gui/component/addressbook-component.c (owner_set_cb):
	addressbook_config_register_factory =>
	ldap_config_register_factory.

	* gui/component/addressbook.c (book_open_cb): remove source->type
	check - they're always LDAP.
	(load_uri_cb): same.

	* gui/component/addressbook-storage.c (ldap_unparse_ssl): new
	function.
	(ldap_parse_ssl): new function.
	(addressbook_storage_init_source_uri): use a more flexible scheme
	to build up the uri's, and add in the ssl parameter.
	(load_source_data): fill in source->ssl, and remove source->type
	assignment.
	(addressbook_source_copy): copy source->ssl, and remove
	source->type copy.
	(create_ldap_folder): addressbook_create_new_source =>
	ldap_config_create_new_source.

	* gui/component/addressbook-storage.h: remove
	AddressbookSourceType (it was always LDAP), and add
	AddressbookLDAPSSLType.

38 39 40 41 42 43 44 45 46
2002-04-18  Dan Winship  <danw@ximian.com>

	* backend/ebook/e-book-util.c (e_book_load_default_book): Append
	/addressbook.db to the end of the default URI if it starts with
	file:

	* backend/ebook/e-book.c (e_book_load_uri_step): Fix this to not
	loop forever if you have more than one backend.

47 48 49 50 51 52 53 54 55 56 57 58
2002-04-17  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/select-names/e-select-names.c
	(e_select_names_create_categories): Changed this to use
	ECategoriesMasterListOptionMenu.

	* gui/component/select-names/e-select-names.c
	(section_right_click_cb),
	gui/widgets/e-addressbook-reflow-adapter.c,
	gui/widgets/e-addressbook-view.c: Updated these to match the new
	EPopupMenu.

59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
2002-04-11  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/addressbook-component.c: Include
	addressbook-config.h here as this file uses it.

	* gui/component/select-names/e-select-names.c (SPEC, SPEC2): Made
	this dialog searchable by typing in the ETable.

	* gui/widgets/e-addressbook-model.c: Include e-addressbook-util.h
	here.

	* gui/widgets/e-addressbook-reflow-adapter.c
	(e_addressbook_reflow_adapter_right_click),
	gui/widgets/e-addressbook-view.c (table_right_click): Fixed a
	memory leak here by using "selection-done" signal.

	* gui/widgets/e-addressbook-reflow-adapter.c,
	gui/widgets/e-addressbook-reflow-adapter.h,
	gui/widgets/e-addressbook-view.c, gui/widgets/e-minicard-view.c:
	Added a right click menu for areas that aren't cards.

80 81 82 83 84 85 86 87 88 89 90
2002-04-09  Dan Winship  <danw@ximian.com>

	* backend/ebook/e-book-util.c (e_book_load_default_book): Update
	for new-and-improved consistent default folder uri.

	* gui/component/addressbook.c (addressbook_load_default_book): Use
	e_book_load_default_book rather than duplicating most of its logic
	here.
	(load_uri_cb): Modify to work as a callback for
	addressbook_load_default_book as well as addressbook_load_uri.

91 92 93 94 95
2002-04-08  Dan Winship  <danw@ximian.com>

	* gui/component/addressbook-component.c (create_view): Add
	view_info arg, but don't do anything with it.

JP Rosevear's avatar
JP Rosevear committed
96 97 98 99 100
2002-04-06  JP Rosevear  <jpr@ximian.com>

	* gui/component/GNOME_Evolution_Addressbook.oaf.in: add
	config_item:type

101 102 103 104
2002-04-04  JP Rosevear  <jpr@ximian.com>

	* conduit/Makefile.am: link to the static libversit

105 106 107 108 109
2002-04-04  Dan Winship  <danw@ximian.com>

	* gui/widgets/e-addressbook-util.c (e_addressbook_transfer_cards):
	Update for evolution_shell_client_user_select_folder API change.

110 111 112 113 114 115 116 117 118
2002-04-04  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/addressbook.c: Remove AddressbookConfig,
	ContactNew, ContactNewList EPixmap entries.

	* gui/component/addressbook-factory.c (main): Print out a
	debugging message just before the main loop starts, for debugging
	purposes.

119 120 121 122 123 124 125 126 127 128
2002-04-02  Dan Winship  <danw@ximian.com>

	* backend/ebook/e-card-simple.h: Fix spelling of
	E_CARD_SIMPLE_PHONE_ID_TTYTDD and E_CARD_SIMPLE_FIELD_PHONE_TTYTDD
	(they previously ended with "TTD" instead of "TDD")

	* backend/ebook/e-card-simple.c: Update for spelling fix.

	* backend/pas/pas-backend-ldap.c: Likewise

129 130 131 132 133
2002-04-01  Dan Winship  <danw@ximian.com>

	* gui/component/select-names/e-select-names-text-model.c:
	parent_class should be static. (From Max Horn <max@quendi.de>)

134 135 136 137 138
2002-03-29  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/GNOME_Evolution_Addressbook.oaf.in: Add priority
	for the config page.  Renamed to "Directory Servers".

139 140 141 142 143 144 145 146 147 148 149 150
2002-03-27  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-file.c
	(pas_backend_file_process_create_card): don't free req->vcard.
	it's freed in pas_book_free_request.
	(pas_backend_file_process_remove_card): don't free req->id for the
	same reason.
	(pas_backend_file_process_modify_card): don't free req->vcard for
	the same reason.
	(pas_backend_file_process_get_changes): don't free req->change_id
	or release_unref the listener for the same reason.

151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167
2002-03-27  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-ldap.c (check_schema_support): make sure
	to call ldap_value_free (values);, and ldap_msgfree (resp).
	(get_ldap_library_info): don't ask me why, but it appears we have
	to free each extension char*.
	(query_ldap_root_dse): make sure to free values in the
	subschemaSubentry code before overwriting it, and call
	ldap_msgfree(resp) when we're all done.
	(build_card_from_entry): don't leak the DN, ldap attributes, or
	the berval the ldap_*_attribute calls use to step through the
	attributes.  the docs say this berval is freed when
	ldap_next_attribute returns NULL, but if we don't free it it leaks
	a substantial amount of memory.
	(pas_backend_ldap_search): make sure to only allocate *op once,
	and fix the g_warning since op isn't valid in its scope anymore.

168 169 170 171 172 173 174 175 176
2002-03-19  Dan Winship  <danw@ximian.com>

	* backend/ebook/Makefile.am: Update for libversit change: Use .a
	rather than .la now.

	* printing/Makefile.am: Likewise

	* gui/component/Makefile.am: Likewise

177 178 179 180 181 182 183 184
2002-03-18  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/addressbook.c (addressbook_menu_activated):
	Removed.
	(addressbook_factory_new_control): Don't connect anymore, as this
	signal has been removed from the ESearchBar.
	(addressbook_factory_new_control): No more custom menu items here.

185 186 187 188 189 190 191 192 193 194 195 196
2002-03-15  Jeffrey Stedfast  <fejj@ximian.com>

	* gui/widgets/e-addressbook-view.c (table_right_click): Update to
	use new EPopupMenu API.

	* gui/widgets/e-addressbook-reflow-adapter.c
	(e_addressbook_reflow_adapter_right_click): Update to use new
	EPopupMenu API.

	* gui/component/select-names/e-select-names.c
	(section_right_click_cb): Update to match new EPopupMenu api.

197 198 199 200 201 202 203
2002-03-15  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/addressbook.c: Remove the
	`addressbook_search_menu_items'.
	(addressbook_menu_activated): Removed.
	(addressbook_factory_new_control): Don't connect.  No menu items.

204 205 206 207 208
2002-03-15  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/addressbook.c (control_activate): Call
	`e_search_bar_set_ui_component()' to set the BonoboUIComponent for
	the search bar.
209 210 211 212

	* gui/component/GNOME_Evolution_Addressbook.oaf.in: Add an icon
	for the LDAP sources configuration control.

213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251
2002-03-12  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/addressbook.c: Remove verb "AddressbookConfig".
	(config_cb): Removed.

	* gui/component/addressbook-config.c: Remove `dialog' member from
	`AddresbookDialog'.  Instead, add a `config_control' member.
	(config_control_new): New.
	(addressbook_config): Removed.
	(addressbook_config_register_factory): New.
	(config_control_factory_fn): New, factory function for the
	ConfigControl page.
	(addressbook_source_edit_changed): Don't change the sensitivity of
	the dialog.  Rather, invoke ::changed on the ConfigPage.
	(auth_checkbutton_changed): No need to manually change the
	sensitiviness of the buttons here either.
	(add_source_clicked): Likewise, just invoke
	evolution_config_control_changed().
	(edit_source_clicked): Likewise.
	(addressbook_dialog_close): Removed.
	(config_control_destroy_callback): New, callback for when the
	config control gets destroyed.
	(addressbook_dialog_apply): Removed.
	(config_control_apply_callback): New callback for
	EvolutionConfigControl::apply.
	(addressbook_dialog_ok): Removed.
	(addressbook_config_control_new): Set up ->config_control and
	connect the signals.

	* gui/component/addressbook-config.glade: Call the main hbox in
	the addressbook_sources dialog `addressbook_sources_main_hbox'.

	* gui/component/addressbook-component.c (owner_set_cb): Call
	`addresbook_config_register_factory'.

	* gui/component/GNOME_Evolution_Addressbook.oaf.in: Add items for
	OAFIID:GNOME_Evolution_Addresbook_ConfigControl and
	OAFIID:GNOME_Evolution_Addressbook_ConfigControlFactory.

252 253 254 255 256 257 258
2002-03-11  Chris Toshok  <toshok@ximian.com>

	* gui/component/select-names/e-select-names.c (update_query):
	change contains x-evolution-any-field to beginswith on email,
	full_name, and nickname.  faster, and more applicable to this
	dialog.

259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281
2002-03-09  Chris Toshok  <toshok@ximian.com>

	* backend/idl/addressbook.idl: add TLSNotAvailable to
	BookLister_CallStatus.

	* backend/ebook/e-book-types.h: add TLS_NOT_AVAILABLE to the EBookStatus enum.

	* backend/ebook/e-book-listener.c
	(e_book_listener_convert_status): add TLS_NOT_AVAILABLE to the
	switch.

	* backend/pas/pas-backend-ldap.c
	(pas_backend_ldap_get_static_capabilities): fix name.
	(pas_backend_ldap_class_init): fix name.
	(pas_backend_ldap_connect): change return type to CallStatus so we
	can return different errors from here.  Also, do STARTTLS if the
	user has asked for it and the connection supports it, returning
	TLSNotAvailable (and close the connection) if they chose to
	require it.
	(pas_backend_ldap_load_uri): return pas_backend_ldap_connect.
	(func_beginswith): pull in change from evolution-1-0-branch to
	make full_name beginswith search both cn and sn.

282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304
2002-03-09  Chris Toshok  <toshok@ximian.com>

	* gui/widgets/e-addressbook-view.c (jump_to_letter): since I've
	gone ahead and made the file backend (by way of
	pas-backend-card-sexp.c) use case insensitive searches for
	beginswith, there's no need to list upper and lower case here.

	* gui/component/addressbook.c (addressbook_search_option_items):
	reorder things to put "Any field contains" at the end, since it's
	the least efficient search.  Also reorder the enum to the same
	ordering.  Change "Name contains" to "Name begins with" and change
	"Email contains" to "Email is".
	(addressbook_search_activated): change FULL_NAME to beginswith,
	and change EMAIL to is to match the labels.

	* backend/pas/pas-backend-card-sexp.c (compare_name): new
	function, so we can compare both full and family names (so
	beginswith can operate on them both.)
	(endswith_helper): use e_utf8_strstrcase here, since all the
	backends backends use case insensitive searching.
	(func_endswith): same.

2002-03-06  Chris Toshok  <toshok@ximian.com>
305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342

	* backend/pas/pas-book.c (pas_book_queue_create_card): track
	union/struct change.
	(pas_book_queue_remove_card): same.
	(pas_book_queue_modify_card): same.
	(pas_book_queue_get_cursor): same.
	(pas_book_queue_get_vcard): same.
	(pas_book_queue_authenticate_user): same.
	(pas_book_queue_get_book_view): same.
	(pas_book_queue_get_changes): same.
	(pas_book_free_request): new function - free everything we need to
	for each type of request.
	(pas_book_destroy): call pas_book_free_request here instead of
	just freeing 3 elements of the old struct.  yay plugging memleaks.

	* backend/pas/pas-book.h: make PASRequest a union and split out
	members into structs, so it's a little clearer which fields are
	used by which requests.  Also, add prototype for
	pas_book_free_request so backends can just free everything at once
	(usually in their requests_queued signal func.)

	* backend/pas/pas-backend-file.c
	(pas_backend_file_process_create_card): track struct/union change.
	(pas_backend_file_process_remove_card): same.
	(pas_backend_file_process_modify_card): same.
	(pas_backend_file_build_cards_list): same.
	(pas_backend_file_process_get_vcard): same.
	(pas_backend_file_process_get_cursor): same.
	(pas_backend_file_process_get_book_view): same.
	(pas_backend_file_process_get_changes): same.
	(pas_backend_file_process_check_connection): same.
	(pas_backend_file_process_authenticate_user): same.
	(pas_backend_file_process_get_supported_fields): same.
	(pas_backend_file_process_client_requests): case the union to the
	specific struct and pass it to the process_* functions.  also,
	call pas_book_free_request here, instead of relying on each of the
	functions to free their stuff.

343 344 345 346 347 348
2002-03-07  Dan Winship  <danw@ximian.com>

	* gui/component/addressbook-storage.c
	(addressbook_get_other_contact_storage): Update for
	evolution_storage_new() change.

349 350 351 352 353 354 355
2002-03-05  Chris Toshok  <toshok@ximian.com>

	* gui/widgets/e-minicard-view-widget.c
	(e_minicard_view_widget_realize): don't set "editable" here, as
	the way things work the backend isn't able to override a setting
	from the UI, so writable books never show up as writable.

356 357 358 359 360 361 362 363 364 365 366 367 368 369 370
2002-03-04  Chris Toshok  <toshok@ximian.com>

	[fixes bug #20871]
	* gui/component/select-names/select-names.glade: add the
	status-message label.

	* gui/component/select-names/e-select-names.h (struct
	_ESelectNames): add status_message field.

	* gui/component/select-names/e-select-names.c (status_message):
	new function, set the label's text from the message.
	(e_select_names_init): get the status-message label, and if it's
	valid, connect to the status_message signal of the
	EAddressbookModel.

371 372 373 374 375 376 377 378 379 380 381 382
2002-02-28  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-ldap.c (pas_backend_ldap_search): don't
	ref the view here, since it keeps the view alive until the search
	is over, which we don't want.  we want the view's death to cancel
	the search.  This speeds up starting new searches after one is
	already active (since switching searches actually creates a new
	book view and destroys the old one.)
	(ldap_search_dtor): remove the matching unref here.  The unref as
	it was was incorrect anyway, and caused a crash (we needed
	search_op->view, not op->view.)

383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403
2002-02-27  Chris Toshok  <toshok@ximian.com>

	[fixes bug #20690]
	* backend/pas/pas-backend-ldap.c (func_and): the data arg is not
	GList** anymore, it's PASBackendLDAPSExpData*, so use
	ldap_data->list instead of *list.
	(func_or): same.
	(func_not): same.
	(func_contains): same.
	(func_is): same.
	(func_endswith): same.
	(func_beginswith): same, but also special case the beginswith
	"fileAs" query type (the one used by the alphabet buttons on the
	right hand side, so we can deal with entries that don't have
	fileAs attributes, and return meaningful responses.)
	(pas_backend_ldap_build_query): initialize the
	PASBackendLDAPSExpData struct and pass that instead of &list.
	Also, take the PASBackendLDAP arg to add to the struct in case we
	need it at some point in the future.
	(ldap_search_handler): pass in the PASBackendLDAP.

404 405 406 407 408 409
2002-02-26  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-file.c (pas_backend_file_search): move
	card_count++ inside the if that checks to see if a card matches
	(and adds the card to the list).

410 411 412 413 414 415 416 417 418 419
2002-02-24  Chris Toshok  <toshok@ximian.com>

	* gui/component/addressbook.c (addressbook_query_changed): only
	handle the ESB_ADVANCED case here now.  the actual query work is
	done in addressbook_search_activated.
	(addressbook_search_activated): split out all the searching
	functionality here.
	(addressbook_factory_new_control): hook up "search_activated" to
	addressbook_search_activated.

420 421 422 423 424 425 426 427 428 429
2002-02-24  Chris Toshok  <toshok@ximian.com>

	* gui/component/addressbook-config.c
	(addressbook_source_dialog_set_source): make the right auth page
	start up open.

	* gui/component/addressbook-storage.c (addressbook_source_free):
	free the binddn.
	(addressbook_source_copy): copy the binddn;

430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471
2002-02-22  Chris Toshok  <toshok@ximian.com>

	[ Fixes bugs 20740, 16680, and god knows what else :) ]
	* gui/widgets/e-addressbook-model.c (create_card): double the
	allocated size every time we need more space instead of using a
	fixed size increment.  this helps huge queries.  Also, remove the
	gtk_object_get of "file_as", as it was dead code.
	(book_view_loaded): handle errors here (by popping up a dialog).

	* backend/pas/pas-backend-ldap.c (view_destroy): search_idle ->
	search_timeout.
	(build_card_from_entry): comment out some spew, and unref ecard
	when we're done to plug a memory leak.
	(send_pending_adds): send along to the client all the cards we've
	been saving up.
	(poll_ldap): use a timeout for ldap_result to keep the backend
	from blocking (and it turns out keep the frontend from hanging
	waiting on a ref to complete) on large db's with few matches.

	Also, add some fairly smart, self-tuning aggregating of cards.
	Keep track of the number of cards we've sent the last time through
	as well as this time, and estimate the number we want to aggregate
	the next time based on them (we average them at the moment),
	subject to maximum/minimum number of cards.  also, we have a
	maximum aggregation time, after which we force a flush if there
	are pending cards and recalculate our target pending number.
	there's a minimum wait time to possibly keep outselves from
	spamming the ui, although it's 0 at the moment.

	Lastly, make sure to only notify the GUI of status messages when
	we need to.  this results in a *huge* savings.
	(ldap_search_handler): initialize all the pending card stuff, and
	use a timeout instead of an idle function for poll_ldap.

	* backend/ebook/e-book-view-listener.c
	(e_book_view_listener_queue_response): performance optimization
	for large adds.  If we're a CardAddedEvent and there's an existing
	CardAddedEvent at the end of the queue, just concat the lists of
	cards together.  This is to keep the gui from falling further and
	further behind the ldap backend, which is merrily spewing updates
	at the gui.

Ettore Perazzoli's avatar
Ettore Perazzoli committed
472 473 474 475 476 477 478 479 480
2002-02-21  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/Makefile.am: Define $(iconsdir).

	* gui/component/addressbook-component.c (add_creatable_item): New
	helper function.
	(create_component): Add the icons for the user creatable items as
	well.

481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511
2002-02-20  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-file.c (pas_backend_file_load_uri):
	track change to signature, and (for now) just change all the
	return FALSE's to _RepositoryOffline (what FALSE used to map to in
	pas_book_factory_process_request), and change TRUE to _Success.

	* backend/pas/pas-backend-ldap.c (pas_backend_ldap_load_uri):
	track change to signature, and differentiate between
	pas_backend_ldap_connect failing (RepositoryOffline), and
	ldap_url_parse failing (OtherError).
	
	* backend/pas/pas-book-factory.c
	(pas_book_factory_process_request): since pas_backend_load_uri
	returns status now, use it to nodify the BookListener if there's a
	failure.

	* backend/pas/pas-backend.c (pas_backend_load_uri): track change
	to signature.

	* backend/pas/pas-backend.h: change return type of
	pas_backend_load_uri to
	GNOME_Evolution_Addressbook_BookListener_CallStatus to allow
	differentiation between failure types.

	* backend/ebook/e-book-listener.c
	(e_book_listener_convert_status): handle _AUTHENTICATION_FAILED.

	* backend/ebook/e-book-types.h (EBookStatus): add
	_AUTHENTICATION_FAILED.

512 513 514 515 516 517 518
2002-02-18  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-book-factory.c
	(pas_book_factory_process_request): if the load_uri fails, notify
	the listener that the repository is offline.  (partial fix for bug
	20347)

519 520 521 522 523 524 525
2002-02-18  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-ldap.c (create_dn_from_ecard): escape
	commas in the dn, since they're used by ldap to specify the node's
	placement in the tree. (fixes bug 20089)
	(rfc2254_escape): just use sprintf and %02X instead.

526 527 528 529 530
2002-02-13  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/select-names/e-select-names.c (set_book): Keep a
	ref of the model in this case as well.

531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546
2002-02-13  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/select-names/e-select-names.c (set_book): Make
	sure to only set the query once when creating a new book and not
	at all on addressbook model creation.  This prevents an accidental
	pair of changes from making the addressbook model load a remote
	addressbook.

	* gui/widgets/e-addressbook-model.c (get_view): If this is the
	first_get_view and the addressbook is remote, empty the view
	instead of leaving it in the state it used to be in.  This only
	occurs if you set the book after the model has existed for a
	while.
	(e_addressbook_model_set_arg): When setting the book, set
	first_get_view to TRUE.

547 548 549 550 551 552 553 554 555 556 557 558 559 560
2002-02-13  Christopher James Lahey  <clahey@ximian.com>

	* gui/widgets/e-addressbook-view.c (display_view): Attach to the
	emvw instead of the emv here.

	* gui/widgets/e-minicard-view-widget.c, e-minicard-view-widget.h:
	Made this object have a "column_width" argument and a
	"column_width_changed" signal which are a simple layer down to the
	EMinicardView contained within.

	* gui/widgets/gal-view-minicard.c, gui/widgets/gal-view-minicard.h
	(gal_view_minicard_attach): Made this attach to an
	EMinicardViewWidget instead of a EMinicardView.

561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607
2002-02-13  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-book-util.c, backend/ebook/e-book-util.h
	(e_book_expand_uri, e_book_load_address_book_by_uri,
	e_book_use_address_book_by_uri): New functions that take a file://
	url ending in the directory name and automatically append the
	addressbook.db and do the appropriate thing.

	* backend/pas/pas-backend-card-sexp.c,
	backend/pas/pas-backend-card-sexp.h: Added copyright notice here.

	* gui/component/addressbook-component.c
	(destination_folder_handle_drop), gui/component/addressbook.c
	(set_prop): Use e_book_expand_uri instead of
	addressbook_expand_uri.

	* gui/component/addressbook-storage.c: Fixed the fcntl include
	here.

	* gui/component/addressbook.c (ContactsCopyToFolder,
	ContactsMoveToFolder): Added handlers for these two verbs.

	* gui/component/addressbook.h: Removed addressbook_expand_uri in
	favor of e_book_expand_uri.

	* gui/widgets/e-addressbook-reflow-adapter.c (transfer_cards):
	Added code to handle Move to and Copy to right click menu items.

	* gui/widgets/e-addressbook-util.c,
	gui/widgets/e-addressbook-util.h (e_addressbook_transfer_cards):
	New function to pop up a dialog and transfer a set of cards to the
	given folder.

	* gui/widgets/e-addressbook-view.c,
	gui/widgets/e-addressbook-view.h (display_view): Don't attach to
	the view if it doesn't exist yet.  We have to make this then
	attach later.
	(e_addressbook_view_copy_to_folder,
	e_addressbook_view_move_to_folder): New functions utilizing
	e_addressbook_transfer_cards.
	(table_right_click): Add copy_to_folder and move_to_folder to the
	right click menu for tables here.
	(e_addressbook_view_discard_menus): Handle menu unmerging here.

	* gui/widgets/e-minicard-view-widget.h (struct
	_EMinicardViewWidget): Removed unused field.

608 609 610 611 612 613 614 615 616 617 618 619
2002-02-13  Christopher James Lahey  <clahey@ximian.com>

	* gui/widgets/e-addressbook-view.c (display_view): Attach the
	GalViewMinicard to the EMinicardView here.

	* gui/widgets/gal-view-minicard.c, gui/widgets/gal-view-minicard.h
	(gal_view_minicard_load, gal_view_minicard_save): Made these save
	the column width of the view.
	(gal_view_minicard_attach, gal_view_minicard_detach): Added these
	functions to allow the GalViewMinicard to set the column width of
	a EMinicardView and to monitor its changes.

620 621 622 623 624 625 626 627 628 629 630 631
2002-02-12  Christopher James Lahey  <clahey@ximian.com>

	* gui/widgets/e-addressbook-reflow-adapter.c
	(addressbook_get_arg): Added an argument to get the model.

	* gui/widgets/e-addressbook-view.c (writable_status): Don't bother
	connecting to the writable_status callback on the book, simply
	rely on the writable_status callback on the addressbook model.

	* gui/widgets/e-minicard-view.c, gui/widgets/e-minicard-view.h
	(set_empty_message): Handle the case of a read only view here.

632 633 634 635 636
2002-02-07  JP Rosevear  <jpr@ximian.com>

	* gui/component/addressbook-component.c (create_component): remove
	"New" from user creatable menu items

637 638
2002-02-07  Christopher James Lahey  <clahey@ximian.com>

Chris Lahey's avatar
Chris Lahey committed
639 640
	* gui/widgets/e-addressbook-view.c,
	gui/widgets/e-addressbook-view.h
641 642 643 644
	(e_addressbook_view_setup_menus): Changed this function to use the
	new GalViewMenus which takes a GalViewInstance, instead of a
	GalViewCollection.

645 646
2002-02-04  JP Rosevear  <jpr@ximian.com>

JP Rosevear's avatar
JP Rosevear committed
647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666
	* gui/contact-editor/e-contact-editor.c (find_address_mailing): tidy

	* conduit/address-conduit.c (addrconduit_load_configuration): load
	default address setting
	(addrconduit_save_configuration): save default address setting
	(e_addr_gui_new): new gui routine for conduit settings
	(e_addr_gui_fill_widgets): ditto
	(e_addr_gui_fill_config): ditto
	(e_addr_gui_destroy): ditto
	(e_addr_context_destroy): destroy the gui and new_cfg
	(local_record_from_ecard): reinstate commented out bits, determine
	which address to sync to pilot
	(ecard_from_remote_record): determine which address to sync from
	pilot
	(fill_widgets): put the gui widgets in
	(create_settings_window): create gui
	(save_settings): fill gui

2002-02-04  JP Rosevear  <jpr@ximian.com>
	
667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682
	* gui/contact-editor/e-contact-editor.c (address_text_changed): if
	the shown address in the mailing address or there is no mailing
	address, set the default flag and make sure the button is checked
	(address_mailing_changed): set the flags properly when the mailing
	address changes
	(e_contact_editor_init): listen for the check button being toggled
	(find_address_mailing): find the address (if any) with the default
	flag
	(set_address_field): set the mailing address button appropriately
	(fill_in_info): find the mailing address

	* gui/contact-editor/e-contact-editor.h: add new class data member

	* gui/contact-editor/contact-editor.glade: show mailing address
	check button

683 684 685 686 687 688 689 690 691 692 693 694 695 696 697
2002-02-01  Jeffrey Stedfast  <fejj@ximian.com>

	* backend/ebook/e-destination.c (e_destination_is_auto_recipient):
	New function to find out if a destination was one which was
	auto-matically set by Evolution.
	(e_destination_set_auto_recipient): Set whether or not the dest is
	an auto-recipient.
	(e_destination_touch): Don't touch the address if it is an
	auto_recipient.
	(e_destination_list_to_vector_sized): New function to avoid having
	to calculate the length of the list ourselves. Allows for a bit of
	optimization if our caller knows the length of the list.
	(e_destination_xml_encode): Encode the auto_recipient bit.
	(e_destination_xml_decode): Decode the auto_recipient bit.

698 699 700 701 702 703 704 705 706 707 708 709 710
2002-02-01  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card-simple.c (e_card_simple_sync_card): Made
	this preserve addressbook flags other than the first three.

	* backend/ebook/e-card-types.h: Added E_CARD_ADDR_MASK and
	E_CARD_ADDR_DEFAULT.

	* backend/ebook/e-card.c (get_address_flags): Added "PREF" to
	E_CARD_ADDR_DEFAULT mapping.

	* backend/ebook/test-client.c: Added #include "e-book-util.h".

711 712 713 714 715 716 717 718 719
2002-01-30  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-file.c (pas_backend_file_changes):
	compute the change db filename based on our contact db filename.
	(pas_backend_file_load_uri): store the filename in
	bf->priv->filename.
	(pas_backend_file_destroy): free the filename, and (!) free
	bf->priv too.

720 721 722 723 724 725
2002-01-28  Jeffrey Stedfast  <fejj@ximian.com>

	* backend/ebook/e-destination.c (e_destination_is_valid): Revert
	my previous change as trow says this will break auto-completion
	stuff.

726 727 728 729 730 731 732 733
2002-01-27  Ettore Perazzoli  <ettore@ximian.com>

	* gui/contact-editor/Makefile.am: Use EVOLUTION_ADDRESSBOOK_CFLAGS.
	* gui/contact-list-editor/Makefile.am: Likewise.
	* gui/merging/Makefile.am: Likewise.
	* gui/search/Makefile.am: Likewise.
	* gui/component/select-names/Makefile.am: Likewise.

734 735 736 737 738
2002-01-25  Jeffrey Stedfast  <fejj@ximian.com>

	* backend/ebook/e-destination.c (e_destination_is_valid): Don't
	check for an @ in the email address. This is to fix bug #10960.

739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796
2002-01-24  Chris Toshok  <toshok@ximian.com>

	[ fixes bug 16097 ]
	* gui/component/addressbook-config.glade: gui love for the new
	auth stuff.
	
	* gui/component/addressbook.c (load_uri_cb): track change to auth,
	and offer up different prompt strings depending on which method
	(binddn or email) we're using.
	
	* gui/component/addressbook-storage.c (ldap_unparse_auth): use the
	new auth types for ldap.
	(ldap_parse_auth): same.
	(addressbook_storage_auth_type_to_string): new function.
	(load_source_data): get the binddn too.
	(ldap_source_foreach): store out binddn or emailaddr, depending on
	the auth type chosen.

	* gui/component/addressbook-storage.h: add the more detailed auth
	types, add "binddn" to the source structure, and add a prototype
	for addressbook_storage_auth_type_to_string.
	
	* gui/component/addressbook-config.c (auth_checkbutton_changed):
	set the auth stuff  (in)sensitive.
	(auth_optionmenu_activated): new function.
	(addressbook_source_dialog_set_source): track UI change.
	(addressbook_source_dialog_get_source): same.
	(add_scope_activate_cb): rename add_activate_cb to this to
	distinguish it from the auth stuff.
	(add_auth_activate_cb): new function.
	(addressbook_source_dialog): track change to auth UI stuff.
	(addressbook_storage_auth_type_to_string): new function.

	* backend/ebook/e-book.h: add auth_method arg to
	e_book_authenticate_user.

	* backend/ebook/e-book.c (e_book_authenticate_user): track change
	to prototype - add auth_method arg, and pass it along to the CORBA
	call.

	* backend/ebook/test-client.c (book_open_cb): track api change -
	keep this building.

	* backend/pas/pas-book.h: add auth_method slot in PASRequest.

	* backend/pas/pas-book.c (pas_book_queue_authenticate_user): add
	auth_method arg and add it to the PASRequest.
	(impl_GNOME_Evolution_Addressbook_Book_authenticateUser): track
	idl change, add auth_method and pass it along to
	pas_book_queue_authenticate_user.

	* backend/pas/pas-backend-ldap.c
	(pas_backend_ldap_process_authenticate_user): support both
	"ldap/simple-email" and "ldap/simple-binddn" auth methods.

	* backend/idl/addressbook.idl: add "in string authMethod" to
	authenticateUser.

797 798 799 800 801 802 803 804 805 806 807 808 809
2002-01-24  Ettore Perazzoli  <ettore@ximian.com>

	* conduit/Makefile.am: Use EVOLUTION_ADDRESSBOOK_CONDUIT_CFLAGS
	and EVOLUTION_ADDRESSBOOK_CONDUIT_LIBS and remove unused flags

	* gui/component/Makefile.am: Use EVOLUTION_ADDRESSBOOK_CFLAGS and
	EVOLUTION_ADDRESSBOOK_LIBS and remove unused flags.
	* backend/pas/Makefile.am: Likewise.
	* backend/ebook/Makefile.am: Likewise.
	* printing/Makefile.am: Likewise.
	* backend/ebook/Makefile.am: Likewise.
	* gui/widgets/Makefile.am (INCLUDES): Likewise.

Ettore Perazzoli's avatar
Ettore Perazzoli committed
810 811 812 813 814 815
2002-01-23  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/addressbook-component.c (create_component): Pass a
	NULL @icon to
	`evolution_shell_component_add_user_creatable_item()'.

Ettore Perazzoli's avatar
Ettore Perazzoli committed
816 817 818 819 820
2002-01-23  Ettore Perazzoli  <ettore@ximian.com>

	* gui/contact-editor/e-contact-editor-address.c: #include
	<locale.h>.

821 822 823 824 825 826 827
2002-01-22  Chris Toshok  <toshok@ximian.com>

	[ fixes bug # 16864 ]
	* backend/ebook/evolution-ldif-importer.c (getValue): create and
	return a GString here, instead of writing to a fixed size buffer.
	(parseLine): use a GString here instead of a fixed size buffer.

828 829 830 831 832 833 834 835 836 837 838 839 840 841 842
2002-01-21  Christopher James Lahey  <clahey@ximian.com>

	* backend/pas/pas-backend-ldap.c (ldap_search_handler): Set the
	number of cards to return to the value specified in the ldap uri,
	leaving the default at 100.  Fixes Ximian bug #13953.

	* gui/component/addressbook-config.c (addressbook_source_dialog),
	gui/component/addressbook-config.glade: Added a limit entry here
	to edit the limit field of the source.

	* gui/component/addressbook-storage.c,
	gui/component/addressbook-storage.h
	(addressbook_storage_init_source_uri): Added a limit field to this
	class and pass that value through in the uri that's generated.

843 844 845 846 847 848
2002-01-18  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card-compare.c: Made username match with no
	domain match be vague instead of partial.  Fixes Ximian bug
	#13612.

849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867
2002-01-18  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/addressbook.c (view_contact_cb): New verb to open
	a bunch of cards.

	* gui/widgets/e-addressbook-reflow-adapter.c (open_card): Call
	e_addressbook_show_multiple_cards instead of doing this ourselves.

	* gui/widgets/e-addressbook-util.c,
	gui/widgets/e-addressbook-util.h
	(e_addressbook_show_multiple_cards): Added this function to show a
	bunch of cards, including a dialog if lots of windows are going to
	appear.

	* gui/widgets/e-addressbook-view.c (e_addressbook_view_view,
	e_addressbook_view_can_view): e_addressbook_view_view calls
	e_addressbook_show_multiple_cards on the appropriate list of
	cards.

868 869 870 871 872 873 874 875
2002-01-18  Christopher James Lahey  <clahey@ximian.com>

	* gui/contact-editor/e-contact-editor-address.c
	(fill_in_countries), gui/contact-editor/fulladdr.glade: Sort
	country list.  Country list moves from fulladdr.glade to
	e-contact-editor-address.c, but only a few country names have
	actually changed.  Fixes Ximian bug #16545.

Zbigniew Chyla's avatar
Zbigniew Chyla committed
876 877 878 879 880 881 882 883
2001-12-20  Zbigniew Chyla  <cyba@gnome.pl>

	Fixes #17725

	* evolution/addressbook/printing/e-contact-print.c (complete_sequence):
	Do not assume that the first byte of file_as is the first letter, use
	utf8 functions instead.

884 885 886 887 888
2002-01-16  JP Rosevear  <jpr@ximian.com>

	* conduit/address-conduit.c: move all functions here, get rid of
	header files, use e-pilot-settings to display gui

889 890 891 892 893
2002-01-15  JP Rosevear  <jpr@ximian.com>

	* gui/component/select-names/select-names.glade: remove misleading
	title and fix spacing

894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910
2002-01-11  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/addressbook.c (alphabet_state_changed): Handle
	setting the search bar to "Advanced..." when the alphabet buttons
	are pushed and back when they're cleared.  Fixes Ximian bug
	#12904.
	(addressbook_menu_activated): When the user calls Search->clear,
	set the search to ESB_ANY and "", don't just set the text.  This
	is especially useful when it's set to ESB_ADVANCED.

	* gui/widgets/e-addressbook-view.c,
	gui/widgets/e-addressbook-view.h (alphabet_state_change): Added
	this signal which gets emitted when the alphabet buttons are
	pushed.
	(command_state_change): Removed the ref pair here.  It's not
	necessary.  gtk_signal_emit refs the object itself.

911 912 913 914 915 916 917 918 919
2002-01-11  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card-compare.c (name_synonyms): Added a couple
	of names here.

	* gui/component/select-names/e-select-names-text-model.c
	(e_select_names_text_model_get_nth_obj): Removed an unused
	variable.

920 921 922 923
2002-01-11  Christopher James Lahey  <clahey@ximian.com>

	* gui/widgets/e-addressbook-view.c,
	gui/widgets/e-addressbook-view.h (create_alphabet): Use toggle
Chris Lahey's avatar
Chris Lahey committed
924
	buttons here.  Fixes Ximian bug #10734.
925

926 927 928 929 930
2002-01-09  Christopher James Lahey  <clahey@ximian.com>

	* gui/contact-editor/e-contact-editor.c (set_fields): Choose the
	first filled in address field here.  Fixes Ximian bug #2222.

931 932 933 934 935 936 937 938 939 940 941 942 943
2002-01-03  Joe Shaw  <joe@ximian.com>

	* backend/ebook/test-card.c: Add a test for getting arbitrary
        fields.

	* backend/pas/pas-backend-card-sexp.c (compare_arbitrary): Added.
	(prop_info_table): Add a LIST_PROP for arbitrary fields.

2002-01-03  Nat Friedman  <nat@ximian.com>

	* backend/ebook/e-book.c (activate_factories_for_uri): Free the
	query if the oaf response is of zero length.

944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028
2001-12-27  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names.c
	(real_add_address_cb): When we clean, don't clean the model's last
	element.  This helps keep things working properly when we have
	signal-character separators.
	(section_right_click_cb): Changed to work properly with our
	EText-emitted popup signal.
	(e_select_names_add_section): Use ETexts for the recipient
	sections, rather than tables.  This lets us make them directly
	editable. (Bug #1721)

	* gui/component/select-names/e-select-names-popup.c
	(popup_info_new): Pass in a ESelectNamesTextModel, not a
	ESelectNamesModel.
	(e_select_names_popup): Adjust for the new signature for
	e_select_names_model_text_pos.

	* gui/component/select-names/e-select-names-manager.c
	(focus_out_cb): Schedule a cleaning when we focus out.
	(focus_in_cb): Cancel pending cleaning when we get focus.  This
	helps us avoid bad things happening during the fast focus out/ins
	that happen when the completion dropdown appears.
	(completion_handler): Adjust for new signatures of
	e_select_names_model_text_pos and e_select_names_model_name_pos.
	(e_select_names_manager_entry_new): Pass in our
	ESelectNamesTextModel when constructing the
	ESelectNamesCompletion.
	(e_select_names_manager_entry_free): Cancel any pending clean-ups.

	* gui/component/select-names/e-select-names-bonobo.c
	(entry_get_property_fn): Get the text off of the text model.
	Which is the only way that really makes sense when you think about
	it.

	* gui/component/select-names/e-select-names-completion.c: Added a
	copy of the associated ESelectNamesTextModel to
	ESelectNamesCompletionPrivate.  This replaces the
	ESelectNamesModel.
	(e_select_names_completion_destroy): Unref ->text_model.
	(e_select_names_completion_handle_request): Pass in our text
	model's separator info when calling e_select_names_model_text_pos.
	(e_select_names_completion_new): Pass in the text model as an arg
	instead of the model, and ref it as needed.

	* gui/component/select-names/e-select-names-text-model.c
	(e_select_names_text_model_init): Set separator as either ", " or
	",", depending on the value of the EVOLUTION_DISABLE_MAGIC_COMMA
	environment variable.
	(e_select_names_text_model_destroy): Free the separator.
	(changed_cb): Flush our cached text on changed.
	(e_select_names_text_model_set_source): Use our own changed_cb
	callback on changed, rather than just connecting up
	e_text_model_changed.
	(e_select_names_text_model_set_separator): Added.  Lets the
	separator between recipients be specified.
	(e_select_names_text_model_get_text): Cache the text we get from
	calling e_select_names_model_get_textification.
	(e_select_names_text_model_insert_length): A bunch of small
	changes to properly support generic separators, rather than
	(implicit and explicitly) assuming ", ".
	(e_select_names_text_model_delete): More small tweaks to handle
	generic separators.
	(e_select_names_text_model_get_nth_obj): Use new signature when
	calling e_select_names_model_name_pos, and use our cached text.

	* gui/component/select-names/e-select-names-model.c
	(e_select_names_model_destroy): We don't cache the text or
	addr_text anymore, so no need to free them here.
	(e_select_names_model_changed): ...and no need to reset our text
	and addr_text caches here.
	(e_select_names_model_get_textification): Take a separator as an
	arg, rather than just using ", ".  Also, no caching.
	(e_select_names_model_get_address_text): Take a separator as an
	arg, rather than just using ", ".  And no caching here either.
	(e_select_names_model_clean): Add arg that give us control over
	whether or not the last entry should get cleaned.  We need this
	when using a one-character separator, so that new destinations
	that get tacked onto the end don't get immediately cleaned away
	for being empty.
	(e_select_names_model_name_pos): Take the separator length as an
	argument, remove implicit assumption of length 2.
	(e_select_names_model_text_pos): Take the separator length as an
	argument, remove implicit assumption of length 2.

1029 1030 1031 1032 1033 1034 1035
2001-12-20  Ettore Perazzoli  <ettore@ximian.com>

	[Fix #17377, Evolution doesn't work on multi-depth displays.]

	* gui/component/addressbook-factory.c (main): Push GdkRGB visual
	and colormap.

1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046
2001-12-19  Jon Trowbridge  <trow@ximian.com>

	* gui/widgets/e-addressbook-reflow-adapter.c
	(e_addressbook_reflow_adapter_right_click): Add cut/copy/paste to
	right-click menu.

	* gui/widgets/e-addressbook-view.c (table_right_click): Add
	cut/copy/paste to right-click menu.  (Fixes bug #14528.)  Also,
	disable some right-click options if our addressbook isn't
	editable.

1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077
2001-12-18  JP Rosevear  <jpr@ximian.com>

	* conduit/address-conduit.c (check_for_slow_setting): go slow and
	clear the map if the last uri and the current uri do not match
	(post_sync): save the last uri

	* conduits/address-conduit-config.h: handle a last uri config
	option

2001-12-18  Chris Toshok  <toshok@ximian.com>

	* gui/component/addressbook.c (addressbook_default_book_open):
	change this to match its e-book counterpart, and only failover to
	the local addressbook if the protocol wasn't supported.  that way
	errors like "failure to connect" are still reported to the user.

	* backend/ebook/e-book-util.h: add prototypes for
	e_book_load_default_book and e_book_get_config_database.

	* backend/ebook/e-book-util.c (e_book_default_book_open): new
	function, basically cut and paste addressbook_default_book_open
	from addressbook.c here.
	(e_book_load_default_book): cut and past
	addressbook_load_default_book here, pretty much, except leave off
	the auth stuff.
	(e_book_get_config_database): new function, returns the
	Bonobo_ConfigDatabase for e_book_load_default_book to use.

	* conduit/address-conduit.c (start_addressbook_server): use
	e_book_load_default_book here.
	
1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090
2001-12-17  Chris Toshok  <toshok@ximian.com>

	[ fixes bug 17355 ]
	* gui/component/select-names/e-select-names.c (new_folder): if
	we're dealing with an LDAP folder, prepend [LDAP] to it.  Now that
	we have 3 different places where folders are coming from, it helps
	to be able to differentiate "Contacts" in ~/evolution and a
	"Contacts" ldap server and a "Contacts" exchange folder.
	(add_additional_select_names_uris): loop through the bonobo conf
	settings for additional folders, adding them to the option menu.
	(e_select_names_hookup_shell_listeners): call
	add_additional_select_names_uris.

1091 1092 1093 1094 1095 1096
2001-11-28  Christopher James Lahey  <clahey@ximian.com>
 
 	* gui/widgets/e-minicard-view-widget.c
	(e_minicard_view_widget_realize): Use an #ECanvasBackground here
	instead of a #GnomeCanvasRect.
 
1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107
2001-12-16  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names-completion.c: Added
	'cache_complete' flag to ESelectNamesCompletionPrivate.
	(e_select_names_completion_seq_complete_cb): Set cache_complete
	to TRUE if our query wasn't interrupted.
	(e_select_names_completion_start_query): Set cache_complete to
	FALSE at the beginning of a potentially-cached query.
	(e_select_names_completion_do_query): Only reuse cached cards
	if cache_complete is TRUE.  (Fixes bug #10241)

1108 1109 1110 1111 1112 1113 1114 1115 1116
2001-12-15  JP Rosevear  <jpr@ximian.com>
 
 	* conduit/address-conduit.c (e_addr_context_destroy): don't free
 	the hash table keys, we didn't allocate them and free the change
 	objects and unref the associated cards
 	(local_record_from_uid): unref the temp card we create
 	(replace_record): ref the new card associated with the card change
 	and unref the old one

1117 1118 1119 1120 1121
2001-12-13  JP Rosevear  <jpr@ximian.com>
 
 	* conduit/address-conduit.c (local_record_from_ecard): Make sure
 	to copy the custom fields so they are not overwritten

1122 1123 1124 1125 1126 1127
2001-12-13  Jon Trowbridge  <trow@ximian.com>

	* backend/ebook/e-book-util.c (simple_query_new): Used
	g_strdup_printf to dup a string.  Doh!  Changed to g_strdup.
	(Bug #17126)

1128 1129
2001-12-07  Jon Trowbridge  <trow@ximian.com>

1130 1131 1132 1133
	* gui/component/select-names/e-select-names-manager.c
	(e_select_names_manager_entry_new): Remove a reference to code
	I don't want to commit yet. :-)

1134 1135 1136 1137 1138 1139 1140 1141 1142
	* gui/component/select-names/e-select-names-manager.c: Extensively
	refactored -- this code had gotten _really_ ugly.  Untangle things
	to the point where our reference counting problems are fixable.

	* gui/component/select-names/e-select-names-bonobo.c
	(impl_destroy): Remove all of the ugly hacks to work around our
	memory management problems, and just unref the manager.
	(Fixes #14412)

1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165
2001-12-05  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-ldap.c
	(search_for_dn_with_objectclasses): move search_for_dn's contents
	here, and add an "existing_objectclasses" parameter that we pass
	on to build_card_from_entry.
	(search_for_dn): call search_for_dn_with_objectclasses with NULL
	for existing_objectclasses.
	(build_card_from_entry): if existing_objectclasses is non-NULL,
	fill it in with the list of existing objectclass values for this
	entry.
	(add_objectclass_mod): if existing_objectclasses is non-NULL,
	meaning we're modifying an entry, search in the existing
	objectclasses for the ones we want to be there, and only add
	what's missing.  If none are missing, don't add objectclass_mod to
	the list of mods.
	(create_card_handler): track change to add_objectclass_mod (pass
	NULL).
	(modify_card_handler): use search_for_dn_with_objectclasses
	instead of search_for_dn, and pass the existing objectclasses to
	add_objectclass_mod.  also, free the list when we're done.
	(poll_ldap): track change to build_card_from_entry (pass NULL).

1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183
2001-12-05  Chris Toshok  <toshok@ximian.com>

	* gui/contact-editor/e-contact-editor.c (enable_writable_fields):
	we need to be able to disable non-labels here as well.  since
	we're using enable_widget and not gtk_widget_set_sensitive, it's
	okay to handle entries/text's, etc, here.
	(widget_field_mappings): add label-caluri and label-fburl here.

	* gui/contact-editor/contact-editor.glade: change the label names
	for the freebusy/calendar urls to have more descriptive names,
	since we use them in e-contact-editor.c now.

	* backend/pas/pas-backend-ldap.c: add support for
	caluri/calendarURI, fburl/freeBusyURI.

	* backend/pas/evolutionperson.schema: add calendarURI and
	freeBusyURI.

1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196
2001-12-04  Christopher James Lahey  <clahey@ximian.com>

	* gui/contact-editor/contact-editor.glade: Fixed up the
	accelerators and such here.

	* gui/contact-editor/e-contact-editor.c (file_save_as_cb):
	Translate this string.
	(pixmaps): Added a pixmap for the ContactEditorSaveClose command.
	(setup_tab_order): Fixed up the tab order here.

	* gui/contact-editor/fulladdr.glade: Made the country combo
	focusable here.

1197 1198
2001-12-03  Jon Trowbridge  <trow@ximian.com>

1199 1200
	* backend/ebook/e-destination.c (e_destination_equal): Make address
	comparisons case-insensitive. (Fixes 11776)
1201 1202 1203 1204

	* backend/ebook/e-card.c (e_card_email_match_single_string): Make address
	host comparisons case-insensitive. (Fixes 11776)

1205 1206
	* gui/component/select-names/e-select-names-manager.c (focus_out_cb): Clean
	ESelectNamesModel on focus-out. (Half of a fix for 15656)
1207

1208 1209
	* backend/ebook/e-destination.c (nonempty): Fix this function
	and make it utf8-safe. (The other half of the fix for 15656)
1210

1211 1212 1213 1214 1215 1216 1217
2001-11-28  Christopher James Lahey  <clahey@ximian.com>

	* gui/contact-list-editor/e-contact-list-editor.c: Consistency
	fixes with standard contact editor.  Added Save As, Send As, and
	Send To.  Replaced Save toolbar with Save and Close and added Save
	and Close menu item.  Added a trash icon.

1218 1219 1220 1221 1222
2001-11-28  Christopher James Lahey  <clahey@ximian.com>

	* gui/contact-editor/e-contact-editor-address.c (setup_tab_order):
	Setup the tab order here.  Fixes Ximian bug #13751.

Christopher James Lahey's avatar
Christopher James Lahey committed
1223 1224 1225 1226 1227 1228
2001-11-28  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/addressbook.c (connect_master_list_changed,
	make_suboptions): Changed how this list of categories gets
	computed.  Fixes Ximian bugs #7707 and #7708.

1229 1230 1231 1232 1233 1234 1235 1236 1237 1238
2001-11-15  Zbigniew Chyla  <cyba@gnome.pl>

	* printing/e-contact-print-envelope.c (ecpe_linelist_dimensions),
	printing/e-contact-print.c (e_contact_divide_text, e_contact_output,
	e_contact_rectangle, e_contact_print_letter_tab,
	e_contact_print_letter_heading, e_contact_get_card_size,
	e_contact_print_card, e_contact_print_phone_list):
	s/gnome_font_get_width_string/gnome_font_get_width_utf8/
	s/gnome_font_get_width_string_n/gnome_font_get_width_utf8_sized/

1239 1240 1241 1242 1243 1244 1245
2001-11-14  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-ldap.c (search_for_dn): check against
	LDAP_SUCCESS as the return value, not -1.
	(pas_backend_ldap_build_all_cards_list): same.
	(pas_backend_ldap_process_authenticate_user): same.

1246 1247 1248 1249 1250 1251 1252 1253
2001-11-12  Chris Toshok  <toshok@ximian.com>

	[ Fixes Ximian bug #14843 ]
	* backend/pas/pas-backend-ldap.c (func_and): don't crash if a
	subexpression wasn't filled in.

	* backend/pas/pas-backend-ldap.c (func_or): same.

1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265
2001-11-12  Jon Trowbridge  <trow@ximian.com>

	* gui/contact-list-editor/e-contact-list-editor.c (list_added_cb):
	Release callback's reference to EContactListEditor.
	(list_modified_cb): Release callback's reference to
	EContactListEditor.
	(save_card): Ref the EContactListEditor on behalf of the
	e_book_foo callback. (Fixes bug #14743)
	(save_card): Set changed to false once we've saved.
	(list_deleted_cb): Release callback's reference.
	(delete_cb): Hold reference for the callback.

1266 1267 1268 1269 1270 1271
2001-11-12  Jon Trowbridge  <trow@ximian.com>

	* gui/contact-editor/e-contact-editor.c (categories_clicked): If
	our call to e_categories_new returns NULL, put up an error dialog
	and return.  (Fixed #14780)
		
1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292
2001-11-09  Chris Toshok  <toshok@ximian.com>

	[ Fixes Ximian bug #14687 ]
	* backend/pas/pas-backend-file.c

	* backend/pas/pas-book-factory.c
	(pas_book_factory_process_request): do load_uri before add_client,
	so we know if the load actually worked (add_client uses this
	information to respond to the new client.)  before this change,
	the client would still think the book was in a useful state even
	if the load_uri failed.

	* backend/pas/pas-backend-ldap.c (pas_backend_ldap_add_client): if
	the we're not connected, say so.

	* backend/pas/pas-backend-file.c (pas_backend_file_add_client):
	same.
	(pas_backend_file_load_uri): don't report_writable here,
	add_client does it.  was only needed before because of the
	improper ordering in pas-book-factory.c above.

1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305
2001-11-09  Chris Toshok  <toshok@ximian.com>

	[ Fixes Ximian bug #14646 ]
	* gui/component/addressbook.c (addressbook_default_book_open): new
	function.  if the default_book failed to load, load the local
	addressbook in its place.
	addressbook_load_default_book): if we're loading the default_book
	uri, use addressbook_default_book_open as the open_response.

	* backend/ebook/e-book.c (e_book_load_uri_step): reset the
	load_state to NotLoaded so we can attempt another load_uri on
	the book if it fails.

1306 1307 1308 1309 1310 1311
2001-11-08  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names-bonobo.c
	(impl_destroy): Explicitly destroy entries.  Part of the fix for
	the lingering completion window bug.

1312 1313 1314 1315 1316 1317 1318
2001-11-04  JP Rosevear  <jpr@ximian.com>

	* conduit/address-conduit.c: Use ordering of the pilot's phone
	label list to find fields we sync in order to avoid strcmp'ing the
	pilot's labels rendering phone syncing usable only for english
	language pilots

1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353
2001-11-03  Chris Toshok  <toshok@ximian.com>

	[ Fixes Ximian bug #14410 ]
	* gui/contact-editor/e-contact-editor.c (e_contact_editor_init):
	init in_async_call to FALSE.
	(card_added_cb): turn the UI back on and set in_async_call to
	FALSE.
	(card_modified_cb): same.
	(card_deleted_cb): same.
	(save_card): turn off the UI by setting the dialog insensitive,
	and set in_async_call to TRUE.
	(delete_cb): same.
	(app_delete_event_cb): if we're in an async call don't let the
	window get deleted.

	* gui/contact-editor/e-contact-editor.h (struct _EContactEditor):
	add in_async_call flag for when we make a wombat call and need to
	disable the UI.

	* gui/contact-list-editor/e-contact-list-editor.c
	(e_contact_list_editor_init): init in_async_call to FALSE.
	(list_added_cb): turn the UI back on and set in_async_call to
	FALSE.
	(list_modified_cb): same.
	(list_deleted_cb): same.
	(save_card): turn off the UI by setting the dialog insensitive,
	and set in_async_call to TRUE.
	(delete_cb): same.
	(app_delete_event_cb): if we're in an async call don't let the
	window get deleted.

	* gui/contact-list-editor/e-contact-list-editor.h (struct
	_EContactListEditor): add in_async_call flag for when we make a
	wombat call and need to disable the UI.

1354 1355 1356 1357 1358 1359
2001-11-02  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card-simple.c (e_card_simple_get): Check for
	NULL dates before converting them to strings.  Fixes Ximian bug
	#14394.

1360 1361 1362 1363 1364 1365
2001-11-02  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names-bonobo.c
	(impl_destroy): Leak select-names related data structures until
	the memory management issues get sorted out.  Fixed bug #14086.

1366 1367 1368 1369 1370 1371 1372
2001-10-31  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/e-cardlist-model.c,
	gui/component/select-names/e-select-names-table-model.c,
	gui/widgets/e-addressbook-table-adapter.c: Make the pre_changes
	and changes match here.

1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389
2001-10-31  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names.c
	(e_select_names_destroy): Check that local_listener and
	other_contacts_listener are non-NULL before
	disconnecting/unrefing.

	* gui/component/select-names/e-select-names-manager.c
	(entry_destroyed): The entry shouldn't unref the manager.
	(e_select_names_manager_create_entry): The entry shouldn't hold a
	ref to the manager.  It becomes circular.
	(e_select_names_manager_create_entry): On the other hand, we
	should hold a ref to the entry we create.

	* gui/component/select-names/e-select-names-bonobo.c
	(impl_destroy): Remove the explicit dialog destroy hack.

1390 1391 1392 1393 1394 1395 1396
2001-10-30  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names-bonobo.c
	(impl_destroy): Force the select names dialog to be destroyed.
	This is a hack to fix bug #14002 -- I'll clean up the refcounting
	issues post-freeze.  At least now it won't crash.

JP Rosevear's avatar
JP Rosevear committed
1397 1398
2001-10-30  JP Rosevear  <jpr@ximian.com>

1399 1400 1401
	* conduit/address-conduit.c (ecard_from_remote_record): make sure
	to translate the character sets of the names

JP Rosevear's avatar
JP Rosevear committed
1402 1403
2001-10-30  JP Rosevear  <jpr@ximian.com>
	
1404 1405 1406 1407 1408
	* gui/component/select-names/e-select-names-bonobo.c
	(manager_ok_cb): send a null bonobo arg to prevent explosion

2001-10-30  JP Rosevear  <jpr@ximian.com>
	
JP Rosevear's avatar
JP Rosevear committed
1409 1410
	* gui/widgets/e-addressbook-view.c: correct include typo

1411 1412 1413 1414 1415 1416 1417 1418 1419
2001-10-29  Jon Trowbridge  <trow@ximian.com.

	* gui/widgets/e-minicard.c (add_field): Five characters, not four!
	
	* gui/widgets/e-addressbook-table-adapter.c
	(addressbook_value_at): Convert xml-ified destinations into proper
	addresses.

2001-10-29  Jon Trowbridge  <trow@ximian.com.
1420 1421 1422 1423 1424 1425 1426 1427 1428

	* gui/component/select-names/e-select-names-bonobo.c (init):
	Connect to manager's "ok" signal.
	(manager_ok_cb): Emit "ok" bonobo-signal.

	* gui/component/select-names/e-select-names-manager.c
	(e_select_names_manager_class_init): Added "ok" signal.
	(e_select_names_clicked): Emit 'ok' signal.

1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453
2001-10-29  Chris Toshok  <toshok@ximian.com>

	* gui/widgets/e-addressbook-util.c
	(e_addressbook_prompt_save_dialog): new function, a "Do you want
	to save changes?" dialog.

	* gui/widgets/e-addressbook-util.h: add prototype for
	e_addressbook_prompt_save_dialog.

	* gui/contact-editor/e-contact-editor.c (prompt_to_save_changes):
	call e_addressbook_prompt_save_dialog and save the card if they
	select save.  return TRUE if the dialog should be closed, FALSE
	otherwise.
	(file_close_cb): check prompt_to_save_changes before closing the
	dialog.
	(app_delete_event_cb): same.

	* gui/contact-list-editor/e-contact-list-editor.c
	(prompt_to_save_changes): call e_addressbook_prompt_save_dialog
	and save the card if they select save.  return TRUE if the dialog
	should be closed, FALSE otherwise.
	(file_close_cb): check prompt_to_save_changes before closing the
	dialog.
	(app_delete_event_cb): same.

1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466
2001-10-29  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-ldap.c (add_objectclass_mod): overload
	this function for modifying objectclasses too, so we can make sure
	evolutionPerson shows up in the objectclasses of an entry if it
	shows up in the schema for the server.
	(create_card_handler): add @replace = FALSE in the call to
	add_objectclass_mod.
	(modify_card_handler): call add_objectclass_mod with @replace =
	TRUE.
	(anniversary_compare): fix typo - return "equal", not "TRUE".
	(birthday_compare): same.

Jon Trowbridge's avatar
Jon Trowbridge committed
1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480
2001-10-29  Jon Trowbridge  <trow@ximian.com>

	* conduit/address-conduit.c (pre_sync): Comment out spew.

	* gui/contact-list-editor/e-contact-list-editor.c (fill_in_info):
	Comment out spew.

	* gui/component/addressbook-component.c
	(destination_folder_handle_drop): Comment out spew.
	(get_dnd_selection): Comment out spew.

	* gui/widgets/e-addressbook-table-adapter.c
	(addressbook_set_value_at): Comment out spew.

1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498
2001-10-29  Jon Trowbridge  <trow@ximian.com>

	* gui/component/addressbook.c (update_command_state): Check that
	our BonoboUIComponent has a container so we don't get a lot of
	annoying debug spew.

	* printing/smallbook.ecps: Fixed fonts.

	* printing/phonelist.ecps: Fixed fonts.

	* printing/medbook.ecps: Fixed fonts.

	* printing/e-contact-print.c (e_contact_get_card_size): Commented
	out spew.

	* gui/widgets/e-minicard.c (remodel): Check that e_minicard->card
	!= NULL.

1499 1500 1501 1502 1503 1504 1505
2001-10-29  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names-completion.c
	(e_select_names_completion_destroy): We were using
	book_data->book_view immediately after unrefing it.  Reordered the
	code a bit to avoid this.

1506 1507 1508 1509 1510 1511 1512 1513 1514
2001-10-29  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-book-factory.h: add prototype for
	pas_book_factory_dump_active_backends.

	* backend/pas/pas-book-factory.c
	(pas_book_factory_dump_active_backends): new function.
	(dump_active_server_map_entry): new function.

1515 1516 1517 1518 1519 1520 1521
2001-10-29  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names-completion.c
	(make_match): Drop a match if either of the text fields is NULL.
	This could happen if any of the utf-8 involved is invalid, for
	example. (Bug #13757)

1522 1523
2001-10-29  JP Rosevear  <jpr@ximian.com>

1524 1525 1526 1527 1528 1529 1530 1531 1532
	* conduit/address-conduit.c (is_syncable): fix bug that allowed
	for phone's not to be in priority order and the item to still be
	syncable

	* conduit/address-conduit-config.h
	(addrconduit_load_configuration): get management by id

2001-10-29  JP Rosevear  <jpr@ximian.com>
	
1533 1534 1535
	* conduit/address-conduit.c (is_syncable): a card also needs to
	have its phone nums in priority order to be "syncable"
	
1536 1537 1538 1539 1540 1541 1542
2001-10-29  JP Rosevear  <jpr@ximian.com>

	* conduit/address-conduit.c (is_syncable): move the syncable
	checking code to a different function
	(ecard_from_remote_record): set the name parts individually
	(local_record_from_ecard): use is_syncable

1543 1544 1545 1546 1547 1548
2001-10-29  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card-simple.c (file_as_get_style,
	file_as_set_style): Use the actual ECardName in the ECard instead
	of parsing the full_name here.

1549 1550 1551 1552 1553 1554
2001-10-29  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card-simple.c, backend/ebook/e-card-simple.h
	(e_card_simple_set_name): New function to set the ECardName on
	this card and fix the file_as if necessary.

1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576
2001-10-29  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card-simple.c, backend/ebook/e-card-simple.h
	(e_card_simple_get): Handle returning dates here.
	(e_card_simple_get_allow_newlines): New function.  Returns whether
	it makes much sense to have newlines in this string.

	* gui/component/addressbook-config.c,
	gui/component/addressbook-config.h
	(addressbook_create_new_source): The first argument here should
	be const.

	* gui/component/addressbook-storage.c: Added #include
	"addressbook-config.h".

	* gui/widgets/e-minicard-label.c (e_minicard_label_event): On an
	escape here, cancel editing and remove the focus from the text.

	* gui/widgets/e-minicard.c (add_field): Set allow_newlines here.
	(field_activated): Stop editing on the activate signal and remove
	the focus from the text.  Fixes Ximian bug #12286.

JP Rosevear's avatar
JP Rosevear committed
1577 1578 1579 1580 1581 1582 1583 1584
2001-10-28  JP Rosevear  <jpr@ximian.com>

	* conduit/address-conduit.h: tidy

	* conduit/address-conduit-config.h: ditto

	* conduit/address-conduit.c (add_record): unref ecard when done

1585 1586 1587 1588 1589 1590 1591
2001-10-28  Jon Trowbridge  <trow@ximian.com>

	* backend/ebook/e-card.c (e_card_date_from_string): Expose this
	function.
	(e_card_date_to_string): ...and this one.  Fixes build problem in
	pas-backend-ldap.c.

1592 1593 1594 1595 1596 1597 1598 1599 1600 1601
2001-10-28  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names.c
	(e_select_names_hookup_shell_listeners): Change "this should never
	happen" dialog to not give my name/e-mail.  Sorry translators.
	But this really should never happen, thanks to my fix below.

	* gui/component/addressbook-component.c: Initialize
	global_shell_client to NULL. (Bug #6625)

1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612
2001-10-27  Chris Toshok  <toshok@ximian.com>

	[ bug #12979 ]
	* backend/pas/pas-backend-ldap.c (anniversary_populate): new
	function.
	(anniversary_ber): new function.
	(anniversary_compare): new function.
	(birthday_populate): new function.
	(birthday_ber): new function.
	(birthday_compare): new function.

1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648
2001-10-27  Chris Toshok  <toshok@ximian.com>

	* gui/component/select-names/e-select-names-completion.c
	(e_select_names_completion_destroy): free up all the book_data
	list stuff.
	(e_select_names_completion_got_book_view_cb): deal with book_data
	being passed as the closure, and increment the
	pending_completion_seq counter.
	(e_select_names_completion_card_added_cb): deal with book_data
	being passwd as the closure.
	(e_select_names_completion_seq_complete_cb): same, and decrement
	the pending_completion_seq if we haven't gotten one for this book
	view before.
	(e_select_names_completion_stop_query): cancel all the
	book_data's.
	(e_select_names_completion_start_query): use the books_not_ready
	counter instead of book_ready.  also, do e_book_get_book_view on
	each of the book's in our list.
	(e_select_names_completion_do_query): change to deal with our
	list.
	(e_select_names_completion_book_ready): decrement the
	book_not_ready counter.
	(e_select_names_completion_new): add the book we're created with
	to our list.
	(e_select_names_completion_add_book): implement.

	* gui/component/select-names/e-select-names-completion.h: add
	prototype for e_select_names_completion_add_book.

	* gui/component/select-names/e-select-names-manager.c
	(e_select_names_manager_new): use addressbook_config_data, and
	don't unref the db.
	(e_select_names_manager_create_entry): always add NULL for a book
	(which corresponds to the local book), and if the completion_book
	is present, add it to the list of books to complete again.

1649 1650
2001-10-27  Chris Toshok  <toshok@ximian.com>

1651 1652 1653 1654 1655 1656 1657
	* gui/contact-editor/e-contact-quick-add.c (merge_cb): change to
	EBookCallback signature, and unref the book.
	(quick_add_merge_card): use addressbook_load_default_book.
	(ce_have_book): change to EBookCallback signature, and unref the
	book.
	(edit_card): use addressbook_load_default_book.

1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677
	* gui/component/e-address-popup.c (email_table_save_card_cb):
	change to EBookCallback signature, and unref the book.
	(add_card_idle_cb): use addressbook_load_default_book, and call
	the cb if it fails.
	(e_address_popup_cleanup): fix type -- should be "pop->card =
	NULL", not "pop = NULL".
	(contact_editor_cb): change to EBookCallback signature.
	(edit_contact_info_cb): use addressbook_load_default_book.
	(start_query): change to EBookCallback signature.
	(e_address_popup_query): use addressbook_load_default_book.

	* gui/widgets/e-minicard-control.c (book_open_cb): change to
	EBookCallback signature, and unref the book.
	(save_in_addressbook): use addressbook_load_default_book instead
	of e_book_use_local_address_book.

	* gui/widgets/Makefile.am (INCLUDES): change includes since we're
	including addressbook.h which has it's own set of funky include
	path requirements.

1678 1679 1680 1681 1682
2001-10-27  Jon Trowbridge  <trow@ximian.com>

	* backend/ebook/e-book.c (activate_factories_for_uri): Don't leak
	stuff. (Bug #13709)

1683 1684 1685 1686 1687
2001-10-27  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-destination.c (name_and_email_simple_query_cb,
	nickname_simple_query_cb): Set book_uri when cardification occurs.

1688 1689 1690 1691
2001-10-27  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/select-names/e-select-names.c
	(e_select_names_add_section): Turned off use_ellipsis (it breaks
1692 1693
	emulate_label_resize) and on emulate_label_resize.  Fixes Ximian
	bug #13693.
1694

1695 1696 1697 1698 1699 1700
2001-10-27  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names-completion.c
	(make_match): Doh!  We should be sorting our contacts so that the
	most frequently used ones are at the top of the list, not the
	bottom.
1701 1702 1703 1704 1705 1706 1707 1708 1709 1710

	* backend/pas/pas-book.c (pas_book_check_queue): That should be a
	bonobo_object_unref, not a gtk_object_unref.
	(pas_book_queue_request): Likewise, we need to bonobo_object_ref
	here.
	(pas_book_destroy): If our pas_book_check_queue timeout is still
	active, disable it.  This should never happen, but it never hurts
	to be careful.
	(pas_book_destroy): Set book->priv to NULL after we free it.

1711 1712 1713 1714 1715 1716
2001-10-27  JP Rosevear  <jpr@ximian.com>

	* conduit/address-conduit.c (local_record_from_ecard): copy phone
	labels and show phone as well, clear correct entry text and
	correctly detect unsyncable cases

1717 1718 1719 1720 1721 1722 1723 1724 1725
2001-10-27  JP Rosevear  <jpr@ximian.com>

	* conduit/address-conduit.c (local_record_from_ecard): touch the
	record on lookup
	(check_for_slow_setting): write touched only if we are doing a
	slow sync
	(card_removed): don't touch on lookup
	(match): touch on lookup

1726 1727 1728 1729 1730 1731 1732 1733
2001-10-27  Jon Trowbridge  <trow@ximian.com>

	* backend/pas/pas-book.c (pas_book_check_queue): Added paranoid
	reentrancy guards.
	(pas_book_queue_request): Changed our idle handler into a timeout,
	so as to work w/ reentrancy guards.
	(pas_book_init): Explicit initialization.

1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744
2001-10-26  Chris Toshok  <toshok@ximian.com>

	* gui/component/addressbook.h: add prototypes for
	addressbook_config_database, and addressbook_load_default_book.

	* gui/component/addressbook.c (addressbook_config_database): new
	function, so we aren't activating the db everywhere we need to use
	it.
	(addressbook_load_default_book): load the default book, after
	getting the uri from bonobo-config.

1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762
2001-10-26  Jon Trowbridge  <trow@ximian.com>

	* backend/ebook/e-book-util.c (simple_query_card_added_cb): Return
	on cancellation.
	(simple_query_sequence_complete_cb): Act if not cancelled.
	(simple_query_book_view_cb): Free & return on cancellation.
	(e_book_simple_query_cancel): Set cancellation flag.

	* gui/component/e-address-popup.c (e_address_popup_query): Hold a
	reference to ourselves for the duration of our addressbook fetch.
	(start_query): Release when we've fetched our addressbook.
	(e_address_popup_cleanup): Break out most of what we do in
	_destroy into a separate function.
	(e_address_popup_destroy): Class cleanup.
	(contact_editor_cb): Paranoid clean-up.
	(add_contacts_cb): Paranoid clean-up.
	(e_address_popup_ambiguous_email_add): Paranoid clean-up.

1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773
2001-10-26  JP Rosevear  <jpr@ximian.com>

	* conduit/e-address.conduit.in: remove the merges as valid sync
	types

	* conduit/address-conduit.c (pre_sync): write out only the touched
	records if we are doing copies

	* conduit/address-conduit-config.h
	(addrconduit_load_configuration): get the sync type

1774 1775
2001-10-26  Jon Trowbridge  <trow@ximian.com>

1776 1777 1778
	* gui/component/e-address-popup.c (e_address_popup_destroy):
	Cancel any pending queries.

1779 1780 1781 1782
	* gui/contact-editor/e-contact-editor.c (close_dialog): Don't
	assert, but check if ce->app != NULL, since this function can
	(apparently) get called multiple times.

1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793
	* gui/contact-editor/e-contact-save-as.c (file_exists): Remove bad
	dialog ref-counting crap.

	* gui/contact-editor/e-contact-editor.c (save_card): Ref our
	EContactEditor, since we are holding a pointer to it in
	EditorCloseStruct.
	(card_modified_cb): Unref our EContactEditor when we free our
	EditorCloseStruct.
	(card_added_cb): Unref our EContactEditor when we free our
	EditorCloseStruct.

1794
2001-10-26  JP Rosevear  <jpr@ximian.com>
1795
	
1796 1797 1798
	* conduit/address-conduit.c (check_for_slow_setting): make debug
	info more accurate
	
JP Rosevear's avatar
JP Rosevear committed
1799 1800
2001-10-26  JP Rosevear  <jpr@ximian.com>

1801 1802 1803 1804 1805 1806 1807 1808
	* conduit/address-conduit.c (e_addr_context_destroy): prevent
	double unref
	(cursor_cb): correct typo
	(card_removed): remove the card from the map if was archived and
	is now deleted

2001-10-26  JP Rosevear  <jpr@ximian.com>
	
JP Rosevear's avatar
JP Rosevear committed
1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825
	* conduit/address-conduit.h: new member

	* conduit/address-conduit.c (print_remote): free the struct after
	using it
	(e_addr_context_new): make consistent with other conduits
	(e_addr_context_destroy): properly destroy the context
	(cursor_cb): no need to ref the card, its done for us
	(clear_entry_text): util function to free a field
	(free_local): free a local record
	(local_record_to_pilot_record): use a static buffer so we don't
	have to free it later
	(local_record_from_ecard): only fill in the fields we might not
	sync, clear a field before replacing the contents
	(for_each): track locals
	(for_each_modified): ditto
	(free_match): use free_local

1826 1827 1828 1829 1830 1831 1832
2001-10-26  Christopher James Lahey  <clahey@ximian.com>

	* gui/widgets/e-minicard.c, gui/widgets/e-minicard.h
	(set_has_cursor): Added has_cursor argument.  Setting the argument
	to TRUE if the minicard doesn't have focus will grab the focus.
	Fixes Ximian bug #3024.

Jon Trowbridge's avatar
Jon Trowbridge committed
1833 1834 1835 1836 1837 1838 1839 1840 1841
2001-10-24  Jon Trowbridge  <trow@ximian.com>

	* gui/component/addressbook-factory.c (main): Initialize
	gnome-vfs.

	* gui/component/addressbook-component.c (xfer_file): Added.
	(Copied from the calendar.)
	(xfer_folder): Fixed to allow renaming of contact folders.

1842 1843 1844 1845 1846 1847
2001-10-24  Christopher James Lahey  <clahey@ximian.com>

	* gui/widgets/e-addressbook-view.c
	(e_addressbook_view_class_init): Removed key_press handler here
	since delete and backspace are now handled by keybindings.

1848 1849
2001-10-23  Jon Trowbridge  <trow@ximian.com>

1850 1851 1852 1853 1854 1855 1856
	* gui/component/addressbook.c: Fix command paths when we specify
	our pixmaps, so we don't get a lot of totally useless & very ugly
	bonobo-ui spew.

	* backend/ebook/e-book-util.c (e_book_nickname_query): The empty
	string as an arg shouldn't generate a warning.

1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871
	* gui/component/select-names/e-select-names-completion.c: Removed
	our cancelled flag and e_select_names_completion_cancel function,
	since we were just duplicating stuff that had ended up in
	ECompletion.
	(match_name): Form our menu_text properly on an additional-name
	match.
	(e_select_names_completion_got_book_view_cb): Store handles for
	our signals, disconnect them properly when we switch book views.
	(e_select_names_completion_stop_query): Disconnect signals when we
	stop our query.
	(check_capabilities): Spew if we are using LDAP for completion.
	(e_select_names_completion_destroy): Disconnect our signals when
	we destroy.
	This all should fix bug #10241.

1872 1873 1874 1875 1876 1877
2001-10-23  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/select-names/e-select-names.c
	(e_select_names_add_section): Set "draw_button" argument to TRUE
	on this EEntry.

1878 1879 1880 1881 1882 1883 1884
2001-10-22  Christopher James Lahey  <clahey@ximian.com>

	* gui/contact-editor/e-contact-save-as.c (save_it): Put up an
	error dialog if there's an error while saving.  If the person hits
	cancel on the "file exists" dialog, don't close the file selection
	dialog.  Fixes Ximian bug #7055.

1885 1886 1887 1888 1889 1890
2001-10-21  Christopher James Lahey  <clahey@ximian.com>

	* gui/widgets/e-addressbook-reflow-adapter.c
	(model_and_selection_free): right_click_up here when we let go of
	the popup.

1891 1892 1893
	* gui/widgets/e-minicard-view.c (e_minicard_view_selection_event):
	right_click_up here.

1894 1895 1896 1897 1898 1899
2001-10-21  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/select-names/e-select-names.c
	(e_select_names_add_section, e_select_names_set_default): Use an
	EEntry here instead of a GtkLabel.  Fixes Ximian bug #7067.

1900 1901 1902 1903 1904 1905 1906 1907 1908 1909
2001-10-21  Jon Trowbridge  <trow@ximian.com>

	* gui/component/addressbook.c (control_activate_cb): Call
	e_addressbook_model_force_folder_bar_message when we activate the
	component. (Fixes bug #11749)

	* gui/widgets/e-addressbook-model.c
	(e_addressbook_model_force_folder_bar_message): Added.  Forces
	emission of a folder_bar_message.

1910 1911 1912 1913 1914
2001-10-20  Larry Ewing  <lewing@ximian.com>

	* gui/component/select-names/e-select-names.c
	(e_select_names_set_default): stick with the style font if the
	efont bold font does not exist.	
1915
	(e_select_names_set_default): don't forget to unref the oldstyle.
1916

Jon Trowbridge's avatar
Jon Trowbridge committed
1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930
2001-10-20  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names-completion.c
	(name_style_query): Fix memory leak.

	* gui/widgets/e-addressbook-view.c (jump_to_letter): Free our
	string vector letter_v when we are done with it.

	* gui/contact-editor/e-contact-quick-add.c (edit_card): Unref our
	QuickAdd structure.

	* gui/component/e-address-popup.c (e_address_popup_construct):
	Unref our style after we are done with it.

1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942
2001-10-20  Jon Trowbridge  <trow@ximian.com>

	* backend/ebook/e-book.c (activate_factories_for_uri): We
	shouldn't leak the info returned by oaf_query.

	* gui/contact-editor/e-contact-quick-add.c (card_added_cb): Remove
	superfluous call to quick_add_unref.
	(editor_closed_cb): Remove superfluous call to quick_add_unref.

	* gui/component/select-names/e-select-names.c (esn_get_key_fn): We
	need to unref the card returned by e_addressbook_model_get_card.

1943 1944 1945 1946 1947
2001-10-20  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/addressbook-component.c: Make LDAP servers
	non-user-creatable.

1948 1949
2001-10-20  Jon Trowbridge  <trow@ximian.com>

1950 1951 1952
	* printing/e-contact-print.c (e_contact_print_card): Check that the
	string we are checking for xml-ness is non-NULL.

1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967
	* backend/ebook/e-destination.c (e_destination_importv): Filter
	out empty destinations. (also Bug #13036)

	* printing/e-contact-print.c (e_contact_build_style): Use
	gnome_font_new_closest; if gnome_font_new fails and returns NULL,
	our spacing gets all messed up. (Bug #10785)
	
	* gui/widgets/e-addressbook-view.c (e_addressbook_view_can_print):
	Allow printing if there are any cards in our view.  The selection
	has nothing to do with it.

	* backend/ebook/e-destination.c (e_destination_is_empty): Check
	for strings that contain non-whitespace, rather than just looking
	for a non-zero first character. (Bug #13036)

1968 1969 1970 1971 1972 1973
2001-10-20  Christopher James Lahey  <clahey@ximian.com>

	* gui/widgets/e-minicard-view.c (e_minicard_view_selection_event):
	Handle focus_change in event by selecting that contact.  Fixes
	Ximian bug #3024.

1974 1975 1976 1977
	* gui/component/addressbook-component.c (owner_unset_cb):
	Repeatedly call gtk_main_quit here as long as there is a main loop
	around.  This is an ugly hack around Ximian bug #11760.

1978 1979 1980 1981 1982 1983 1984 1985 1986 1987
2001-10-20  Christopher James Lahey  <clahey@ximian.com>

	* gui/component/select-names/e-select-names.c: Added #include
	<gal/widgets/e-unicode.h>.

	* gui/widgets/e-minicard-control.c: Made this display the number
	of extra cards in the attachment as well as made it save them all
	to the local addressbook if the person selects the button.  Fixes
	Ximian bug #9507.

1988 1989 1990 1991 1992
2001-10-20  Christopher James Lahey  <clahey@ximian.com>

	* gui/widgets/e-minicard.c (e_minicard_event): Changed this to not
	grab on a right click.  Fixes Ximian bug #12660.

1993 1994 1995 1996 1997 1998 1999 2000
2001-10-19  Ettore Perazzoli  <ettore@ximian.com>

	* gui/component/addressbook-component.c
	(destination_folder_handle_motion): Get @folder_type here too [to
	match the changes in the EvolutionShellComponentDnd interface].
	Also, remove a debugging message.
	(destination_folder_handle_drop): Likewise.

2001 2002 2003 2004 2005 2006 2007 2008 2009
2001-10-18  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names.c (add_menu_item):
	Translate labels in select-names option menu. (Bug #9604)

	* gui/search/e-addressbook-search-dialog.c
	(e_addressbook_search_dialog_init): Made the default window size
	slightly wider. (Bug #7516)

2010 2011 2012 2013 2014
2001-10-18  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card.c, backend/ebook/e-card.h
	(e_card_list_get_vcard): Made this take a const GList.

2015 2016
2001-10-18  Jon Trowbridge  <trow@ximian.com>

2017 2018 2019 2020 2021 2022 2023 2024 2025 2026
	* gui/component/select-names/e-select-names-completion.c
	(check_capabilities): Added.  Check if our book is local or
	networked.
	(e_select_names_completion_book_ready): Call check_capabilities.
	(e_select_names_completion_new): Call check_capabilities.
	(e_select_names_completion_do_query): If we have a networked book,
	keep trying if we haven't been able to cache any cards --- our
	earlier attempts could have failed due to too many matches. (Bug
	#12932)

2027 2028 2029 2030 2031 2032 2033 2034
	* gui/component/select-names/e-select-names-manager.c
	(focus_out_cb): Lag our cardification on focus-out.  This seems to
	help with the unintended cardifications that can result from the
	weird focus-out/focus-in events that get generated when the popup
	disappears.

	* backend/ebook/e-card-compare.c: Removed some debug spew.

2035 2036 2037 2038 2039 2040
2001-10-17  Chris Toshok  <toshok@ximian.com>

	* gui/component/addressbook-config.c (addressbook_source_dialog):
	grab focus in the Account entry when preparing the dialog, fixes
	#10406.

2041 2042 2043 2044 2045
2001-10-17  Chris Toshok  <toshok@ximian.com>

	* gui/component/select-names/e-select-names.c (new_folder): make
	sure to also add "ldap-contacts" folders to the option menu.

2046 2047 2048 2049 2050 2051 2052 2053
2001-10-17  JP Rosevear  <jpr@ximian.com>

	* conduit/address-conduit.c (ecard_from_remote_record): sync all
	the fields we can, with out overwriting
	(local_record_from_ecard): write the fields to the pilot in
	priority order unless there are fields on the pilot we can't
	store, then fill in the fields as they are on the pilot

2054 2055 2056 2057 2058 2059 2060 2061
2001-10-17  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card.c (e_card_get_vobject): Did a bit of clean
	up here.  Might fix some crashes, specifically Ximian bug #10164.

	* gui/widgets/e-addressbook-view.c (SPEC): Updated the model
	column numbers here.  Fixes Ximian bug #12308.

2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073
2001-10-17  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-file.c (pas_backend_file_upgrade_db):
	add upgrade from 0.1 to 0.2, where we make sure id dbt's match
	vcard id's, fixes longstanding bug (#7406) where cards were not
	modifiable or removable after having been created during a 1-2
	week long window in early betas.
	(PAS_BACKEND_FILE_VERSION): change to 0.2
	(PAS_ID_PREFIX): #define this here.
	(pas_backend_file_create_unique_id): use PAS_ID_PREFIX instead of
	the string.

Iain Holmes's avatar
Iain Holmes committed
2074 2075 2076 2077 2078
2001-10-16  Iain Holmes  <iain@ximian.com>

	* backend/ebook/evolution-ldif-importer.c (support_format_fn): Return
	FALSE if no extension.

2079 2080 2081 2082 2083 2084 2085 2086 2087
2001-10-16  Jon Trowbridge  <trow@ximian.com>

	* backend/ebook/e-card.c (e_card_get_id): If card->id is NULL,
	return an empty string.
	(e_card_set_id): Don't allow the card id to be set to NULL; use
	the empty string instead.
	(e_card_get_vobject): When building our vcard, pass in the empty
	string as the id if card->id is NULL. (Bug #10164)

2088 2089 2090 2091 2092 2093
2001-10-16  JP Rosevear  <jpr@ximian.com>

	* conduit/address-conduit.c (local_record_from_ecard): don't set
	the phone info if it is blank
	(ecard_from_remote_record): save up to 3 fax numbers

2094 2095 2096 2097 2098
2001-10-15  Chris Toshok  <toshok@ximian.com>

	* backend/pas/pas-backend-ldap.c (pas_backend_ldap_add_client):
	unref the book after we pass it off to evolution-addressbook.

2099 2100
2001-10-15  Chris Toshok  <toshok@ximian.com>

2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112
	* backend/pas/pas-backend-ldap.c (create_card_dtor): unref
	op->view.
	(pas_backend_ldap_process_create_card): ref op->view.
	(remove_card_dtor): unref op->view.
	(pas_backend_ldap_process_remove_card): ref op->view.
	(modify_card_dtor): unref op->view.
	(pas_backend_ldap_process_modify_card): ref op->view.
	(ldap_search_dtor): unref op->view.
	(pas_backend_ldap_search): ref op->view.

2001-10-15  Chris Toshok  <toshok@ximian.com>
	
2113 2114 2115 2116 2117 2118 2119 2120 2121
	* backend/pas/pas-backend-ldap.c
	(pas_backend_ldap_process_get_book_view): make sure to unref the
	book_view here so we don't leak them.

2001-10-12  Chris Toshok  <toshok@ximian.com>

	* gui/component/addressbook-factory.c (main): call
	e_passwords_init and e_passwords_shutdown.

2122 2123 2124 2125 2126 2127
2001-10-15  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card.c (addPropValueQP, addPropValueSets,
	e_card_get_vobject): Properly decide whether a property needs to
	be marked as QP by searching for '\n'.  Fixes Ximian bug #3021.

2128 2129 2130 2131 2132 2133
2001-10-15  Christopher James Lahey  <clahey@ximian.com>

	* gui/contact-editor/e-contact-save-as.c (e_contact_save_as,
	e_contact_list_save_as): Set the default file name here.  Fixes
	Ximian bug #7053.

2134 2135 2136 2137 2138 2139
2001-10-14  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names.c
	(e_select_names_hookup_shell_listeners): Added linebreaks to our
	"this shouldn't happen" dialog message. (Bug #12498)

2140 2141 2142 2143 2144
2001-10-12  Jon Trowbridge  <trow@ximian.com>

	* gui/component/addressbook-factory.c (main): Add a component name
	to the e_passwords_init() call.

2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167
2001-10-12  Chris Toshok  <toshok@ximian.com>

	* backend/ebook/evolution-ldif-importer.c: commit the importer
	originally from Michael M. Morrison, with fixups by toshok.

	* backend/ebook/Makefile.am (bin_PROGRAMS): add
	evolution-ldif-importer.
	(oaf_in_files): add
	GNOME_Evolution_Addressbook_LDIF_Importer.oaf.in.

	* backend/ebook/e-card-simple.h: add WANTS_HTML and IS_LIST.

	* backend/ebook/e-card-simple.c (field_data): add WANTS_HTML and
	IS_LIST.
	(e_card_simple_set): fix typo.

	* backend/ebook/.cvsignore: ignore
	GNOME_Evolution_Addressbook_LDIF_Importer.oaf and
	evolution-ldif-importer.

	* backend/ebook/GNOME_Evolution_Addressbook_LDIF_Importer.oaf.in:
	ldif importer oafinfo.

2168 2169 2170 2171 2172
2001-10-12  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card-simple.c, backend/ebook/e-card-simple.h:
	Added a boolean type here.

2173 2174 2175 2176 2177 2178 2179
2001-10-12  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-names.c
	(addressbook_model_set_uri): Check to see if the uri we are
	setting is the same as the current uri.  If so, do nothing.
	(Bug #11324)

2180 2181 2182 2183 2184 2185 2186 2187
2001-10-11  Jon Trowbridge  <trow@ximian.com>

	* backend/ebook/e-destination.c
	(e_destination_reverting_is_a_good_idea): Added.  Heuristic for
	whether or not we want to revert to an earlier cardified state.
	(e_destination_cardify): Don't be quite as aggressive about
	reverting to previous cardified states. (Bug #11890)

2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229
2001-10-11  Christopher James Lahey  <clahey@ximian.com>

	* backend/ebook/e-card-simple.c (e_card_simple_destroy,
	fill_in_info, e_card_simple_sync_card, e_card_simple_set_phone,
	e_card_simple_set_address, e_card_simple_set_delivery_address,
	file_as_get_style, file_as_set_style, e_card_simple_set,
	e_card_simple_set_arbitrary),
	gui/contact-editor/e-contact-editor-address.c
	(e_contact_editor_address_destroy,
	e_contact_editor_address_set_arg,
	e_contact_editor_address_get_arg),
	gui/contact-editor/e-contact-editor-fullname.c
	(e_contact_editor_fullname_destroy,
	e_contact_editor_fullname_set_arg,
	e_contact_editor_fullname_get_arg),
	gui/contact-editor/e-contact-editor.c (phone_entry_changed,
	address_text_changed, name_entry_changed, full_name_clicked,
	full_addr_clicked, fill_in_info): Changed these to use the new ref
	and unref functions for ECard auxillary types.

	* backend/ebook/e-card-simple.h: Added a comment.

	* backend/ebook/e-card-types.h: Added ref_count field to all the
	types.

	* backend/ebook/e-card.c, backend/ebook/e-card.h: Added ref and
	unref functions here for all the ECard auxillary types.  Removed
	the corresponding free functions.  Switched to using these
	functions where appropriate.

	* gui/component/addressbook-factory.c: #include
	<e-util/e-passwords.h>

	* gui/component/addressbook.c (load_uri_cb): const correctify.

	* gui/component/select-names/e-select-names-manager.c,
	gui/component/select-names/e-select-names.c: #include
	<addressbook/gui/component/addressbook.h>

	* gui/widgets/e-addressbook-model.c (modify_card): Removed an
	unnecessary ref here.

Dan Winship's avatar
Dan Winship committed
2230 2231 2232 2233 2234
2001-10-11  Dan Winship  <danw@ximian.com>

	* gui/component/select-names/e-select-names.c (update_folder):
	Don't need this any more.

2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290
2001-10-11  Jon Trowbridge  <trow@ximian.com>

	* gui/component/addressbook.c (new_contact_cb): Check that
	view->view != NULL.
	(save_contact_cb): Check that view->view != NULL.
	(search_cb): Check that view->view != NULL.
	(delete_contact_cb): Check that view->view != NULL.
	(print_cb): Check that view->view != NULL.
	(print_preview_cb): Check that view->view != NULL.
	(stop_loading_cb): Check that view->view != NULL.
	(cut_contacts_cb): Check that view->view != NULL.
	(copy_contacts_cb): Check that view->view != NULL.
	(paste_contacts_cb): Check that view->view != NULL.
	(select_all_contacts_cb): Check that view->view != NULL.
	(send_contact_cb): Check that view->view != NULL.
	(send_contact_to_cb): Check that view->view != NULL.
	(update_command_state): Check that view->view != NULL.  Hold a
	reference to the AddressbookView for the duration of the function,
	in case we exit during bonobo-reentrancy.
	(addressbook_view_ref): Added.
	(addressbook_view_unref): Added.  Simple ref counting for
	AddressbookView objects.
	(addressbook_view_clear): Zero out an AddressbookView.  This is
	now separated from the deallocation of the AddressbookView object,
	so that we don't leave a dangling pointer if we exit during
	bonobo-reentrancy in update_command_state. (Which often seems to
	happen if we exit while addressbook operations are going on.)
	(destroy_callback): Replace previous call to addressbook_view_free
	with addressbook_view_clear/addressbook_view_unref calls.
	(addressbook_factory_new_control): Initialize the reference count
	in the AddressbookView object.

	* gui/widgets/e-addressbook-view.c (e_addressbook_view_destroy):
	Carefully zero out our destroyed object.
	(command_state_change): Hold a reference to ourselves during the
	signal emission.
	(get_selected_cards): Ref cards as we add them to the list.
	(e_addressbook_view_stop): Check for view != NULL.
	(e_addressbook_view_can_create): Check for view != NULL.
	(e_addressbook_view_can_print): Check for view != NULL.
	(e_addressbook_view_can_save_as): Check for view != NULL.
	(e_addressbook_view_can_send): Check for view != NULL.
	(e_addressbook_view_can_send_to): Check for view != NULL.
	(e_addressbook_view_can_delete): Check for view != NULL.
	(e_addressbook_view_can_cut): Check for view != NULL.
	(e_addressbook_view_can_copy): Check for view != NULL.
	(e_addressbook_view_can_paste): Check for view != NULL.
	(e_addressbook_view_can_select_all): Check for view != NULL.
	(e_addressbook_view_can_stop): Check for view != NULL.

	* gui/widgets/e-addressbook-model.c (addressbook_destroy): Be
	careful about zeroing out our destroyed object.
	
	* backend/ebook/e-book-view.c (e_book_view_stop): Added.  Stops
	event processing in the underlying listener.

2291 2292 2293 2294 2295 2296 2297
2001-10-10  Jon Trowbridge  <trow@ximian.com>

	* gui/component/select-names/e-select-