Evolution's mail composer attachments warning infobar is redundant with the attachment pane, and doesn't show in the case of forwarded mails
In Fedora 31 with Evolution 3.36, if you right-click a file in Nautilus and choose "Send To...", you get this:
I'm not entirely sure why we suddenly need an infobar to tell us that we have attached files to the newly created email when this was a direct result of the user using the "Send To..." feature to send files via email... but I'll presume you have a good reason for this (?) so I'll give this the benefit of the doubt for a minute, and propose a UX improvement rather than just say the infobar should not be there at all (and why isn't that infobar showing up when I forward an email that has attachments? That would make more sense)...
The infobar is redundant with the attachments bar and uses some of the very scarce and previous vertical space, because the attachment bar shows up in an opened state when you create an email with attachments from the start. So if you want to keep it, and make the behavior consistent, Evolution should:
- Fold the attachments pane on mail creation when that infobar is shown, particularly when created from a "Send To..." command from another app
- Instead of a "X", it should be an "OK" button, because X could be misinterpreted as "oh, delete those attachments"
- When the attachments pane is opened by the user, automatically dismiss the infobar. It's pretty damned clear they got the message at this point.
- To be consistenty, you should also display that warning infobar when forwarding an "email that contains attachments", and the same other rules should apply.
...but frankly, I still think this infobar should not even exist at all, because if you "Send To..." or Forward a message that had attachments, the attachments pane already shows up opened... it's pretty obvious and in-your-face already.
Alternatively, if your goal is just to grab the user's attention... you could maybe show the infobar below the email contents, just above the attachments pane, without any buttons in the infobar and have the infobar show itself using a GTK Revealer "slide up" animation, then automatically hide (un-reveal) it after 4-5 seconds, therefore acting like a notification banner of sorts... it would save me at least one click and it would avoid wasting vertical space that would otherwise be useful for composing the email's contents. This approach could even be combined with the previous approach above, i.e. showing a transient animated infobar above the folded attachments pane for a few seconds.
P.s.: the text string says "There had been added 1 attachment. Make sure it does not contain any sensitive information before sending the message." ...but "there had been added" is grammatically incorrect; the first sentence should probably read "This email contains %d attachment."