history appears to be able to grow indefinitely
While testing !271 (merged), I discovered what I think might be a bug in master
- I
think there's an off-by-one or something in the history list work, where behavior like:
- click link A on Page 1
- jump back
- click link B on Page 2
- jump back
- click link C on Page 3
- jump back
allows you to then
- jump back
- jump back
And go through previous history entries. Note this only works if the links are on different pages.
Expected: once I've "gone back" to an entry and then moved forward in history, the previously-visited entry shouldn't be visited again.
I think my proposed fix for !271 (merged) exacerbates the issue: there's code in ev_history_add_page
that skips adding an entry to history if the entry being added is the current entry, but with the targeted backlinks, that code isn't executed anymore (and wouldn't work properly if it was).