Follow-up from "Improve most visited page"
The following discussion from !370 (merged) should be addressed:
-
@mcatanzaro started a discussion: (+4 comments) I noticed one more problem. The size of the overview snapshots taken by the snapshot service is designed to be twice the size we actually display in the overview, to ensure the display is crisp on hidpi screens. But now that you've increased the size of the overview items, I'm worried they could be blurry on hidpi. I really like the larger size; we just need to think about this and adjust the size of the images we save accordingly.
I'm having some difficulty determining what the width of the overview items is -- it's not obvious to me how that's computed, since it's not specified in the CSS -- but I see the height changes from 160px at full size down to 120px below 341px screen size. So the height of the images we save should be at least 320px, but currently the height is only 270px (defined at the top of ephy-snapshot-service.h). I'm not sure what the width should be, though, because I can't see from the CSS what the width of the images is.
The good news is this is really easy to deal with: just change the values at the top of ephy-snapshot-service.h to whatever we want, then the next time the user visits the page the snapshot will be updated, so there's no need for any complicated migration.
We only need to add source code comments now to cross-reference between the CSS and the mysterious sizes in ephy-snapshot-service.h. CC: @bertob