ephy-file-helpers test is still doing evil things
I had an awful time trying to release 3.31.4 tonight due to our newly-reenabled friend ephy-file-helpers-test.c. I'm too tired to think it through right now, so I'm just going to disable it and make the release. But with test-ephy-file-heplers enabled, I need to make this change in ephy_web_application_create()
for test-web-app-utils to pass:
/* Create the profile directory, populate it. */
- if (g_mkdir (profile_dir, 488) == -1) {
- LOG ("Failed to create directory %s", profile_dir);
- goto out;
+ if (g_mkdir_with_parents (profile_dir, 488) == -1) {
+ g_warning ("Failed to create directory %s", profile_dir);
+ return NULL;
}
i.e. the file helpers test is deleting the parent directory of the web-app-utils test's profile directory, which is a big no-no as a nice well-behaved test should not be messing with the other tests. But I don't understand where or why it's doing this.