ephy_bookmarks_manager_save_to_file_async should actually be async
@mcatanzaro
Submitted by Michael Catanzaro Link to original bug (#772668)
Description
I was making a couple minor improvements to migrate_bookmarks, when I noticed a curious problem:
How is it that ephy_bookmarks_manager_save_to_file_async always finishes?
Then I revised the question:
How does it even do anything? There is no main loop!
Then I discovered that ephy_bookmarks_manager_save_to_file_async is a nice asynchronous-looking wrapper for a synchronous function call. Looks like I reviewed the code too fast. :) Since gvdb doesn't have an async API, we probably need to use g_task_run_in_thread(). (And then we'll need to update the profile migrator to use the sync version.)
Version: git master