1. 16 Jan, 2019 1 commit
  2. 15 Jan, 2019 1 commit
  3. 14 Jan, 2019 4 commits
  4. 13 Jan, 2019 2 commits
  5. 12 Jan, 2019 3 commits
  6. 10 Jan, 2019 1 commit
  7. 09 Jan, 2019 6 commits
  8. 08 Jan, 2019 13 commits
    • Michael Catanzaro's avatar
      Fix crash setting web app title without hostname · bb4dc57e
      Michael Catanzaro authored
      We probably shouldn't allow creating web apps for URIs without hostnames
      at all, but regardless, we should always check the result of
      soup_uri_get_host() because it could return NULL. Here we actually do
      that check, but don't guard enough of the code with it.
      
      Fixes #618
      bb4dc57e
    • Michael Catanzaro's avatar
      flatpak-utils: Remember if we're under flatpak · 2501fede
      Michael Catanzaro authored
      I added a bunch of asserts to ensure we're not running under flatpak
      when we shouldn't be. Maybe it makes sense to only check the filesystem
      once per thread, to avoid unnecessary I/O. A microoptimization, but an
      easy and uncomplicated one.
      2501fede
    • Michael Catanzaro's avatar
      file-helpers: further simplify application launching · c22a969d
      Michael Catanzaro authored
      Remove some unused parameters, make sure we warn on failure, convert to
      autoptrs, etc.
      c22a969d
    • Michael Catanzaro's avatar
      Make it harder to call functions that don't work under flatpak · b1b83d70
      Michael Catanzaro authored
      Since calling these functions now results in a crash, let's make it
      harder to use them by adding EphyFileHelpersNotFlatpakTag, which just
      forces the caller to pass an ugly enum value
      EPHY_FILE_HELPERS_I_UNDERSTAND_I_MUST_NOT_USE_THIS_FUNCTION_UNDER_FLATPAK
      in order to use any of the functions. Ugliness is a feature here, not a
      bug, to draw scrutiny to any code that might be using these functions.
      b1b83d70
    • Michael Catanzaro's avatar
      file-helpers: Remove unused functions · 98dff211
      Michael Catanzaro authored
      A lot of unused stuff in here!
      98dff211
    • Michael Catanzaro's avatar
      Simplify and fix opening files · cd0e4ef1
      Michael Catanzaro authored
      Opening files regressed in 7c8f19af.
      EphyDownload always passes NULL for MIME type, so we skip all the code
      for launching applications. Oops.
      
      Instead of reverting this commit, let's delete all the code! We can
      simplify file launching in several ways:
      
      (1) ephy_embed_shell_launch_handler() is no longer needed at all. It's a
      a wrapper around ephy_file_launch_handler() that just checks to ensure
      Epiphany is not launching itself, to avoid recursive launching. This is
      no longer needed because we no longer open files automatically under any
      circumstances, so recursive launching is no longer possible (unless the
      user manually opens the same file again and again for fun or something).
      Remove this function altogether. EphyDownload can use
      ephy_file_launch_handler() directly instead.
      
      (2) Delete the test for ephy_embed_shell_launch_handler(), since it only
      tests to ensure we avoid recursive launching, which is, again, no longer
      a problem.
      
      (3) ephy_file_launch_handler() doesn't actually need the MIME type for
      anything, except for use by ephy_file_browse_to(). So get rid of it from
      all associated functions. Reimplement ephy_file_browse_to() without it.
      (The MIME type used to be important for making sure it's safe to
      automatically open a file, but we never do that anymore.) A mistake
      regarding the MIME types is what introduced the bug that triggered this
      investigation, so eliminating it altogether seems worth it, especially
      when it's only used in the corner case of ephy_file_browse_to().
      
      (4) Make ephy_file_launch_handler() automatically launch via URI handler
      when running in flatpak. This way, higher-level code no longer needs to
      decide between using ephy_file_launch_handler() and
      ephy_file_launch_file_via_uri_handler() based on whether flatpak is in
      use.
      
      (5) ephy_file_launch_file_via_uri_handler() and
      ephy_file_launch_via_uri_handler() no longer need to be public, and can
      be compressed into one function. ephy_file_launch_application also no
      longer needs to be public.
      
      (6) Add assertions to ephy_file_browse_to(),
      ephy_file_launch_desktop_file(), and
      ephy_file_open_uri_in_default_browser() to ensure they are never called
      when running in flatpak, since it's impossible to make them work
      (because the only way to open files in flatpak is via the OpenURI
      portal, which gives the user, not the application, the choice of which
      application to open). It's already impossible for any of these functions
      to be called inside flatpak. (Hopefully! :)
      
      I tried to split this up into separate commits, but it got rather
      complicated, so here it is as an all-in-one.
      
      Note this consequently fixes opening downloaded files in flatpak, albeit
      not in the simplest-possible way.
      cd0e4ef1
    • Michael Catanzaro's avatar
      Purge g_assert() under tests/ · d79d53aa
      Michael Catanzaro authored
      The documentation of g_assert() says it is not intended for use in
      tests.
      d79d53aa
    • Michael Catanzaro's avatar
      Downloads dir should always be ~/Downloads in flatpak · 0cd3d12f
      Michael Catanzaro authored
      This was a mistake in 9d54c689. It doesn't make sense for the downloads
      directory to ever be ~/Desktop under flatpak, because it won't ever be
      writable. (I'm not sure why it passes on our CI; maybe the tests don't
      actually run inside the flatpak sandbox?) Better to just skip this test
      under flatpak.
      0cd3d12f
    • Piotr Drąg's avatar
      Update POTFILES.in · 3ef7bf85
      Piotr Drąg authored
      3ef7bf85
    • Michael Catanzaro's avatar
      web-app-utils: print warning when web app creation fails · ccc97157
      Michael Catanzaro authored
      Web app creation failure is a big deal. This merits more than a debug
      logging statement.
      ccc97157
    • Michael Catanzaro's avatar
      window: ignore keep-window-open in automation mode · b5ed7abb
      Michael Catanzaro authored
      WebDriver tests are going to have a hard time if the window stays open
      after the last tab is closed, so ignore our new setting in that case.
      b5ed7abb
    • Michael Catanzaro's avatar
      Prepare 3.31.4 · 312222a9
      Michael Catanzaro authored
      312222a9
    • Michael Catanzaro's avatar
      Disable file helpers test again · 84308043
      Michael Catanzaro authored
      See: #617
      84308043
  9. 07 Jan, 2019 2 commits
    • Jan-Michael Brummer's avatar
      Add internal pdf viewer using evince · 91508a2b
      Jan-Michael Brummer authored
      Based on an initial patch by: Carlos Garcia Campos
      
      Fixes: #264
      91508a2b
    • Michael Catanzaro's avatar
      bookmark: ensure tags sequence is always created · 672cffa5
      Michael Catanzaro authored
      Somehow we are getting EphyBookmarks objects deserialized without
      initializing the tags property. I'm not sure how this happens. It even
      happens for JSON corresponding to bookmarks that definitely have tags
      set. Anyway, ephy_bookmark_get_tags() is used as if the result is not
      nullable, so let's guarantee this and return an empty list instead in
      this case.
      
      This is a speculative fix for #612. It should fix the reported crash,
      but it's possible it will only uncover a subsequent crash.
      672cffa5
  10. 06 Jan, 2019 2 commits
  11. 05 Jan, 2019 3 commits
  12. 04 Jan, 2019 2 commits