Commit 252cc3c1 authored by Michael Catanzaro's avatar Michael Catanzaro

EphyEmbed: fix leak setting the title property

Direct leak of 178 byte(s) in 3 object(s) allocated from:
    #0 0x7fce2bc1ba0a in malloc (/lib64/libasan.so.2+0x98a0a)
    #1 0x7fce1d271068 in g_malloc
/home/mcatanzaro/jhbuild/checkout/glib/glib/gmem.c:94
    #2 0x7fce1d27134a in g_malloc_n
/home/mcatanzaro/jhbuild/checkout/glib/glib/gmem.c:330
    #3 0x7fce1d28c077 in g_strdup
/home/mcatanzaro/jhbuild/checkout/glib/glib/gstrfuncs.c:363
    #4 0x7fce1d5b5186 in g_value_dup_string
/home/mcatanzaro/jhbuild/checkout/glib/gobject/gvaluetypes.c:1136
    #5 0x49020c in ephy_embed_set_property
/home/mcatanzaro/jhbuild/checkout/epiphany/embed/ephy-embed.c:444
    #6 0x7fce1d58ef42 in object_set_property
/home/mcatanzaro/jhbuild/checkout/glib/gobject/gobject.c:1421
    #7 0x7fce1d58fbd4 in g_object_new_internal
/home/mcatanzaro/jhbuild/checkout/glib/gobject/gobject.c:1814
    #8 0x7fce1d59071a in g_object_new_valist
/home/mcatanzaro/jhbuild/checkout/glib/gobject/gobject.c:2039
    #9 0x7fce1d58f6c5 in g_object_new
/home/mcatanzaro/jhbuild/checkout/glib/gobject/gobject.c:1623
    #10 0x427214 in ephy_shell_new_tab_full
/home/mcatanzaro/jhbuild/checkout/epiphany/src/ephy-shell.c:694
    #11 0x459433 in session_parse_embed
/home/mcatanzaro/jhbuild/checkout/epiphany/src/ephy-session.c:1067
    #12 0x4595c8 in session_start_element
/home/mcatanzaro/jhbuild/checkout/epiphany/src/ephy-session.c:1113
    #13 0x7fce1d26deb9 in emit_start_element
/home/mcatanzaro/jhbuild/checkout/glib/glib/gmarkup.c:1049
    #14 0x7fce1d26ea4e in g_markup_parse_context_parse
/home/mcatanzaro/jhbuild/checkout/glib/glib/gmarkup.c:1396
    #15 0x459e2c in load_stream_read_cb
/home/mcatanzaro/jhbuild/checkout/epiphany/src/ephy-session.c:1266
    #16 0x7fce1d83ac11 in async_ready_callback_wrapper
/home/mcatanzaro/jhbuild/checkout/glib/gio/ginputstream.c:529
    #17 0x7fce1d871911 in g_task_return_now
/home/mcatanzaro/jhbuild/checkout/glib/gio/gtask.c:1104
    #18 0x7fce1d87196e in complete_in_idle_cb
/home/mcatanzaro/jhbuild/checkout/glib/gio/gtask.c:1118
    #19 0x7fce1d26b430 in g_idle_dispatch
/home/mcatanzaro/jhbuild/checkout/glib/glib/gmain.c:5441
    #20 0x7fce1d268a78 in g_main_dispatch
/home/mcatanzaro/jhbuild/checkout/glib/glib/gmain.c:3153
    #21 0x7fce1d2698bc in g_main_context_dispatch
/home/mcatanzaro/jhbuild/checkout/glib/glib/gmain.c:3769
    #22 0x7fce1d269aa0 in g_main_context_iterate
/home/mcatanzaro/jhbuild/checkout/glib/glib/gmain.c:3840
    #23 0x7fce1d269b64 in g_main_context_iteration
/home/mcatanzaro/jhbuild/checkout/glib/glib/gmain.c:3901
    #24 0x7fce1d8a349d in g_application_run
/home/mcatanzaro/jhbuild/checkout/glib/gio/gapplication.c:2311
    #25 0x4247ca in main
/home/mcatanzaro/jhbuild/checkout/epiphany/src/ephy-main.c:484
    #26 0x7fce1c3ca6ff in __libc_start_main (/lib64/libc.so.6+0x206ff)
parent 25c3734d
......@@ -447,7 +447,7 @@ ephy_embed_set_property (GObject *object,
embed->priv->web_view = g_value_get_object (value);
break;
case PROP_TITLE:
ephy_embed_set_title (embed, g_value_dup_string (value));
ephy_embed_set_title (embed, g_value_get_string (value));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment