Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Epiphany Epiphany
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 294
    • Issues 294
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • EpiphanyEpiphany
  • Merge requests
  • !913

web-view: fix reloading crashed pages

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Michael Catanzaro requested to merge mcatanzaro/#1447 into master Feb 16, 2021
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

When the web process crashes, we generate an error page that reloads the view's current URI when the reload button is pressed. Unfortunately, since WebKit r268097, the current URI is now an empty string at the time of crash because the web process termination signal is dispatched asynchronously after WebKit has already updated the view to contain an empty page. This means we have to manually keep track of the previous value of the URI. Arguably, this is a bug in WebKit, but it seems tough to fix there and we need a workaround for now.

Note that the web process termination signal is currently only being sent when running under flatpak. Outside flatpak, the signal is not sent at all. That is a separate issue (WebKit#221489) that we will not fix here.

Fixes #1447 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mcatanzaro/#1447