Skip to content

window: Forward key events directly to web view when appropriate

Michael Catanzaro requested to merge mcatanzaro/key-event-fixes into master

Most (but not all) key press events should be processed by the web view before global accelerators are run. All key release events should, too. However, if we do this, then we need some changes in WebKit:

  • It has to stop reinjecting events, since this causes an infinite event processing loop. This means WebKit needs to handle all events.
  • It has to start manually activating our action accelerators, since by sending events to the web view first, the GtkWindow never sees them.

See the comment embedded in this commit for the gory details.

This change depends on:

Fixes #1915 (closed) Fixes #2173 (closed)

Merge request reports