Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Epiphany Epiphany
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 297
    • Issues 297
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • EpiphanyEpiphany
  • Merge requests
  • !1073

GTK4

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Alice Mikhaylenko requested to merge wip/exalm/gtk4 into master Feb 18, 2022
  • Overview 73
  • Commits 5
  • Pipelines 99
  • Changes 181

Let's open a draft.

Cleanups split from this branch so far:

  • !1034 (merged)
  • !1035 (merged)
  • !1036 (merged)
  • !1038 (merged)
  • !1071 (merged)
  • !1072 (merged)
  • !1074 (merged)
  • !1075 (merged)
  • !1077 (merged)
  • !1081 (merged)
  • !1083 (merged)
  • !1085 (merged)
  • !1089 (merged)
  • !1090 (merged)
  • !1096 (merged)

Still tons of things missing, TODO (a bit of a braindump):

  • embed/
    • contrib/gd-tagged-entry.c - needs a rewrite
    • ephy-download.c - monotonic/current event time
    • ephy-embed.c - floating bar doesn't move correctly
    • ephy-find-toolbar.c
      • replace the placeholder entry with something proper
      • shortcuts
    • ephy-web-view.c - key and button events
  • lib/
    • widgets/
      • contrib/nautilus-floating-bar.c - hover, uncomment
      • ephy-certificate-dialog.c - needs gcr!82 (merged)
      • ephy-download-widget.c - drag source
      • ephy-downloads-popover.c - GDK_CURRENT_TIME might be wrong
      • ephy-downloads-progress-icon.c - rewrite
      • ephy-location-entry.c
        • suggestions
          • dns prefetch
          • scrolling on focus - needs gtk!4476 (closed)
          • favicons don't seem to load
          • when moving the window, the popover doesn't disappear
          • there's a behavior difference with hover/keynav interaction
        • keys
        • context menu
        • figure out undo/redo - GtkText can already do it in 4
          • undo on esc
        • page actions
        • primary clipboard
        • normalize url on cut/copy
      • ephy-location-entry-old.c - remove once location entry is done
      • ephy-security-popover.c
        • relative-to/parent
        • integrate the cert dialog
    • ephy-dnd.c - uncomment, probably rewrite
    • ephy-gui.c - kill ephy_gui_get_current_event()
  • src/
    • bookmarks/
      • ephy-add-bookmark-popover.c - relative-to/parent
        • Default focus doesn't work
      • ephy-bookmarks-popover.c - middle click and flags
    • preferences/
      • ephy-data-view.c - shortcuts
      • ephy-prefs-dialog.c
        • shortcuts
        • delete event
      • prefs-appearance-page.c - lost custom fonts in combo row
      • prefs-general-page.c - languages list has complex dnd
    • resources/style.css
      • entry icons
      • downloads button
      • language rows
    • webextension/web-extension-manager.c - destroy fixme
    • ephy-action-bar-end.c
      • integrate add bookmark popover
      • theatrics
    • ephy-action-bar-start.c
      • back/forward menu
        • regressed hidpi favicons
      • middle clicking buttons
    • ephy-firefox-sync-dialog.c
      • integrate synced tabs code
    • ephy-fullscreen-box.c - focus
    • ephy-header-bar.c - integrate add bookmark popover
    • ephy-history-dialog.c - shortcuts, type to search
    • ephy-link.c - kill ephy_link_flags_from_current_event()
    • ephy-location-controller.c
      • dnd
      • ephy_link_flags_from_current_event()
      • suggestion model
    • ephy-lockdown.c - uncomment actions
      • bookmark page
      • context bookmark page
    • ephy-mouse-gesture-controller.c - uncomment
    • ephy-pages-popover.c - messed up styling
    • ephy-pages-view.c - messed up styling
    • ephy-shell.c - monotonic/event time
    • ephy-tab-view.c - dnd
    • ephy-window.c
      • key press event
      • undo/redo
      • save
      • save app
      • cut/copy/paste
      • bookmark page
      • context bookmark page
      • location search
      • integrate new location entry
      • move/resize,
      • context menu - needs https://bugs.webkit.org/show_bug.cgi?id=233785
      • integrate mouse gestures
      • window state event
      • should save state
      • lock clicked
      • default browser
      • delete event
      • destroy
    • synced-tabs-dialog.c - uncomment
    • popup-commands.c - filename suggested
    • window-commands.c
      • add bookmarks popover
      • save as app
      • save as
      • undo/redo
      • cut/copy/paste
      • paste as plain text
      • open bookmark flags
      • bookmark page
      • location search
  • tests/
    • uncomment history test
    • uncomment location test
    • encodings test fails (might be preexisting)

Probably a bunch of new bugs as well - too early to report them just yet.

Edited Aug 23, 2022 by Alice Mikhaylenko
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/exalm/gtk4