Sort out history dialog and incognito mode
So, I recently learned that you can still open history dialog from incognito windows, but can't delete history in this case.
So, I checked what other browsers do:
- Chrome: doesn't allow opening history in incognito windows
- Firefox, Safari: the history dialog is independent of normal/incognito windows and allows deleting history in any case
Now, there are a few things to distinguish:
- There's history from non-incognito windows that we show in the history dialogs, opened from incognito mode windows or not. It's technically impossible to delete it from incognito mode history dialogs.
- There's history from browsing in incognito windows. I was told it's supposed to work, but right now it doesn't seem to end up in any history dialogs, and I'm not sure how it's supposed to work really
So this has some weird implications right now:
- If incognito history is supposed to work, it would mean that if you accidentally visit a website you don't want in your history, in normal mode deleting it is as simple as opening history dialog and deleting it. Meanwhile, in an incognito window it would be impossible and the website will still be in the history until you close the window.
- The incognito history dialog looks exactly same as any other history dialog, so it's entirely possible to have 2 identical history dialogs open at the same time, showing the same history, but one of them allows deleting history and the other one doesn't.
So, what we could do:
- Disallow opening history dialog from incognito windows
- Only show history from the current incognito window in an incognito history dialog. Then there's no need to restrict removal
- Untie history dialog from a specific window. I'm not sure why it's window-dependent in the first place, previously it was an app-wide action. Like the preferences or about dialogs are currently same regardless of where you opened them from, I don't see why this dialog would be different.
- Anything else?
CC @bertob after you come back from your vacation.