Michael Catanzaro authored Jan 24, 2023 and Marge Bot committed Jan 28, 2023

https://commits.webkit.org/259285@main

Part-of: <!1269>

Michael Catanzaro authored Jan 24, 2023 and Marge Bot committed Jan 28, 2023

https://commits.webkit.org/259218@main

Part-of: <!1269>

Michael Catanzaro authored Jan 26, 2023 and Marge Bot committed Jan 27, 2023

WebKit threaded rendering is busted because it's not actually
threadsafe. But maybe it will work in practice if we use only one
thread? Let's find out.

Part-of: <!1270>

Michael Catanzaro authored Jan 16, 2023 and Michael Catanzaro committed Jan 25, 2023

These are useless. One fewer thing to think about. Goodbye.

gtk#4904

Part-of: <!1264>

This reverts commit 50fb7083

Michael Catanzaro authored Jan 19, 2023 and Marge Bot committed Jan 20, 2023

The sandbox is now mandatory.

Part-of: <!1266>

History window height is unnecessary big, a problem that also existed in the Preferences dialog (#1705)

This commit makes the History window to have the same height used in the Preferences dialog.

Part-of: <!1263>

Michael Catanzaro authored Jan 06, 2023 and Marge Bot committed Jan 06, 2023

The underlying API was just removed in gtk!5396, so we have to stop
using it. This is fine, though, because all it does is add the downloads
folder to the file chooser sidebar, which is redundant because XDG
directories are already there by default for a decade or so now. So this
code is not useful and can disappear.

Thanks to Alexander for telling me exactly what to do here.

Part-of: <!1261>

We can't build against 4.9.1 due to the GtkFileDialog API changes.

Part-of: <!1260>

Jan-Michael Brummer authored Dec 28, 2022 and Marge Bot committed Jan 05, 2023

Fixes: #1811
Part-of: <!1252>

Michael Catanzaro authored Jan 04, 2023 and Marge Bot committed Jan 05, 2023

The only remaining function here is ephy_gui_help(). It's used in only
one place, and can be replaced with a single line of code. Goodbye
ephy-gui!

Part-of: <!1256>

Michael Catanzaro authored Jan 04, 2023 and Marge Bot committed Jan 05, 2023

Coverity discovered a use-after-free in ephy_gui_ensure_window_group(),
where the newly-created GtkWindowGroup is freed immediately before it is
returned. This could only possibly make sense if GtkWindowGroup has very
weird refcounting semantics, but there is no indication of this in its
documentation. Fortunately, the buggy code is unreachable because it
only occurs if gtk_window_get_group() returns NULL, which is impossible
because the function is not nullable. It will always return the default
window group, not NULL. This means the entire condition can be removed,
so ephy_gui_ensure_window_group() can be simplified to just return
gtk_window_get_group() without changing behavior. But none of the
callers actually look at the return value. And gtk_window_get_group()
has no side-effects, so it does not "ensure" anything. Therefore all of
this code is doing nothing, and can be safely removed.

Part-of: <!1256>

Jan-Michael Brummer authored Dec 27, 2022 and Marge Bot committed Jan 04, 2023

Fixes: #1934
Part-of: <!1246>

Michael Catanzaro authored Jan 04, 2023 and Marge Bot committed Jan 04, 2023

If we fail to create the file monitor for the user JS file, then we free
the error twice by mistake. Uh-oh. Found by Coverity.

Part-of: <!1257>

Michael Catanzaro authored Jan 04, 2023 and Marge Bot committed Jan 04, 2023

Let's use g_autofree and g_autoptr here. This notably avoids use of the
EphyDownload after we have dropped our ref on it, which Coverity doesn't
like. It's not a problem in practice because the EphyDownloadsManager
will still have a ref, but we should fix it anyway.

Part-of: <!1257>

Michael Catanzaro authored Jan 04, 2023 and Marge Bot committed Jan 04, 2023

This is not a serious problem because
ephy_web_extension_manager_add_to_list() will take a ref, but we should
still not use it after we've dropped our local ref.

Part-of: <!1257>

Michael Catanzaro authored Jan 04, 2023 and Marge Bot committed Jan 04, 2023

We use bookmark later on after the ref has already been dropped, which
is no good. Found by Coverity.

This should not be a problem in practice because the
EphyBookmarksManager will keep the bookmark alive, but it's not good to
rely on this. We should have our own ref for as long as we're using the
bookmark.

Part-of: <!1257>

sunflowerskater authored Jan 02, 2023 and Michael Catanzaro committed Jan 04, 2023

HIG says that all controls located at the headerbar must have a tooltip.

This commit adds the necessary tooltip to the "Main Menu" button.

Part-of: <!1242>

sunflowerskater authored Dec 25, 2022 and Michael Catanzaro committed Jan 04, 2023

Currently, several tooltips are way long and don't use header capitalization.

This commit shortens the tooltips and adds header capitalization to follow HIG guidelines:
https://developer.gnome.org/hig/patterns/feedback/tooltips.html?highlight=tooltips

Part-of: <!1242>

These are hardly comprehensive, but they'll ensure the functions are not
totally broken and would have caught issue #1930.

Note that we don't seem to be handling IDN properly currently, so I've
left some comments about that.

Part-of: <!1245>

Jan-Michael Brummer authored Dec 27, 2022 and Michael Catanzaro committed Dec 30, 2022

Fixes: #1930
Part-of: <!1245>

Michael Catanzaro authored Dec 29, 2022 and Marge Bot committed Dec 30, 2022

The signal parameters are swapped here by mistake, causing a web process
crash when submitting forms.

Part-of: <!1255>

These website data types are gone in the next WebKitGTK version.

Part-of: <!1254>