1. 16 Sep, 2021 1 commit
  2. 31 Aug, 2021 1 commit
    • Michael Catanzaro's avatar
      passwords-view: fix the Clear All action · 77f5e039
      Michael Catanzaro authored and Michael Catanzaro's avatar Michael Catanzaro committed
      Apparently people don't try to delete all their passwords very often,
      because this has been broken for the past year and nobody noticed until
      now. Whatever. The dialog is no longer a GtkWindow so we just have to
      find the parent window instead.
      
      Fixes #1570
      
      Part-of: <!993>
      
      
      (cherry picked from commit c084516e)
      77f5e039
  3. 12 Aug, 2021 1 commit
  4. 11 Jul, 2021 1 commit
  5. 12 Jun, 2021 1 commit
  6. 04 Jun, 2021 1 commit
  7. 07 May, 2021 3 commits
  8. 05 May, 2021 1 commit
  9. 01 May, 2021 1 commit
  10. 29 Apr, 2021 6 commits
    • Michael Catanzaro's avatar
      Fix crash when importing bookmarks from Firefox · ef84eb50
      Michael Catanzaro authored
      The problem is the strings returned by get_firefox_profiles() are freed
      with g_free(), which is correct, but we are actually returning pointers
      into the middle of the allocated region, rather than pointers to the
      start of the string. Truncating a string using pointer arithmetic is a
      nice trick for unowned strings, but for owned strings it doesn't work.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1946648
      
      
      (cherry picked from commit 7e31b93d)
      ef84eb50
    • Michael Catanzaro's avatar
      Prepare 3.38.4 · 725471b5
      Michael Catanzaro authored
      725471b5
    • Michael Catanzaro's avatar
      window: launch URLs whenever triggered by user gesture · 899e32c7
      Michael Catanzaro authored
      Currently we check the default app for the URI scheme and call
      gtk_show_uri_on_window() only if the default app is not NULL and is not
      Epiphany. This fails under flatpak because there we cannot check the
      user's default apps. It is always NULL, so we bail out and refuse to
      launch any app for the URL. Oops.
      
      This code was originally added to prevent us from launching Epiphany in
      a recursive loop if it somehow gets registered as the default handler
      for a scheme that it doesn't actually support, as in #1053. In this
      case, we should only relaunch ourselves once because the second launch
      will be triggered by API request, when the new instance calls
      webkit_web_view_load_uri(). That's not a user gesture and will avoid the
      recursion.
      
      This change also prevents websites from opening URLs without user
      intervention.
      
      Thanks to Adrian Perez for proposing this solution!
      
      Fixes #1385
      
      Part-of: <!951>
      899e32c7
    • Michael Catanzaro's avatar
      Bring back the custom CI container · c367e5e4
      Michael Catanzaro authored
      This is based on Jan-Michael's previous work, modified to use our custom
      container image with scan-build as well, and to retain the eslint check.
      c367e5e4
    • Michael Catanzaro's avatar
      Run uncrustify check in parallel with other checks · 9c43f7fc
      Michael Catanzaro authored
      This will speed up our CI by 1-2 minutes or thereabouts
      
      
      (cherry picked from commit a46d2cf2)
      9c43f7fc
    • Michael Catanzaro's avatar
      Add missing test dependencies to fix CI · d35b03c9
      Michael Catanzaro authored
      See gnome-build-meta#372
      
      
      (cherry picked from commit c40a2be7)
      d35b03c9
  11. 30 Mar, 2021 1 commit
  12. 29 Mar, 2021 1 commit
  13. 28 Mar, 2021 3 commits
  14. 25 Mar, 2021 1 commit
  15. 23 Mar, 2021 1 commit
  16. 22 Mar, 2021 2 commits
  17. 21 Mar, 2021 2 commits
  18. 20 Mar, 2021 3 commits
  19. 19 Mar, 2021 4 commits
  20. 12 Mar, 2021 4 commits
    • Michael Catanzaro's avatar
      Prepare 3.38.3 · 1c87559f
      Michael Catanzaro authored
      1c87559f
    • Michael Catanzaro's avatar
      Silence deprecation warnings · ae79d02b
      Michael Catanzaro authored
      Our CI uses -Werror and so is failing on the stable branch. These
      function calls are already removed on master.
      ae79d02b
    • Michael Catanzaro's avatar
      Revert "embed-prefs: Disable automatic window open via javascript" · 788d7a8c
      Michael Catanzaro authored
      This reverts commit b37ef802.
      
      Looks like we were too aggressive here. WebKit's default behavior may
      not actually be suitable for browsers. It broke the VMWare vSphere web
      console.
      
      Fixes #1467
      788d7a8c
    • Michael Catanzaro's avatar
      Fix potential loss of session state when web process is unresponsive · 3ee42350
      Michael Catanzaro authored
      If any web process is unresponsive when the window is closed using the
      close button in the header bar -- not Ctrl+Q -- then the entire session
      state is lost. Disaster! This happens to me three or four times per
      year, and it is sad because it inevitably results in me forgetting
      important things I had to do.
      
      Anyway, the problem is our code to handle an unresponsive web process.
      We'd like to cancel the JavaScript execution using
      g_cancellable_cancel(), but it doesn't work because the underlying
      WebKit operation is not actually cancellable, so instead we use a big
      hammer and gtk_widget_destroy() the EphyWebView. Then when we wind up
      closing the session later, there are no tabs open and nothing to save.
      It was tricky to figure out how to fix this, because the only way to
      truly cancel the operation is to destroy the web view, and if we do that
      then we have to close the session first to avoid losing tabs, but the
      user could legitimately choose to reject a modified forms close
      confirmation warning, in which case they would wind up using Epiphany
      after the session is closed, meaning all subsequent changes to open tabs
      would be lost since they won't be saved after the session is closed.
      
      Eventually I realized that we can just move the timeout from EphyWindow
      -- where it's handled in two separate places, once for closing a single
      tab, and once for closing an entire window -- down into EphyWebView
      itself. This solves all our problems because now EphyWindow can assume
      the JS execution always completes in a reasonable time.
      
      I tested this by changing the call to
      webkit_web_view_run_javascript_in_world() in
      ephy_web_view_has_modified_forms() to execute a while(true) loop.
      Without the other changes, the session state is lost if closing the
      window using the close button in the header bar. With this patch, the
      session state is no longer lost.
      
      Fixes #1445
      3ee42350
  21. 13 Feb, 2021 1 commit