Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Eye of GNOME Eye of GNOME
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • Eye of GNOMEEye of GNOME
  • Merge requests
  • !142

Avoid critical warnings when saving images on exit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Felix Riemann requested to merge wip/friemann/fix-close_save-warnings into master Nov 17, 2022
  • Overview 0
  • Commits 4
  • Pipelines 3
  • Changes 4

This fixes multiple cricitical warnings when saving image while closing a window:

  1. The general save callback and the specific callback for saving images on exit both clear the window's save job. The second callback triggering will then cause a critical warning. Instead of manually clearing the job, use g_clear_object which avoids that warning.

  2. EogApplication could trip over an unexpected NULL pointer eog_window_get_image() when checking if a newly opened image is already open in any of the active windows.

  3. EogListStore didn't properly cancel its thumbnail jobs while disposing. They could then asynchronously trigger the finish callback after the liststore was already finalized.

Fixes #263 (closed).

Edited Jan 07, 2023 by Felix Riemann
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/friemann/fix-close_save-warnings