Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Eye of GNOME Eye of GNOME
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • Eye of GNOMEEye of GNOME
  • Merge requests
  • !125

eog-sidebar: Replace GtkMenu with GtkPopover

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Krifa75 requested to merge Krifa75/eog:popover-sidebar into master Feb 25, 2022
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

Just a small improvement and make it less complicate.

here is a preview :

popover

However, if I may, I'm wondering why it uses widget_class->destroy instead of the usual dispose, and, if the GtkListStore is really necessary. The index in the menu (whether in the previous GtkMenu or now in the GtkListBox) should be the same as the widget appended in the GtkNotebook, no ? 🤔

Thanks !

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: popover-sidebar