1. 04 Oct, 2014 1 commit
    • Hans Breuer's avatar
      [warningectomy] remove unused variables and functions · 70e10d07
      Hans Breuer authored
      the special text editing 'accumulating' was unfinished for too long.
      Now it's gone with it's warnings.
      
      textedit.c:148:19: warning: unused variable 'change' [-Wunused-variable]
        TextEditChange *change;
                        ^
      textedit.c:370:1: warning: unused function 'text_edit_create_change' [-Wunused-function]
      text_edit_create_change(Text *text)
      ^
      textedit.c:394:1: warning: unused function 'text_edit_update' [-Wunused-function]
      text_edit_update(TextEditChange *change)
      ^
      70e10d07
  2. 09 Jun, 2014 1 commit
    • Hans Breuer's avatar
      [scan-build] Dereference of null pointer (maybe) · 840f8754
      Hans Breuer authored
      Protect potential null pointer access with g_return_if_fail().
      Remaining warnings show the unfinished state of focus handling:
      
      textedit.c: In function ‘textedit_end_edit’:
      textedit.c:148:19: warning: unused variable ‘change’ [-Wunused-variable]
         TextEditChange *change;
                         ^
      textedit.c: In function ‘textedit_remove_focus’:
      textedit.c:303:10: warning: unused variable ‘old_focus’ [-Wunused-variable]
         Focus *old_focus = get_active_focus((DiagramData *) diagram);
                ^
      textedit.c: At top level:
      textedit.c:370:1: warning: ‘text_edit_create_change’ defined but not used [-Wunused-function]
       text_edit_create_change(Text *text)
       ^
      textedit.c:394:1: warning: ‘text_edit_update’ defined but not used [-Wunused-function]
       text_edit_update(TextEditChange *change)
       ^
      textedit.c:303:10: warning: Value stored to 'old_focus' during its initialization is never read
        Focus *old_focus = get_active_focus((DiagramData *) diagram);
               ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 warning generated.
      840f8754
  3. 31 Jan, 2014 2 commits
  4. 29 Dec, 2009 1 commit
  5. 04 Oct, 2009 1 commit
    • Hans Breuer's avatar
      Bug 576548 - Refactoring of highlighting in interactive rendering · ec094387
      Hans Breuer authored
      The previous implementation was keeping the state in every object
      (DiaObject::highlight_color) and in the renderer to support it: e.g.
      DiaGdkRenderer::highlight_color. But the real highlighting state is managed by
      the diagram (where it needs to be).
      We got rid of the object knowing about highlight state;  provide methods in
      the InteractiveRenderer interface to perform highlighted rendering and have
      something like a "highlighting selection" (similar to standard selection)
      to manage which object should be rendered highlighted.
      
      From: Heikki Paajanen <hepaajan@iki.fi>
      Date: Thu, 28 May 2009 18:37:49 +0300
      Subject: Refactoring of highlighting in interactive rendering
      
      https://bugzilla.gnome.org/attachment.cgi?id=135703
      
      From: Hans Breuer <hans@breuer.org>
      Date: Sat, 30 May 2009 14:07:08 +0200
      Subject: Bug 576548 - Highlighting cleanup second iteration
      
      https://bugzilla.gnome.org/attachment.cgi?id=135704
      
      * app/display.c : don't crash if the renderer does not support highligthing
      * lib/diagramdata.[ch] : renamed some functions and more consistent format
      * app/highlight.c app/object_ops.c : reflect renaming
      * lib/libdia.def : export highlight accessors
      * lib/plug-ins.h : increment API_VERSION, object size changed
      ec094387
  6. 07 Jul, 2009 1 commit
  7. 31 May, 2009 1 commit
    • Hans Breuer's avatar
      Old DiagramTree ported to new change signaling mechanism · 9e65e515
      Hans Breuer authored
      To simplify the removal of the old DiagramTree it got ported to
      the new signaling mechanism via DiaApplication. Instead of
      sprinkling a lot of diagram_tree_*() calls through the code the
      DiagramTree object just listens on DiaApplication and Diagram
      to react on the relevant changes.
      
      Stuff like LayerDialog and 'recent files' should be ported, too.
      9e65e515
  8. 08 Feb, 2009 2 commits
    • Hans Breuer's avatar
      signed/unsigned mismatch different 'const' qualifiers constness doe not · a37a1fba
      Hans Breuer authored
      2009-02-08  Hans Breuer  <hans@breuer.org>
      
      	* lib/diagramdata.c : signed/unsigned mismatch
      	* lib/diagdkrenderer.c : different 'const' qualifiers
      	* lib/persistence.[ch] lib/message.c : constness
      	* app/autosave.c : doe not take a GCallback, but a GSourseFunc
      	* app/layer_dialog.c : gtk_button_set_image() takes a GtkWidget*
      	* app/textedit.c : s/ObjectChangeApplyFunc/UndoApplyFunc/ etc.
      	* plug-ins/wmf/wmf.cpp : explicit cast 'gunichar2 *' to 'W32::LPCWSTR'
      
      svn path=/trunk/; revision=4270
      a37a1fba
    • Hans Breuer's avatar
      [ warningectomy - about 40 left ] disable -Wunused, add a lot more useful, · 5948aaa1
      Hans Breuer authored
      2009-02-08  Hans Breuer  <hans@breuer.org>
      
      	[ warningectomy  - about 40 left ]
      	* configure.in : disable -Wunused, add a lot more useful, see:
      	http://blogs.gnome.org/otte/2008/12/22/warning-options/
      	* lib/dia_xml.c plug-ins/svg/render_svg.c : pointers differ in signedness
      	* lib/diagramdata.c : declared static but never defined
      	* lib/prop_dict.c lib/plug-ins.c : unused variable
      	* plug-ins/python/diamodule.c : dereferencing type-punned pointer will
      	break strict-aliasing rules, unused variables
      	* plug-ins/custom_line/line_info.c : mostly pointer targets differ in 
      	signedness, but also some superfluous allocations
      	* lib/prop_sdarray.c lib/prefs.c objects/standard/line.c 
      	  plug-ins/libart/dialibartrenderer.[ch] plug-ins/libart/render_libart.c
      	  objects/AADL/aadl.c app/layer_dialog.c : no previous prototype 
      	(aka: should be static, prototyped or deleted)
      	* plug-ins/dxf/autocad_pal.c : maybe used uninitialized
      	* app/confirm.c : format not a string literal and no format arguments
      	* plug-ins/postscript/paginate_psprint.c : use g_object_(g|s)et_data()
      	* (diagram_print_ps) : format not a string literal and no format arguments
      	  and g_free(g_get_home_dir()) - agood reason for crashing later on
      	* app/load_save.c(diagram_data_save) : may be used uninitialized
      	* objects/UML/association.c : removed unused functions
      	* app/exit_dialog.c : unused variable, format not a string literal and 
      	no format arguments
      	* app/menus.c : format not a string literal and no format arguments
      	* persistence.c : defined but not used
      	* objects/SISSI/*.[ch] : from around 100 warnings down to 2 ...
      	* objects/standard/arc.c : removed unused function
      	* lib/message.c : assignment discards qualifiers from pointer target type
      
      	* app/pixmaps/magnify.xpm app/pixmaps/scroll.xpm app/pixmaps.h : removed
      	* app/Makefile.am : adapted
      	* app/interfaces.c : added remaining XPMs directly
      
      
      svn path=/trunk/; revision=4269
      5948aaa1
  9. 03 Dec, 2007 1 commit
  10. 20 Oct, 2007 1 commit
    • Hans Breuer's avatar
      new database table relation shapes by Petr Novotnik - bug #397688 - · b083ef1f
      Hans Breuer authored
      2007-10-20  Hans Breuer  <hans@breuer.org>
      
      	* configure.in lib/libdia.def objects/Database 
      	  objects/Database/compound.c objects/Database/database.c
      	  objects/Database/database.h objects/Database/Makefile.am
      	  objects/Database/pixmaps/compound.xpm
      	  objects/Database/pixmaps/reference.xpm
      	  objects/Database/pixmaps/table.xpm
      	  objects/Database/reference.c objects/Database/table.c
      	  objects/Database/table_dialog.c objects/Makefile.am
      	  objects/makefile.msc po/POTFILES.in sheets/Database.sheet.in
      	  sheets/Makefile.am : new database table relation shapes by
      	Petr Novotnik - bug #397688 - slightly modified to work with current
      	SVN and build on windoze. Although derived from the UML class object
      	the 'Table' object looks like a much better playground for a generic
      	property list widget.
      
      	* app/textedit.c(textedit_activate_first) had an endless loop when
      	none of the selected objects are text editable
      	
      	* app/properties.c : resets current_obj when the dialog is closed
      	(Sameer D. Sahasrabuddhe, fixes bug #30430)
      
      	* objects/Misc/tree.c : added object_apply_props stuff
      
      
      svn path=/trunk/; revision=3822
      b083ef1f
  11. 14 Oct, 2007 1 commit
    • Hans Breuer's avatar
      Next stab on dedicated text edit mode: text edit mode reflected in · 7789ad55
      Hans Breuer authored
      2007-10-14  Hans Breuer  <hans@breuer.org>
      
      	Next stab on dedicated text edit mode:
      	* app/textedit_tool.[ch] app/tool.[ch] app/cursors.[ch] 
      	app/interface.c app/Makefile.am app/makefile.msc data/display-ui.xml 
      	data/integrated-ui.xml data/popup-ui.xml : text edit mode 
      	reflected in toolbox, it is too different from normal modification
      	* app/diagram.c app/menu.c : make Cut, Copy, Paste, Delete 
      	and Duplicate menu entries insensitive when text is edited
      	* app/pixmaps/textedit.png : an ugly icon
      	* app/create_object.c app/disp_callbacks.c : deal with transitions 
      	from one tool to to the other
      	* app/textedit.[ch](textedit_activate_object): tell if editing started
      
      svn path=/trunk/; revision=3813
      7789ad55
  12. 30 Sep, 2007 1 commit
  13. 17 Mar, 2007 1 commit
  14. 11 Mar, 2007 2 commits
  15. 18 Jun, 2005 1 commit
    • Hans Breuer's avatar
      fix for sloppiness in function declarations. 'f();' for a function without · 70390787
      Hans Breuer authored
      2005-06-18  Hans Breuer  <hans@breuer.org>
      
      	* app/textedit.[hc] lib/arrows.[hc] plug-ins/xslt/xslt.h
      	  plug-ins/xslt/xsltdialog.c plug-ins/xslt/xslt.c : fix for sloppiness
      	in function declarations. 'f();' for a function without parameters is
      	a C++ism. Though I can't get any of my compilers to warn about it.
      	Finally fixes bug #142663.
      70390787
  16. 06 Jun, 2005 1 commit
  17. 13 Mar, 2005 2 commits
    • Hans Breuer's avatar
      s/DiaSvgGraphicStyle/DiaSvgStyle/, added and use convenience functions · e39cdcfd
      Hans Breuer authored
      2005-03-13  Hans Breuer  <hans@breuer.org>
      
      	* lib/dia_svg.[hc] objects/custom/shape_info.[hc] plug-ins/svg/svg-import.c :
      	s/DiaSvgGraphicStyle/DiaSvgStyle/, added and use convenience functions
      	dia_svg_style_copy(), dia_svg_style_init()
      
      	* objects/custom/shape_info.c : use dia_svg_parse_path() from lib/ (it got
      	moved out of this)
      
      	* lib/dia_svg.c(dia_svg_parse_path) : also handle style properties which are
      	not wrapped in the style attribute
      
      	* plug-ins/svg/svg-import.c : implement nested group handling and style
      	'style inheritance'. Still no transformations, no <image/>, no <style/>
      	<defs/>...
      
      	* plug-ins/svg/svg-import.c(import_svg) : use message_warning instead of g_warning,
      	the latter is for programmers.
      	Also be more tolerant if the document root namespace is not 'svg'. If the svg
      	namespace is defined in the file search for the top node including svg. This
      	allows us to re-read the svg part of our own shape format.
      
      	* lib/libdia.def : there is no give_focus_to_object
      	* app/textedit.c : still no C99,  aka. error C2275: 'Focus' : illegal use of this
      	type as an expression
      
      	* lib/geometry. c : use G_IMPLEMENT_INLINES
      	* lib/libdia.def : export point_get_perp (used by xfig plug-in)
      
      	* app/textedit.c(textedit_end_edit) : don't crash if the display is already
      	gone when trying to remove the focus
      
      	* plug-ins/cairo/diacairo.c : CAIRO_HAS_WIN32_SURFACE does not any longer mean
      	it has *my* Cairo Win32 Backend. [The official one isn't useful for the use
      	case of this plug-in, i.e. producing output files]
      e39cdcfd
    • Lars Clausen's avatar
      Proper generation of icons files. · 6318de4f
      Lars Clausen authored
      6318de4f
  18. 11 Mar, 2005 1 commit
  19. 10 Mar, 2005 1 commit
  20. 09 Sep, 2004 1 commit
  21. 30 Aug, 2004 1 commit