Commit c89c08c0 authored by Eduard's avatar Eduard

#19: Code cleanup: s/FIXME/TODO/.

  - Also remove old TODO in top meson.build, those dependencies should
    be implicitly required by meson.
  - Also add separate dependency for libc
    (currently '-lc' flag is used; added "TODO").
parent 88b830d9
......@@ -63,7 +63,7 @@ dia_sources = [
'main.c'
]
#FIXME: this is workaround for openbsd where libraries are in /usr/lib/local
#TODO: this is workaround for openbsd where libraries are in /usr/lib/local
pkg_config = find_program('pkg-config')
pkg_config_libdir = run_command(pkg_config, '--libs-only-L', 'libxml-2.0').stdout().strip()
......
......@@ -23,7 +23,7 @@ icons = [ 'connectable.png',
'cursor-magnify-minus.png',
'cursor-magnify-plus.png' ]
#FIXME: this is duplicated from lib/pixmaps. Any way to remove this duplication?
#TODO: this is duplicated from lib/pixmaps. Any way to remove this duplication?
icon_pairs = []
foreach icon_file : icons
icon_pairs += ['dia_' + icon_file.split('.')[0].underscorify() + '_icon', files(icon_file)]
......
......@@ -92,7 +92,7 @@ if xsltproc.found()
install : true,
install_dir : join_paths(get_option('mandir'), 'man1')
)
# XXX: this should fixed in meson: https://github.com/mesonbuild/meson/issues/1550
# TODO: this should fixed in meson: https://github.com/mesonbuild/meson/issues/1550
#install_data(dia_man)
html_dir = join_paths(helpdir, 'en')
......
......@@ -6,6 +6,7 @@ project('dia',
default_options : []
)
#TODO: use libc_dep defined below.
add_global_link_arguments('-lc', language: 'c')
cc = meson.get_compiler('c')
......@@ -18,18 +19,12 @@ libxml_dep = dependency('libxml-2.0', version : '>= 2.6.27')
gmodule_dep = dependency('gmodule-2.0')
libzlib_dep = dependency('zlib')
#TODO: this is optional. Should it be a disabler?
libcairo_dep = dependency('cairo', required : false)
libm_dep = cc.find_library('m', required : false)
libcairo_dep = dependency('cairo')
libm_dep = cc.find_library('m')
libc_dep = cc.find_library('c')
# Used in pixmap csource generation.
gdk_pixbuf_csource = find_program('gdk-pixbuf-csource')
# TODO
#AC_PROG_INSTALL
#AC_PROG_LN_S
#AC_PROG_MAKE_SET
#AC_ISC_POSIX
datadir = join_paths(get_option('prefix'),
get_option('datadir'))
......@@ -60,7 +55,7 @@ endforeach
configuration_inc = include_directories('.')
# FIXME: I don't think this should be defined.
# TODO: I don't think this should be defined.
# To fix we should remove #ifdef HAVE_CONFIG_H checks from all source files.
add_project_arguments('-DHAVE_CONFIG_H', language : 'c')
......
......@@ -11,7 +11,7 @@ icons = [ 'arc.png',
'text.png',
'zigzagline.png' ]
#FIXME: this is duplicated from lib/pixmaps. Any way to remove this duplication?
#TODO: this is duplicated from lib/pixmaps. Any way to remove this duplication?
icon_pairs = []
foreach icon_file : icons
icon_pairs += [icon_file.split('.')[0].underscorify() + '_icon', files(icon_file)]
......
......@@ -26,7 +26,7 @@ subdir('pstricks')
#subdir('stress')
subdir('svg')
# FIXME: requires visio-types.h
# TODO: requires visio-types.h
#subdir('vdx')
#subdir('wmf')
......
......@@ -51,5 +51,5 @@ shape_sources = files(
'datasource.png'
)
#FIXME: the folder should be capitalised as well.
#TODO: the folder should be capitalised as well.
shapes += [[shape_sources, 'Flowchart']]
......@@ -97,7 +97,7 @@ if false
endif
sheet_files_targets = []
# FIXME: use gettext:
# TODO: use gettext:
# https://github.com/mesonbuild/meson/issues/1565
# https://github.com/systemd/systemd/commit/c81217920effddc93fb780cf8f9eb699d6fe1319
# https://wiki.gnome.org/MigratingFromIntltoolToGettext
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment