Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Dia Dia
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 400
    • Issues 400
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • DiaDia
  • Issues
  • #428

Closed
Open
Created Nov 07, 2019 by Nils Steinger@n-stContributor

Endless loop on filenames with invalid encoding

When launching Dia with a filename argument that is not a valid codepoint in the current encoding, it enters an endless loop:

% dia $'\374'
Filename conversion failed: �
Filename conversion failed: �
Filename conversion failed: �
Filename conversion failed: �
Filename conversion failed: �
…

(The file does not need to actually exist.)

This is especially problematic when Dia is invoked by a thumbnail service1: The thumbnailer service (e.g. Tumbler) will usually log all output to syslog, which will very quickly fill up the disk.

Implication: Users with local system access can create an appropriately named file (e.g. touch $'\374'.dia), view the parent directory in a graphical file manager, and thus cause the thumbnailer service to fill the disk (outside of any quota restriction they may have), leading to an unusable system.

On a test system, Dia produced up to 32 MiB (1.3 million lines) of error output per second.

1: Dia registers Exec=dia -t png -e %o -s %s %i as a thumbnailer command in /usr/share/thumbnailers/dia.thumbnailer.

Assignee
Assign to
Time tracking