Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
d-feet
d-feet
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • d-feetd-feet
  • Merge Requests
  • !8

Closed
Opened Sep 19, 2018 by Will Thompson@wjtDeveloper1 of 2 tasks completed1/2 tasks
  • Report abuse
Report abuse

WIP: Correctly honour theme foreground colour

  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 4

As discussed in !4 (comment 319094)

For whatever reason, text is coming out in the wrong colour in the Execute Method dialog when using a dark theme. I don't understand why!

But: why are we explicitly specifying the colour, anyway? Can't we just leave the colour unspecified, so the label will use the default colour (light on dark themes; dark on light themes)?

TODO:

  • This branch is atop !7 (merged) since it touches this code; rebase once !7 (merged) is merged
  • Fix the text colour in the Execute Method dialog with dark themes
Edited Sep 20, 2018 by Will Thompson
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: GNOME/d-feet!8
Source branch: correctly-honour-theme-foreground-colour