Skip to content

WIP: Correctly honour theme foreground colour

Will Thompson requested to merge correctly-honour-theme-foreground-colour into master

As discussed in https://gitlab.gnome.org/GNOME/d-feet/merge_requests/4#note_319094

For whatever reason, text is coming out in the wrong colour in the Execute Method dialog when using a dark theme. I don't understand why!

But: why are we explicitly specifying the colour, anyway? Can't we just leave the colour unspecified, so the label will use the default colour (light on dark themes; dark on light themes)?

TODO:

  • This branch is atop !7 (merged) since it touches this code; rebase once !7 (merged) is merged
  • Fix the text colour in the Execute Method dialog with dark themes
Edited by Will Thompson

Merge request reports