Skip to content

GitLab

d-feet
d-feet
Merged
Opened by Will Thompson@wjtDeveloper

Fix 'make check', detect 'pycodestyle' (the new name for 'pep8'), use Python 3 in Flatpak version, and set up CI

I noticed that make check was broken due to some coding style violations, so decided to take the opportunity to set up GitLab CI. To avoid having to install pep8 in the Flatpak, I added both a Flatpak build (against the master runtime) and a Fedora build (on Rawhide). Then I discovered many things:

  • pep8 has been renamed to pycodestyle; new versions complain about more things
  • The master GNOME runtime does not include Python 2, which was previously used for the app
  • Even if you set PYTHON=/usr/bin/python3, make check previously ran the tests under Python 2

All these things are addressed here. Both builds run with Python 3. Personally, I would support bumping the minimum Python version to 3.5 (or perhaps even newer) and dropping the Python 2 compatibility stuff.

Edited by Will Thompson