1. 18 Jul, 2014 1 commit
  2. 17 Jul, 2014 5 commits
  3. 16 Jul, 2014 4 commits
    • Andrés G. Aragoneses's avatar
      TrackInfoDisplay: consistenly choose a color for both line layouts · b0aa779d
      Andrés G. Aragoneses authored
      The Pango.Layout objects 'first_line_layout' and 'second_line_layout'
      were being assigned a colour in different ways, which could be a bit
      confusing (the latter was using <span color="xyz"> markup, the former
      was using Cairo.Context.SetSourceColor() API), so let's use markup
      in both cases.
      
      This commit changes behaviour, but doesn't (shouldn't) produce a
      different rendering result in any way.
      b0aa779d
    • Andrés G. Aragoneses's avatar
      TrackInfoDisplay: proper mid color for 'from' and 'by' (bgo#732898) · 25fec2bc
      Andrés G. Aragoneses authored
      The mid-color between the default text color and the background color
      of the widget was not being calculated properly because the background
      color obtained for the TrackInfoDisplay widget was the same as the text
      color. This behaviour must have changed recently in GTK3, but what we
      are sure about is that using the Parent's reference colors we get the
      proper colors again (probably because the parent of this widget would
      be a ToolItem, inside a Toolbar, which has its background color surely
      defined, compared to TrackInfoDisplay widget which is implemented in
      the Banshee codebase.
      25fec2bc
    • Andrés G. Aragoneses's avatar
      TrackInfoDisplay: proper fix for not bold but invisible text (bgo#732838) · d3994e49
      Andrés G. Aragoneses authored
      OnStyleUpdated() was in charge of filling the color fields of
      TrackInfoDisplay class with values, but it could happen that
      these colors were retrieved before OnStyleUpdated() hadn't been
      run yet even once, which resulted in a black color, but all
      transparent (alpha=0). The way to fix it is make the colors be
      properties that query the proper value on demand if the value
      had not been set yet, or is resetted.
      
      Thanks to Bertrand Lorentz for the heads up about the hint of
      what was really going on badly.
      d3994e49
    • Andrés G. Aragoneses's avatar
      Revert "ThickClient: workaround for invisible (instead of bold) text (bgo#732838)" · aa9abcda
      Andrés G. Aragoneses authored
      This reverts commit f3f9c330
      because it was just a workaround, and we have found the proper
      fix.
      aa9abcda
  4. 10 Jul, 2014 2 commits
    • Marcin Kolny's avatar
      Fixup: added an informative column (bgo#732339) · 21bf04cb
      Marcin Kolny authored
      This column may be useful so other extensions that use the
      MetadataFixer can give more info about the track being fixed
      (current solvers of this extension can fix many tracks per
      row, so this may not be useful for them, because using just
      a cell to show information about more than one track may be
      ugly; but the solvers being developed in b-c-e mostly add
      one-fix-per-track solvers, therefore the HasTrackDetails
      property will be marked as FALSE by default, but virtual,
      so derived classes can override it).
      Signed-off-by: default avatarAndrés G. Aragoneses <knocte@gmail.com>
      21bf04cb
    • Marcin Kolny's avatar
      Fixup: fixed selecting option values (bgo#732993) · c61da216
      Marcin Kolny authored
      Instead of adding to a list new length of text, sum of previous and
      current text was added. That causes widening range of next option values.
      Because of that, it was impossible to select e.g. fifth (or further)
      value.
      Signed-off-by: default avatarAndrés G. Aragoneses <knocte@gmail.com>
      c61da216
  5. 08 Jul, 2014 1 commit
  6. 07 Jul, 2014 1 commit
    • Andrés G. Aragoneses's avatar
      ThickClient: workaround for invisible (instead of bold) text (bgo#732838) · f3f9c330
      Andrés G. Aragoneses authored
      After several hours attempting to find a reduced testcase for this
      problem (which appears to be somewhere deeper in the stack: pango,
      cairo, or gtk), I've found this harmless workaround that actually
      makes the first line of text (in TrackInfoDisplay class) be more
      consistent with the second line of text (the latter already wrapped
      other markup elements with a wider <span> element using the default
      text colour).
      
      The TextColor and BackgroundColor properties seem to have wrong
      values though (both black, rgb#000000), compared to the stable
      branch (GTK2), but that will be tracked in a different bug, because
      it is unrelated to this issue.
      f3f9c330
  7. 06 Jul, 2014 1 commit
  8. 05 Jul, 2014 2 commits
  9. 28 Jun, 2014 2 commits
    • Andrés G. Aragoneses's avatar
      ThickClient: refactor BaseClientWindow · 058413c3
      Andrés G. Aragoneses authored
      * No need for a ctor of an abstract class to be public.
      * Remove unneeded 'using' clauses.
      * The ConfigureWindow() method was protected virtual but:
      - Nobody was overriding it.
      - Nobody was calling it.
      So now it can be private and non-virtual, and we can encapsulate
      some logic in it related to window configuration (previously it
      was empty).
      058413c3
    • Andrés G. Aragoneses's avatar
      ThickClient: add null check in SourceView (bgo#732373) · c841c1d8
      Andrés G. Aragoneses authored
      This at least avoids Banshee crashing in the stable branch,
      although doesn't seem to fix the root of the problem.
      c841c1d8
  10. 23 Jun, 2014 1 commit
  11. 22 Jun, 2014 1 commit
  12. 19 Jun, 2014 2 commits
    • Nicholas Little's avatar
      Hardware: Add DeviceChanged signal for Dap.Mtp (bgo#729438) · 5a5cb823
      Nicholas Little authored
      To use an MTP device, we must unmount it and release the connection that
      Gvfs makes. Prior to this patch, banshee considered two possible device
      events, added and removed so unmounts had to be covered by the latter
      case, causing MTP devices to be unmapped as they were being configured.
      
      This patch allows the state transition to occur with the assumption that
      the device is still physically present and allows devices which don't
      present a Mount in their VolumeAddedArgs to be recognised when their
      Mounts do become available. This has the added benefit that further down
      the line, we can add sources for yet-to-be-configured devices providing
      the user with setup or error handling instructions.
      
      As a test: without this patch, a Nexus7 device would not be recognized
      by Banshee when connecting it to a laptop running Ubuntu 14.04.
      Signed-off-by: default avatarAndrés G. Aragoneses <knocte@gmail.com>
      5a5cb823
    • Nicholas Little's avatar
      Gio: refactor creation of RawVolume · 73691ef0
      Nicholas Little authored
      Creation of RawVolume instance is done in the same way in
      several places, so we can extract a method where we do
      a sanity check over the volume_device_map dictionary search.
      Signed-off-by: default avatarAndrés G. Aragoneses <knocte@gmail.com>
      73691ef0
  13. 15 Jun, 2014 1 commit
    • Bertrand Lorentz's avatar
      SourceRowRenderer: Rework rendering of the cell background · 1fff9a12
      Bertrand Lorentz authored
      If the cell is selected, just let the GTK theme do the drawing.
      
      If the cell is highlighted but not selected, like when you right click
      on a non-selected cell that is not selected, draw a simple 1 pixel
      border, like we did before.
      
      The notification animation is now a simple rectangle fill, using a color
      halfway between normal and selected. We can't use the color of the
      "active" state anymore, because it now seems to be the same as the
      normal color, at least for treeviews.
      
      We should probably use GTK+ animations for that, but I still need to
      figure out how...
      
      Also update Hyena to the latest git master, to bring in all the latest
      ListView changes.
      1fff9a12
  14. 03 Jun, 2014 2 commits
  15. 27 May, 2014 1 commit
    • Andrés G. Aragoneses's avatar
      Fixup: remove unnecessary dependencies · 30ac3595
      Andrés G. Aragoneses authored
      Banshee.Fixup didn't really need these two assembly dependencies:
      
       a) MusicBrainz: probably added by mistake
       b) Migo: to remove this one, two classes from it which were not
        specific to Migo.Syndication were moved to Hyena.
      30ac3595
  16. 22 May, 2014 3 commits
    • Dmitrii Petukhov's avatar
      ThickClient: Add "Playing Track" submenu (bgo#726338) · b7eb9bb8
      Dmitrii Petukhov authored
      When some user requested to have CoverArt modification for the
      playing track in the "Edit" menu (bgo#724795), we realised that
      it was not clear at all that this menu affected just to selected
      tracks, not to the playing track. The two previous patches then
      modified the UI to include these options under a new "Selected
      Track(s)" submenu.
      
      Now, this change introduces a similar submenu (with the same
      options) but which applies only to the playing track. This only
      works for now if the track played is in the main Music library,
      and it can be extended for more sources in the future.
      Signed-off-by: default avatarAndrés G. Aragoneses <knocte@gmail.com>
      b7eb9bb8
    • Dmitrii Petukhov's avatar
      Refactoring: rename "SelectedTracks" methods&labels (bgo#726338) · 33ec250b
      Dmitrii Petukhov authored
      Renamed all "...Tracks" to "SelectedTracks" labels and methods,
      following the previous commit, which places all the actions under
      this "Selected Track(s)" submenu.
      
      This is especially useful, to distinguish them from the next
      methods and actions which will be committed in the next changeset,
      which will introduce a new Playing Track submenu.
      Signed-off-by: default avatarAndrés G. Aragoneses <knocte@gmail.com>
      33ec250b
    • Dmitrii Petukhov's avatar
      ThickClient: add "Selected Track(s)" submenu (bgo#726338) · 60e1b7d3
      Dmitrii Petukhov authored
      Behavior of the options from the "Edit" menu was not so clear:
      did these options target the playing track or the selected ones?
      So, adding "Selected Track(s)" submenu and moving all the appropriate
      options into it makes it much more clear.
      Signed-off-by: default avatarAndrés G. Aragoneses <knocte@gmail.com>
      60e1b7d3
  17. 20 May, 2014 1 commit
  18. 18 May, 2014 1 commit
  19. 15 May, 2014 2 commits
  20. 06 May, 2014 1 commit
    • Andrés G. Aragoneses's avatar
      SourceActions: code cleanup · 2ad23085
      Andrés G. Aragoneses authored
      - Removed unused usings.
      - Converted property to auto-property.
      - Use new lambda delegate syntax.
      - Add missing braces in foreach and if blocks, to conform to
      style guidelines.
      - Use a static cast instead of a dynamic cast (as it was not
      checking for null, and could lead to NREs instead of ICEs).
      2ad23085
  21. 05 May, 2014 1 commit
  22. 04 May, 2014 1 commit
  23. 17 Apr, 2014 2 commits
  24. 13 Apr, 2014 1 commit