Commit b2abfcf4 authored by Nicholas Little's avatar Nicholas Little Committed by Andrés G. Aragoneses

Dap.MassStorage: add logging to empty catch{} blocks

While finding a fix for bug 729438 we have gone through some
scenarios in which an exception was being thrown, and caught
by empty catch{} blocks, hiding a regression which would have
been a bit clear if there was at least some logging in these
code flows.

So let's add it. If it becomes too noisy, we could still move
it to only be logged on debug mode, but never logging it looks
like a mistake.
Signed-off-by: Andrés G. Aragoneses's avatarAndrés G. Aragoneses <knocte@gmail.com>
parent 3efd419d
......@@ -72,7 +72,9 @@ namespace Banshee.Dap.MassStorage
if (ms_device.ShouldIgnoreDevice () || !ms_device.LoadDeviceConfiguration ()) {
ms_device = null;
}
} catch {
} catch (Exception e) {
Log.Exception (e);
ms_device = null;
}
......@@ -673,7 +675,9 @@ namespace Banshee.Dap.MassStorage
try {
SafeUri uri = new SafeUri (command.DeviceId);
return BaseDirectory.StartsWith (uri.LocalPath);
} catch {
} catch (Exception e) {
Log.Exception (e);
return false;
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment