Commit 5673e5a8 authored by Andrés G. Aragoneses's avatar Andrés G. Aragoneses

Podcasting: improve previous fix to not show the tweaked URL (bgo#729193)

The problem with previous fix was this: let's say the user tries
to add the URL for a podcast like this: ftp://mikrowelle.me/opus.xml.
As you can see, this URL already has a protocol, and what happens is
that the FTP access for that site is closed, so then banshee considers
it as not parseable, and with the previous fix, banshee would test
the URL "http://ftp://mikrowelle.me/opus.xml", and then it would
tell the user that there was a problem when parsing that last URL.

The way to fix this is to not overwrite the feedUri variable in the
second call to TryParseUrl(), so that, if an error has to be shown,
it will be about the URL that the user entered, not the tweaked one.
parent 5371c382
......@@ -343,7 +343,8 @@ namespace Banshee.Podcasting.Gui
return;
}
if (!TryParseUrl (url, out feedUri) && !TryParseUrl ("http://" + url, out feedUri)) {
Uri tweaked_feed_uri;
if (!TryParseUrl (url, out feedUri) && !TryParseUrl ("http://" + url, out tweaked_feed_uri)) {
HigMessageDialog.RunHigMessageDialog (
null,
DialogFlags.Modal,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment