Use GLib's g_once_init_* methods to initialise the global GMime parser
options instead of explicitly calling libbalsa_parser_options_init().

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

error: implicit truncation from 'int' to a one-bit wide bit-field
changes value from 1 to -1

See also MISRA C:2012, Rule 6.2 "Single-bit named bit fields shall not
be of a signed type":

"According to the C99 Standard Section 6.2.6.2, a single-bit signed
bit-field has a single (one) sign bit and no (zero) value bits. In any
representation of integers, 0 value bits cannot specify a meaningful
value.

A single-bit signed bit-field is therefore unlikely to behave in a
useful way and its presence is likely to indicate programmer confusion."

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

error: a function declaration without a prototype is deprecated in all
versions of C and is treated as a zero-parameter prototype in C2x,
conflicting with a subsequent definition

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

error: 'sscanf' may overflow; destination buffer in argument 3 has size
256, but the corresponding specifier may require size 257

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

Free the value returned by gtk_file_chooser_get_filename().

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

The value returned by the function calls is never used (detected by
scan-build-16).

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

improve dealing with user credentials

Closes #52

See merge request !80

This patch improves using Balsa binaries built with “libsecret” support
in situations where the Secret Service is not available or usable.  It
should fix the issues described in #52

.  To this end, an environment
variable is used to force using the obfuscated config file.

Any libsecret error messages are reported through desktop notifications
instead of just writing them as debug messages.

Add a toggle icon to password text entry widgets to show/hide the value
(note: not in the GcrUi.PromptDialog).

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

---
Details:
- libbalsa/address-book-(carddav|ldap).c, libbalsa/server.c: refactor
  loading and saving credentials, respect the env. variable to disable
  using libsecret, use password entry helper
- libbalsa/libbalsa-conf.[ch]: add method to check the env. variable to
  disable using libsecret
- libbalsa/misc.[ch]: add helper to configure a GtkEnry as password
  entry, with a toggle icon to show/hide the value
- libbalsa/server-config.c, src/balsa-app.c: respect the env. variable
  to disable using libsecret, use password entry helper
- src/address-book-config.c: use password entry helper
- README.md: improve documentation re. storing credentials

Misplaced #include statements cause build error.

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

* Fix CardDAV lookup of items containing non-ASCII characters as the
  comparison must use normalised values.
* Fix comment in the (generated) config.h header file.

Signed-off-by: Albrecht Dreß <albrecht.dress@posteo.de>

DOAP: Replace defunct mailing list with Discourse support forum

See merge request !79