1. 30 Oct, 2021 2 commits
    • Øyvind "pippin" Kolås's avatar
      tests: add a xyz to lab test · 2c9843f4
      Øyvind "pippin" Kolås authored
      This is testing D50 XYZ to D50 CIE Lab the use of D50 for all XYZ and
      Lab is currently implicit in all babl code.
      2c9843f4
    • Øyvind "pippin" Kolås's avatar
      Oklab: disable only Oklch not Oklab · 3e5e4ed2
      Øyvind "pippin" Kolås authored
      Oklab itself is enabled by default now for testing, but does not seem to
      produce correct values with the Oklab test vectors, even with manual
      attempt at converting the test vector (presumed) CIE XYZ D65 to CIE XYZ
      D50 before running the conversion.
      
      The failure to pass symmetry tests as mentioned in issue #63 seems to be
      limited to Oklch, Oklab itself is fine.
      3e5e4ed2
  2. 28 Oct, 2021 9 commits
  3. 01 Jul, 2021 2 commits
  4. 15 May, 2021 2 commits
    • Jehan's avatar
      babl: re-creation of palette conversions must always set data. · 69e6b090
      Jehan authored and Øyvind "pippin" Kolås's avatar Øyvind "pippin" Kolås committed
      If we allow conversions to be recreated for palettes, it will create a
      new identical conversion with collision number incremented in the name
      and no user data. Yet the user data is extremely important for palette
      conversions, because it contains the palette itself which is required by
      the palette conversion functions. Hence we end up crashing.
      
      Moreover, although I think that right now, only palette conversions use
      the data field, it might be used for other type of data in the future.
      In any case, we should always save this data along as it has been stored
      there for a reason.
      
      Finally in babl-palette code, make sure the user data is added to the
      models before creating the formats and conversions as we also ended up
      in crash-happy code when we didn't.
      
      See: gimp#6501
      69e6b090
    • Jehan's avatar
      babl: do not append space to the format name when explicitly set. · 4c7c2b75
      Jehan authored and Øyvind "pippin" Kolås's avatar Øyvind "pippin" Kolås committed
      When a format is named explicitly by the caller, we should just keep the
      same name, not tweak it. Generating a name is only valid when no
      explicit name is given. Moreover this is the behavior as described in
      the docs of babl_format_new():
      
      > If no name is provided a (long) descriptive name is used.
      
      (which usually implies that with a name provided, this one will be used
      instead of a generated name)
      
      This is especially important for palette formats for which name is
      mostly not descriptive anyway (either caller-set or generated by babl
      with incremental number) and this fixes a bug when calling
      babl_new_palette_with_space() with the same name and space would fail to
      find the already created formats (yet would find the models and return
      NULL for both formats) because it would search without the space
      description appended. Yet the docs of babl_new_palette*() clearly says
      as well:
      
      > If you pass in the same name the previous formats will be provi...
      4c7c2b75
  5. 03 May, 2021 1 commit
  6. 26 Feb, 2021 4 commits
  7. 25 Feb, 2021 4 commits
  8. 19 Feb, 2021 1 commit
  9. 18 Feb, 2021 3 commits
  10. 03 Feb, 2021 2 commits
  11. 23 Jan, 2021 1 commit
  12. 17 Dec, 2020 2 commits
  13. 30 Nov, 2020 1 commit
  14. 04 Oct, 2020 2 commits
  15. 07 Aug, 2020 3 commits
  16. 02 Aug, 2020 1 commit