Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • A atk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • atk
  • Merge requests
  • !50

atkutil: Store previous focus object as GWeakRef

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Marek Kašík requested to merge mkasik/atk:previous-focus-object-leak into master Apr 28, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Use GWeakRef for keeping reference to previous focus object instead of keeping strong reference to it. This avoids to leak the last focus object because it was never dereferenced.

This reference prevents Evince to finalize EvViewAccessible which then does not unref EvDocumentModel which then does not unref EvDocument, etc.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: previous-focus-object-leak