Skip to content

Clean up some warnings

Jonathan Blandford requested to merge jrb/aisleriot:master into master

In preparation for porting to GTK4, I wanted to get the warning count much lower so I could see more of what's going on. This MR will remove a number of the mechanical compile warnings to fix, but otherwise keep the game untouched. Primarily, it:

  1. migrates to G_DEFINE_TYPE for all the classes that had priv members
  2. a couple librsvg driveby upgrades
  3. some gint/uint mismatches. These are mostly caused by the slot ids and card ids being ints. I'd like to investigate this a bit more fully to see if turning them into a uint could make sense.

There's also code to temporarily turn off the old GtkStock registration code. That code is all gtk2 era, and was deprecated early in the GTK3 timeline. It will be replaced with a GResource. It's convenient to be able to disable it locally as it produces a ton or warnings.

Merge request reports