Skip to content

Added support for 'data-ciphers-fallback' option

Jakub Strnad requested to merge jakub.strnad/NetworkManager-openvpn:add-data-ciphers-fallback-option into main

Hello, this is my first merge request to this project, so please forgive if I am unfamiliar with the process or missed some steps.

Motivation for merge request: The current behavior is that .ovpn files with data-ciphers-fallback work fine if run via openvpn cli, but fail or are ignored when run via NetworkManager.

Therefore I added support for .ovpn config option data-ciphers-fallback, so that when an .ovpn file has this option, it is read, parsed and used by NetworkManager. If the changes made here are not present, the option either doesn't get parsed, or it crashes with a BadArgument error if it is added manually to the .nmconnection file.

Changes: Added parsing support for data-ciphers-fallback wherever applicable, modified tests to include check for this option (albeit, null).

Questions: What should I do with the .po files? Should I also include them in the merge request? Will they be fine as they are regenerated, or they require more work?

Thanks, Jakub

Merge request reports