Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager-openvpn NetworkManager-openvpn
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • NetworkManager-openvpnNetworkManager-openvpn
  • Merge requests
  • !57

helper: handle DOMAIN-SEARCH in addition to DOMAIN

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Roman Kagan requested to merge rvka/NetworkManager-openvpn:domain-search into main Sep 07, 2022
  • Overview 9
  • Commits 1
  • Pipelines 2
  • Changes 1

OpenVPN has suppport for (multivalued) DHCP option DOMAIN-SEARCH (119), which is ignored by nm-opevpn.

Core NetworkManager doesn't have an option for them either.

However, in practical terms it appears to make sense to just append them to the domains list.

So handle DOMAIN-SEARCH options mostly similar to DOMAIN ones. Since it's not unlikely that some servers may use multiple DOMAIN and DOMAIN-SEARCH values, accumulate the latter ones in a separate array first and then append it to the tail of the domains array.

Enhancement - so NM OpenVPN would do something ... (#81)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: domain-search