Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager-openvpn NetworkManager-openvpn
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • NetworkManager-openvpnNetworkManager-openvpn
  • Merge requests
  • !50

import: fix importing profiles with PKCS#12 CA

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Beniamino Galvani requested to merge bg/pkcs12-ca-fix into main Jul 06, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

have_ca indicates whether we have an explicit CA cert; don't set it when the CA is from a PKCS#12 file.

Without this fix, trying to import a profile with a PKCS#12 that includes the CA certificate results in error:

 "--ca can not be PKCS#12 format"

because we first set have_pkcs12=TRUE, have_ca=TRUE and then we check that the CA is not in PKCS#12 format.

Fixes: 34a0c925 ("Handle the various pkcs12/cert/key/ca combinations.")

#83 (closed)

cc: @slowbro

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bg/pkcs12-ca-fix