Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager-openvpn NetworkManager-openvpn
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • NetworkManager-openvpnNetworkManager-openvpn
  • Merge requests
  • !46

Add support for OpenVPN's --data-ciphers

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Gard Spreemann requested to merge gspr/NetworkManager-openvpn:gspr/data-ciphers into main Jun 21, 2022
  • Overview 13
  • Commits 1
  • Pipelines 1
  • Changes 5

It used to be the case that OpenVPN added the cipher from --cipher to the ones provided by --data-ciphers. As of OpenVPN 2.6, that is no longer the case.

This patch adds rudamentary support for OpenVPN's --data-ciphers. The argument is treated exactly like the "cipher" field in a connection's .data, and thus passes a "data-ciphers" field in .data directly on to OpenVPN's --data-ciphers. This may not be appropriate in a GUI/TUI, as --data-ciphers is a colon-separated list, but is here treated as an opaque string.

The patch has only been lightly tested: It compiles and works with a connection that needed "data-ciphers = AES-128-CBC", and that was broken with only "cipher = AES-128-CBC" when upgrading to OpenVPN 2.6.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gspr/data-ciphers